From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_net: enable big packets for large MTU values
Date: Wed, 29 Mar 2017 19:13:33 +0300 [thread overview]
Message-ID: <20170329191324-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1490791079-22108-1-git-send-email-mst@redhat.com>
On Wed, Mar 29, 2017 at 03:38:09PM +0300, Michael S. Tsirkin wrote:
> If one enables e.g. jumbo frames without mergeable
> buffers, packets won't fit in 1500 byte buffers
> we use. Switch to big packet mode instead.
> TODO: make sizing more exact, possibly extend small
> packet mode to use larger pages.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Fixes: 14de9d114a82 ("virtio-net: Add initial MTU advice feature")
> ---
> drivers/net/virtio_net.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index e0fb3707..9dc31dc 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2428,6 +2428,10 @@ static int virtnet_probe(struct virtio_device *vdev)
> dev->mtu = mtu;
> dev->max_mtu = mtu;
> }
> +
> + /* TODO: size buffers correctly in this case. */
> + if (dev->mtu > ETH_DATA_LEN)
> + vi->big_packets = true;
> }
>
> if (vi->any_header_sg)
> --
> MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jason Wang <jasowang@redhat.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] virtio_net: enable big packets for large MTU values
Date: Wed, 29 Mar 2017 19:13:33 +0300 [thread overview]
Message-ID: <20170329191324-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1490791079-22108-1-git-send-email-mst@redhat.com>
On Wed, Mar 29, 2017 at 03:38:09PM +0300, Michael S. Tsirkin wrote:
> If one enables e.g. jumbo frames without mergeable
> buffers, packets won't fit in 1500 byte buffers
> we use. Switch to big packet mode instead.
> TODO: make sizing more exact, possibly extend small
> packet mode to use larger pages.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Fixes: 14de9d114a82 ("virtio-net: Add initial MTU advice feature")
> ---
> drivers/net/virtio_net.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index e0fb3707..9dc31dc 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2428,6 +2428,10 @@ static int virtnet_probe(struct virtio_device *vdev)
> dev->mtu = mtu;
> dev->max_mtu = mtu;
> }
> +
> + /* TODO: size buffers correctly in this case. */
> + if (dev->mtu > ETH_DATA_LEN)
> + vi->big_packets = true;
> }
>
> if (vi->any_header_sg)
> --
> MST
next prev parent reply other threads:[~2017-03-29 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 12:38 [PATCH] virtio_net: enable big packets for large MTU values Michael S. Tsirkin
2017-03-29 12:38 ` Michael S. Tsirkin
2017-03-29 16:13 ` Michael S. Tsirkin [this message]
2017-03-29 16:13 ` Michael S. Tsirkin
2017-03-30 4:03 ` Jason Wang
2017-03-30 4:03 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329191324-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.