From: Joerg Roedel <jroedel-l3A5Bk7waGM@public.gmane.org>
To: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iommu/vt-d: Make sure IOMMUs are off when intel_iommu=off
Date: Wed, 29 Mar 2017 23:01:43 +0200 [thread overview]
Message-ID: <20170329210143.GV8329@suse.de> (raw)
In-Reply-To: <20170329085153.5d215d44@jacob-builder>
On Wed, Mar 29, 2017 at 08:51:53AM -0700, Jacob Pan wrote:
> On Wed, 29 Mar 2017 17:00:39 +0200
> Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> wrote:
> > +static void intel_disable_iommus(void)
> > +{
> > + struct intel_iommu *iommu = NULL;
> > + struct dmar_drhd_unit *drhd;
> > +
> > + for_each_iommu(iommu, drhd)
> > + iommu_disable_translation(iommu);
> should we also disable IR here? i.e.
> iommu_disable_irq_remapping(iommu);
No, irq remapping depends on another parameter (intremap=off) and needs
to be handled seperatly. I already looked at it and this needs to be
part of a larger effort as it required changes in code-paths that are
shared between Intel and AMD IOMMU drivers.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <jroedel@suse.de>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/vt-d: Make sure IOMMUs are off when intel_iommu=off
Date: Wed, 29 Mar 2017 23:01:43 +0200 [thread overview]
Message-ID: <20170329210143.GV8329@suse.de> (raw)
In-Reply-To: <20170329085153.5d215d44@jacob-builder>
On Wed, Mar 29, 2017 at 08:51:53AM -0700, Jacob Pan wrote:
> On Wed, 29 Mar 2017 17:00:39 +0200
> Joerg Roedel <joro@8bytes.org> wrote:
> > +static void intel_disable_iommus(void)
> > +{
> > + struct intel_iommu *iommu = NULL;
> > + struct dmar_drhd_unit *drhd;
> > +
> > + for_each_iommu(iommu, drhd)
> > + iommu_disable_translation(iommu);
> should we also disable IR here? i.e.
> iommu_disable_irq_remapping(iommu);
No, irq remapping depends on another parameter (intremap=off) and needs
to be handled seperatly. I already looked at it and this needs to be
part of a larger effort as it required changes in code-paths that are
shared between Intel and AMD IOMMU drivers.
Joerg
next prev parent reply other threads:[~2017-03-29 21:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 15:00 [PATCH] iommu/vt-d: Make sure IOMMUs are off when intel_iommu=off Joerg Roedel
2017-03-29 15:00 ` Joerg Roedel
[not found] ` <1490799639-15965-1-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-03-29 15:51 ` Jacob Pan
2017-03-29 15:51 ` Jacob Pan
2017-03-29 21:01 ` Joerg Roedel [this message]
2017-03-29 21:01 ` Joerg Roedel
2017-04-12 1:40 ` Baoquan He
2017-04-12 1:40 ` Baoquan He
2017-04-12 21:54 ` Joerg Roedel
2017-04-12 21:54 ` Joerg Roedel
[not found] ` <20170412215408.GF7266-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2017-04-12 22:57 ` Baoquan He
2017-04-12 22:57 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170329210143.GV8329@suse.de \
--to=jroedel-l3a5bk7wagm@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.