* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
@ 2017-05-19 5:50 ` Michael Ellerman
0 siblings, 0 replies; 17+ messages in thread
From: Michael Ellerman @ 2017-05-19 5:50 UTC (permalink / raw)
To: Pavel Machek, Andrew Morton
Cc: sr-ynQEQJNshbs, jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r,
paulus-eUNUBHrolfbYtjvyW6yDsg, devicetree-u79uwXL29TY76Z2rM5mHXA,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
trivial-DgEjT+Ai2ygdnm+yROfE0A, Andrew Morton
Pavel Machek <pavel-ynQEQJNshbs@public.gmane.org> writes:
> On Wed 2017-05-17 14:37:17, Andrew Morton wrote:
>> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel-ynQEQJNshbs@public.gmane.org> wrote:
>>
>> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
>> > > Fix overlapping NAND partitions.
>> > >
>> > > Signed-off-by: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
>> >
>> > Ping? Two partitions at same place are bad news...
>>
>> Please expand on "bad news"? What are the runtime effects of this
>> change? Decisions about which kernel(s) to patch depend on this info.
>
> Well... two partitions at same place. If you use one, you will corrupt
> information on the other one.
>
> OTOH this moves partition around (so that they don't overlap) so it is
> probably not stable candidate.
>
> I guess this is not huge issue; people using these boards probably
> have custom dts changes, anyway...
Or no one's even using it anymore.
I can take this via powerpc, I won't mark it for stable etc.
cheers
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
@ 2017-05-19 9:12 ` Pavel Machek
0 siblings, 0 replies; 17+ messages in thread
From: Pavel Machek @ 2017-05-19 9:12 UTC (permalink / raw)
To: Michael Ellerman
Cc: Andrew Morton, sr, jwboyer, robh+dt, mark.rutland, benh, paulus,
devicetree, linuxppc-dev, linux-kernel, trivial, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
Hi!
> > Well... two partitions at same place. If you use one, you will corrupt
> > information on the other one.
> >
> > OTOH this moves partition around (so that they don't overlap) so it is
> > probably not stable candidate.
> >
> > I guess this is not huge issue; people using these boards probably
> > have custom dts changes, anyway...
>
> Or no one's even using it anymore.
>
> I can take this via powerpc, I won't mark it for stable etc.
That sounds good.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
@ 2017-05-19 9:12 ` Pavel Machek
0 siblings, 0 replies; 17+ messages in thread
From: Pavel Machek @ 2017-05-19 9:12 UTC (permalink / raw)
To: Michael Ellerman
Cc: Andrew Morton, sr-ynQEQJNshbs,
jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r,
paulus-eUNUBHrolfbYtjvyW6yDsg, devicetree-u79uwXL29TY76Z2rM5mHXA,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
trivial-DgEjT+Ai2ygdnm+yROfE0A, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
Hi!
> > Well... two partitions at same place. If you use one, you will corrupt
> > information on the other one.
> >
> > OTOH this moves partition around (so that they don't overlap) so it is
> > probably not stable candidate.
> >
> > I guess this is not huge issue; people using these boards probably
> > have custom dts changes, anyway...
>
> Or no one's even using it anymore.
>
> I can take this via powerpc, I won't mark it for stable etc.
That sounds good.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
2017-05-19 5:50 ` Michael Ellerman
(?)
(?)
@ 2017-05-19 10:04 ` Michael Ellerman
2017-05-19 11:18 ` Pavel Machek
-1 siblings, 1 reply; 17+ messages in thread
From: Michael Ellerman @ 2017-05-19 10:04 UTC (permalink / raw)
To: Pavel Machek, Andrew Morton
Cc: mark.rutland, devicetree, trivial, linux-kernel, robh+dt, paulus,
Andrew Morton, jwboyer, sr, linuxppc-dev
Michael Ellerman <mpe@ellerman.id.au> writes:
> Pavel Machek <pavel@denx.de> writes:
>
>> On Wed 2017-05-17 14:37:17, Andrew Morton wrote:
>>> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote:
>>>
>>> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
>>> > > Fix overlapping NAND partitions.
>>> > >
>>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>> >
>>> > Ping? Two partitions at same place are bad news...
>>>
>>> Please expand on "bad news"? What are the runtime effects of this
>>> change? Decisions about which kernel(s) to patch depend on this info.
>>
>> Well... two partitions at same place. If you use one, you will corrupt
>> information on the other one.
>>
>> OTOH this moves partition around (so that they don't overlap) so it is
>> probably not stable candidate.
>>
>> I guess this is not huge issue; people using these boards probably
>> have custom dts changes, anyway...
>
> Or no one's even using it anymore.
>
> I can take this via powerpc, I won't mark it for stable etc.
It became:
Author: Pavel Machek <pavel@denx.de>
powerpc/sequoia: Fix NAND partitions not to overlap
Currently the DTS defines two partitions at the same addresses, if you
use one, you will corrupt information on the other one. Fix it by
shifting the second partition.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
[mpe: Reconstruct change log from email thread]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Minor nit, your From: address doesn't match your Signed-off-by: address,
which trips my "check patch is signed-off-by author" script. I can
just ignore it, but I think it's preferable if they match.
cheers
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
@ 2017-05-19 11:18 ` Pavel Machek
0 siblings, 0 replies; 17+ messages in thread
From: Pavel Machek @ 2017-05-19 11:18 UTC (permalink / raw)
To: Michael Ellerman
Cc: Andrew Morton, mark.rutland, devicetree, trivial, linux-kernel,
robh+dt, paulus, Andrew Morton, jwboyer, sr, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]
Hi!
> >>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> >>> >
> >>> > Ping? Two partitions at same place are bad news...
> >>>
> >>> Please expand on "bad news"? What are the runtime effects of this
> >>> change? Decisions about which kernel(s) to patch depend on this info.
> >>
> >> Well... two partitions at same place. If you use one, you will corrupt
> >> information on the other one.
> >>
> >> OTOH this moves partition around (so that they don't overlap) so it is
> >> probably not stable candidate.
> >>
> >> I guess this is not huge issue; people using these boards probably
> >> have custom dts changes, anyway...
> >
> > Or no one's even using it anymore.
> >
> > I can take this via powerpc, I won't mark it for stable etc.
>
> It became:
>
> Author: Pavel Machek <pavel@denx.de>
>
> powerpc/sequoia: Fix NAND partitions not to overlap
>
> Currently the DTS defines two partitions at the same addresses, if you
> use one, you will corrupt information on the other one. Fix it by
> shifting the second partition.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> [mpe: Reconstruct change log from email thread]
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
>
> Minor nit, your From: address doesn't match your Signed-off-by: address,
> which trips my "check patch is signed-off-by author" script. I can
> just ignore it, but I think it's preferable if they match.
Sorry about that (I have automatic scripts changing From:). It is
still me, but I guess denx should get the credit here, so you can use.
Signed-off-by: Pavel Machek <pavel@denx.de>
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
@ 2017-05-19 11:18 ` Pavel Machek
0 siblings, 0 replies; 17+ messages in thread
From: Pavel Machek @ 2017-05-19 11:18 UTC (permalink / raw)
To: Michael Ellerman
Cc: Andrew Morton, mark.rutland-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA, trivial-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, paulus-eUNUBHrolfbYtjvyW6yDsg,
Andrew Morton, jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8,
sr-ynQEQJNshbs, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ
[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]
Hi!
> >>> > > Signed-off-by: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
> >>> >
> >>> > Ping? Two partitions at same place are bad news...
> >>>
> >>> Please expand on "bad news"? What are the runtime effects of this
> >>> change? Decisions about which kernel(s) to patch depend on this info.
> >>
> >> Well... two partitions at same place. If you use one, you will corrupt
> >> information on the other one.
> >>
> >> OTOH this moves partition around (so that they don't overlap) so it is
> >> probably not stable candidate.
> >>
> >> I guess this is not huge issue; people using these boards probably
> >> have custom dts changes, anyway...
> >
> > Or no one's even using it anymore.
> >
> > I can take this via powerpc, I won't mark it for stable etc.
>
> It became:
>
> Author: Pavel Machek <pavel-ynQEQJNshbs@public.gmane.org>
>
> powerpc/sequoia: Fix NAND partitions not to overlap
>
> Currently the DTS defines two partitions at the same addresses, if you
> use one, you will corrupt information on the other one. Fix it by
> shifting the second partition.
>
> Signed-off-by: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
> [mpe: Reconstruct change log from email thread]
> Signed-off-by: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
>
>
> Minor nit, your From: address doesn't match your Signed-off-by: address,
> which trips my "check patch is signed-off-by author" script. I can
> just ignore it, but I think it's preferable if they match.
Sorry about that (I have automatic scripts changing From:). It is
still me, but I guess denx should get the credit here, so you can use.
Signed-off-by: Pavel Machek <pavel-ynQEQJNshbs@public.gmane.org>
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
2017-05-19 11:18 ` Pavel Machek
@ 2017-05-22 9:12 ` Michael Ellerman
-1 siblings, 0 replies; 17+ messages in thread
From: Michael Ellerman @ 2017-05-22 9:12 UTC (permalink / raw)
To: Pavel Machek
Cc: Andrew Morton, mark.rutland, devicetree, trivial, linux-kernel,
robh+dt, paulus, Andrew Morton, jwboyer, sr, linuxppc-dev
Pavel Machek <pavel@denx.de> writes:
> Hi!
>
>> >>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>> >>> >
>> >>> > Ping? Two partitions at same place are bad news...
>> >>>
>> >>> Please expand on "bad news"? What are the runtime effects of this
>> >>> change? Decisions about which kernel(s) to patch depend on this info.
>> >>
>> >> Well... two partitions at same place. If you use one, you will corrupt
>> >> information on the other one.
>> >>
>> >> OTOH this moves partition around (so that they don't overlap) so it is
>> >> probably not stable candidate.
>> >>
>> >> I guess this is not huge issue; people using these boards probably
>> >> have custom dts changes, anyway...
>> >
>> > Or no one's even using it anymore.
>> >
>> > I can take this via powerpc, I won't mark it for stable etc.
>>
>> It became:
>>
>> Author: Pavel Machek <pavel@denx.de>
>>
>> powerpc/sequoia: Fix NAND partitions not to overlap
>>
>> Currently the DTS defines two partitions at the same addresses, if you
>> use one, you will corrupt information on the other one. Fix it by
>> shifting the second partition.
>>
>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>> [mpe: Reconstruct change log from email thread]
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>>
>>
>> Minor nit, your From: address doesn't match your Signed-off-by: address,
>> which trips my "check patch is signed-off-by author" script. I can
>> just ignore it, but I think it's preferable if they match.
>
> Sorry about that (I have automatic scripts changing From:). It is
> still me, but I guess denx should get the credit here, so you can use.
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
Sure, done.
cheers
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
@ 2017-05-22 9:12 ` Michael Ellerman
0 siblings, 0 replies; 17+ messages in thread
From: Michael Ellerman @ 2017-05-22 9:12 UTC (permalink / raw)
To: Pavel Machek
Cc: Andrew Morton, mark.rutland-5wv7dgnIgG8,
devicetree-u79uwXL29TY76Z2rM5mHXA, trivial-DgEjT+Ai2ygdnm+yROfE0A,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, paulus-eUNUBHrolfbYtjvyW6yDsg,
Andrew Morton, jwboyer-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8,
sr-ynQEQJNshbs, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ
Pavel Machek <pavel-ynQEQJNshbs@public.gmane.org> writes:
> Hi!
>
>> >>> > > Signed-off-by: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
>> >>> >
>> >>> > Ping? Two partitions at same place are bad news...
>> >>>
>> >>> Please expand on "bad news"? What are the runtime effects of this
>> >>> change? Decisions about which kernel(s) to patch depend on this info.
>> >>
>> >> Well... two partitions at same place. If you use one, you will corrupt
>> >> information on the other one.
>> >>
>> >> OTOH this moves partition around (so that they don't overlap) so it is
>> >> probably not stable candidate.
>> >>
>> >> I guess this is not huge issue; people using these boards probably
>> >> have custom dts changes, anyway...
>> >
>> > Or no one's even using it anymore.
>> >
>> > I can take this via powerpc, I won't mark it for stable etc.
>>
>> It became:
>>
>> Author: Pavel Machek <pavel-ynQEQJNshbs@public.gmane.org>
>>
>> powerpc/sequoia: Fix NAND partitions not to overlap
>>
>> Currently the DTS defines two partitions at the same addresses, if you
>> use one, you will corrupt information on the other one. Fix it by
>> shifting the second partition.
>>
>> Signed-off-by: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
>> [mpe: Reconstruct change log from email thread]
>> Signed-off-by: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
>>
>>
>> Minor nit, your From: address doesn't match your Signed-off-by: address,
>> which trips my "check patch is signed-off-by author" script. I can
>> just ignore it, but I think it's preferable if they match.
>
> Sorry about that (I have automatic scripts changing From:). It is
> still me, but I guess denx should get the credit here, so you can use.
>
> Signed-off-by: Pavel Machek <pavel-ynQEQJNshbs@public.gmane.org>
Sure, done.
cheers
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 17+ messages in thread