[meta-raspberrypi][PATCH] Add recipe to build qtbase for raspberrypi out of the box.

[meta-raspberrypi][PATCH] Add recipe to build qtbase for raspberrypi out of the box.

[Herve Jourdain]

Supports different EGLFS_DEVICE_INTEGRATION for userland or vc4

Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
---
 recipes-qt/qt5/qtbase_%.bbappend | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 recipes-qt/qt5/qtbase_%.bbappend

diff --git a/recipes-qt/qt5/qtbase_%.bbappend b/recipes-qt/qt5/qtbase_%.bbappend
new file mode 100644
index 0000000..aebcaf9
--- /dev/null
+++ b/recipes-qt/qt5/qtbase_%.bbappend
@@ -0,0 +1,10 @@
+PACKAGECONFIG_GL_rpi = "gles2 eglfs"
+DEPENDS_${PN}_append_rpi = " virtual/egl"
+
+OE_QTBASE_EGLFS_DEVICE_INTEGRATION = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', 'eglfs_kms', 'eglfs_brcm', d)}"
+
+do_configure_prepend() {
+    # Add the appropriate EGLFS_DEVICE_INTEGRATION, depending if using VC4 or USERLAND
+    echo "EGLFS_DEVICE_INTEGRATION = ${OE_QTBASE_EGLFS_DEVICE_INTEGRATION}" > ${S}/mkspecs/oe-device-extra.pri
+}
+
-- 
2.7.4

Re: [meta-raspberrypi][PATCH] Add recipe to build qtbase for raspberrypi out of the box.

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]

On Thu, Jan 19, 2017 at 09:16:05PM +0800, Herve Jourdain wrote:
> Supports different EGLFS_DEVICE_INTEGRATION for userland or vc4
>
> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
> ---
>  recipes-qt/qt5/qtbase_%.bbappend | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 recipes-qt/qt5/qtbase_%.bbappend
>
> diff --git a/recipes-qt/qt5/qtbase_%.bbappend b/recipes-qt/qt5/qtbase_%.bbappend
> new file mode 100644
> index 0000000..aebcaf9
> --- /dev/null
> +++ b/recipes-qt/qt5/qtbase_%.bbappend
> @@ -0,0 +1,10 @@
> +PACKAGECONFIG_GL_rpi = "gles2 eglfs"
> +DEPENDS_${PN}_append_rpi = " virtual/egl"
> +
> +OE_QTBASE_EGLFS_DEVICE_INTEGRATION = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', 'eglfs_kms', 'eglfs_brcm', d)}"
> +
> +do_configure_prepend() {
> +    # Add the appropriate EGLFS_DEVICE_INTEGRATION, depending if using VC4 or USERLAND
> +    echo "EGLFS_DEVICE_INTEGRATION = ${OE_QTBASE_EGLFS_DEVICE_INTEGRATION}" > ${S}/mkspecs/oe-device-extra.pri
> +}
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

Khem, what do you think about this change?

--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640 | t: @agherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

Re: [meta-raspberrypi][PATCH] Add recipe to build qtbase for raspberrypi out of the box.

[Khem Raj]

On Mon, Apr 3, 2017 at 6:45 AM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> On Thu, Jan 19, 2017 at 09:16:05PM +0800, Herve Jourdain wrote:
>> Supports different EGLFS_DEVICE_INTEGRATION for userland or vc4
>>
>> Signed-off-by: Herve Jourdain <herve.jourdain@neuf.fr>
>> ---
>>  recipes-qt/qt5/qtbase_%.bbappend | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>  create mode 100644 recipes-qt/qt5/qtbase_%.bbappend
>>
>> diff --git a/recipes-qt/qt5/qtbase_%.bbappend b/recipes-qt/qt5/qtbase_%.bbappend
>> new file mode 100644
>> index 0000000..aebcaf9
>> --- /dev/null
>> +++ b/recipes-qt/qt5/qtbase_%.bbappend
>> @@ -0,0 +1,10 @@
>> +PACKAGECONFIG_GL_rpi = "gles2 eglfs"
>> +DEPENDS_${PN}_append_rpi = " virtual/egl"
>> +
>> +OE_QTBASE_EGLFS_DEVICE_INTEGRATION = "${@bb.utils.contains('MACHINE_FEATURES', 'vc4graphics', 'eglfs_kms', 'eglfs_brcm', d)}"
>> +
>> +do_configure_prepend() {
>> +    # Add the appropriate EGLFS_DEVICE_INTEGRATION, depending if using VC4 or USERLAND
>> +    echo "EGLFS_DEVICE_INTEGRATION = ${OE_QTBASE_EGLFS_DEVICE_INTEGRATION}" > ${S}/mkspecs/oe-device-extra.pri
>> +}
>> +
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>
> Khem, what do you think about this change?
>

I think the do_configure_append should be rpi specific here. Secondly,
it should check if eglfs is desired backend before triggering this. It
is possible that when we do not use eglfs this is undesired.