From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: Bad page state splats on arm64, v4.11-rc{3,4}
Date: Mon, 3 Apr 2017 16:51:52 +0100 [thread overview]
Message-ID: <20170403155152.GG18905@leverpostej> (raw)
In-Reply-To: <20170403154815.GE25550@e104818-lin.cambridge.arm.com>
On Mon, Apr 03, 2017 at 04:48:15PM +0100, Catalin Marinas wrote:
> On Mon, Apr 03, 2017 at 12:37:51PM +0100, Will Deacon wrote:
> > On Mon, Apr 03, 2017 at 11:56:29AM +0100, Mark Rutland wrote:
> > > On Fri, Mar 31, 2017 at 06:58:45PM +0100, Mark Rutland wrote:
> > > > I'm seeing intermittent bad page state splats on arm64 with 4.11-rc3 and
> > > > v4.11-rc4.
> > > I wasn't able to trigger the issue over the weekend on a kernel with
> > > HUGETLBFS disabled. There are known issues with our handling of
> > > contiguous entries, and this might be an artefact of that.
> >
> > After chatting with Punit, it looks like this might be because the GUP
> > code doesn't handle huge ptes (which we create using the contiguous hint),
> > so follow_page_pte ends up with one of those and goes wrong. In particular,
> > the migration code will certainly do the wrong thing.
> >
> > I'll probably revert the contiguous support (again) if testing indicates
> > that it makes this issue disappear.
>
> It might be worth checking with Punit's patches as well:
>
> https://marc.info/?l=linux-arm-kernel&m=149089199018167&w=2
I'd given those patches a spin prior to testing v4.11-rc4 with HUGETLBFS
disabled.
I saw the issue even with those patches applied.
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
linux-mm@kvack.org, punit.agrawal@arm.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: Bad page state splats on arm64, v4.11-rc{3,4}
Date: Mon, 3 Apr 2017 16:51:52 +0100 [thread overview]
Message-ID: <20170403155152.GG18905@leverpostej> (raw)
In-Reply-To: <20170403154815.GE25550@e104818-lin.cambridge.arm.com>
On Mon, Apr 03, 2017 at 04:48:15PM +0100, Catalin Marinas wrote:
> On Mon, Apr 03, 2017 at 12:37:51PM +0100, Will Deacon wrote:
> > On Mon, Apr 03, 2017 at 11:56:29AM +0100, Mark Rutland wrote:
> > > On Fri, Mar 31, 2017 at 06:58:45PM +0100, Mark Rutland wrote:
> > > > I'm seeing intermittent bad page state splats on arm64 with 4.11-rc3 and
> > > > v4.11-rc4.
> > > I wasn't able to trigger the issue over the weekend on a kernel with
> > > HUGETLBFS disabled. There are known issues with our handling of
> > > contiguous entries, and this might be an artefact of that.
> >
> > After chatting with Punit, it looks like this might be because the GUP
> > code doesn't handle huge ptes (which we create using the contiguous hint),
> > so follow_page_pte ends up with one of those and goes wrong. In particular,
> > the migration code will certainly do the wrong thing.
> >
> > I'll probably revert the contiguous support (again) if testing indicates
> > that it makes this issue disappear.
>
> It might be worth checking with Punit's patches as well:
>
> https://marc.info/?l=linux-arm-kernel&m=149089199018167&w=2
I'd given those patches a spin prior to testing v4.11-rc4 with HUGETLBFS
disabled.
I saw the issue even with those patches applied.
Thanks,
Mark.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
linux-mm@kvack.org, punit.agrawal@arm.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: Bad page state splats on arm64, v4.11-rc{3,4}
Date: Mon, 3 Apr 2017 16:51:52 +0100 [thread overview]
Message-ID: <20170403155152.GG18905@leverpostej> (raw)
In-Reply-To: <20170403154815.GE25550@e104818-lin.cambridge.arm.com>
On Mon, Apr 03, 2017 at 04:48:15PM +0100, Catalin Marinas wrote:
> On Mon, Apr 03, 2017 at 12:37:51PM +0100, Will Deacon wrote:
> > On Mon, Apr 03, 2017 at 11:56:29AM +0100, Mark Rutland wrote:
> > > On Fri, Mar 31, 2017 at 06:58:45PM +0100, Mark Rutland wrote:
> > > > I'm seeing intermittent bad page state splats on arm64 with 4.11-rc3 and
> > > > v4.11-rc4.
> > > I wasn't able to trigger the issue over the weekend on a kernel with
> > > HUGETLBFS disabled. There are known issues with our handling of
> > > contiguous entries, and this might be an artefact of that.
> >
> > After chatting with Punit, it looks like this might be because the GUP
> > code doesn't handle huge ptes (which we create using the contiguous hint),
> > so follow_page_pte ends up with one of those and goes wrong. In particular,
> > the migration code will certainly do the wrong thing.
> >
> > I'll probably revert the contiguous support (again) if testing indicates
> > that it makes this issue disappear.
>
> It might be worth checking with Punit's patches as well:
>
> https://marc.info/?l=linux-arm-kernel&m=149089199018167&w=2
I'd given those patches a spin prior to testing v4.11-rc4 with HUGETLBFS
disabled.
I saw the issue even with those patches applied.
Thanks,
Mark.
next prev parent reply other threads:[~2017-04-03 15:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 17:58 Bad page state splats on arm64, v4.11-rc{3,4} Mark Rutland
2017-03-31 17:58 ` Mark Rutland
2017-03-31 17:58 ` Mark Rutland
2017-04-03 10:56 ` Mark Rutland
2017-04-03 10:56 ` Mark Rutland
2017-04-03 10:56 ` Mark Rutland
2017-04-03 11:37 ` Will Deacon
2017-04-03 11:37 ` Will Deacon
2017-04-03 11:37 ` Will Deacon
2017-04-03 15:48 ` Catalin Marinas
2017-04-03 15:48 ` Catalin Marinas
2017-04-03 15:48 ` Catalin Marinas
2017-04-03 15:51 ` Mark Rutland [this message]
2017-04-03 15:51 ` Mark Rutland
2017-04-03 15:51 ` Mark Rutland
2017-04-03 17:43 ` Mark Rutland
2017-04-03 17:43 ` Mark Rutland
2017-04-03 17:43 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403155152.GG18905@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.