From: Eric Biggers <ebiggers3@gmail.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Eric Biggers <ebiggers@google.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] KEYS: encrypted: avoid encrypting/decrypting stack buffers
Date: Mon, 3 Apr 2017 11:21:57 -0700 [thread overview]
Message-ID: <20170403182157.GC72831@gmail.com> (raw)
In-Reply-To: <1491234942.2928.10.camel@linux.vnet.ibm.com>
On Mon, Apr 03, 2017 at 11:55:42AM -0400, Mimi Zohar wrote:
>
> This patch removes calculating the "padlen". Will this change break
> other use cases?
>
No, the number of bytes being encrypted is still 'encrypted_datalen' which is
passed to skcipher_request_set_crypt(). It's okay if the input scatterlist is
longer than that; only the first 'encrypted_datalen' bytes will be used.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers3@gmail.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: keyrings@vger.kernel.org, David Howells <dhowells@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Eric Biggers <ebiggers@google.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] KEYS: encrypted: avoid encrypting/decrypting stack buffers
Date: Mon, 3 Apr 2017 11:21:57 -0700 [thread overview]
Message-ID: <20170403182157.GC72831@gmail.com> (raw)
In-Reply-To: <1491234942.2928.10.camel@linux.vnet.ibm.com>
On Mon, Apr 03, 2017 at 11:55:42AM -0400, Mimi Zohar wrote:
>
> This patch removes calculating the "padlen". �Will this change break
> other use cases?
>
No, the number of bytes being encrypted is still 'encrypted_datalen' which is
passed to skcipher_request_set_crypt(). It's okay if the input scatterlist is
longer than that; only the first 'encrypted_datalen' bytes will be used.
- Eric
next prev parent reply other threads:[~2017-04-03 18:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 19:17 [PATCH] KEYS: encrypted: avoid encrypting/decrypting stack buffers Eric Biggers
2017-04-02 2:23 ` Mimi Zohar
2017-04-02 3:33 ` Eric Biggers
2017-04-02 3:33 ` Eric Biggers
2017-04-03 15:55 ` Mimi Zohar
2017-04-03 18:21 ` Eric Biggers [this message]
2017-04-03 18:21 ` Eric Biggers
2017-04-03 15:44 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170403182157.GC72831@gmail.com \
--to=ebiggers3@gmail.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=stable@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.