From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] Add support for ThunderX2 pmu events using json files
Date: Tue, 4 Apr 2017 13:29:43 +0100 [thread overview]
Message-ID: <20170404122943.GC8551@leverpostej> (raw)
In-Reply-To: <1491291403-29893-1-git-send-email-ganapatrao.kulkarni@cavium.com>
Hi,
On Tue, Apr 04, 2017 at 01:06:40PM +0530, Ganapatrao Kulkarni wrote:
> Extending json/jevent framework for parsing arm64 event files.
> Adding jevents for ThunderX2 implementation defined PMU events.
Thanks for having a look at this!
While I agree this is the right approach generally, I have a couple of
issues with the implementation, which I have commented upon in
subsequent patches.
Thanks,
Mark.
> Ganapatrao Kulkarni (3):
> perf jevents: Add support to use core pmu name other than cpu
> perf tools arm64: implement function get_cpuid_str
> perf tool, arm64, thunderx2: Add implementation defined events for
> thunderx2
>
> tools/perf/arch/arm64/util/Build | 1 +
> tools/perf/arch/arm64/util/header.c | 51 +++++++++++++++
> tools/perf/pmu-events/arch/arm64/mapfile.csv | 2 +
> .../arm64/thunderx2/implementation-defined.json | 72 ++++++++++++++++++++++
> tools/perf/pmu-events/jevents.c | 15 +++--
> tools/perf/pmu-events/jevents.h | 3 +-
> tools/perf/pmu-events/pmu-events.h | 1 +
> tools/perf/util/pmu.c | 2 +-
> 8 files changed, 140 insertions(+), 7 deletions(-)
> create mode 100644 tools/perf/arch/arm64/util/header.c
> create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv
> create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json
>
> --
> 1.8.1.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com,
catalin.marinas@arm.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, peterz@infradead.org,
mingo@redhat.com, jnair@caviumnetworks.com, gpkulkarni@gmail.com
Subject: Re: [PATCH 0/3] Add support for ThunderX2 pmu events using json files
Date: Tue, 4 Apr 2017 13:29:43 +0100 [thread overview]
Message-ID: <20170404122943.GC8551@leverpostej> (raw)
In-Reply-To: <1491291403-29893-1-git-send-email-ganapatrao.kulkarni@cavium.com>
Hi,
On Tue, Apr 04, 2017 at 01:06:40PM +0530, Ganapatrao Kulkarni wrote:
> Extending json/jevent framework for parsing arm64 event files.
> Adding jevents for ThunderX2 implementation defined PMU events.
Thanks for having a look at this!
While I agree this is the right approach generally, I have a couple of
issues with the implementation, which I have commented upon in
subsequent patches.
Thanks,
Mark.
> Ganapatrao Kulkarni (3):
> perf jevents: Add support to use core pmu name other than cpu
> perf tools arm64: implement function get_cpuid_str
> perf tool, arm64, thunderx2: Add implementation defined events for
> thunderx2
>
> tools/perf/arch/arm64/util/Build | 1 +
> tools/perf/arch/arm64/util/header.c | 51 +++++++++++++++
> tools/perf/pmu-events/arch/arm64/mapfile.csv | 2 +
> .../arm64/thunderx2/implementation-defined.json | 72 ++++++++++++++++++++++
> tools/perf/pmu-events/jevents.c | 15 +++--
> tools/perf/pmu-events/jevents.h | 3 +-
> tools/perf/pmu-events/pmu-events.h | 1 +
> tools/perf/util/pmu.c | 2 +-
> 8 files changed, 140 insertions(+), 7 deletions(-)
> create mode 100644 tools/perf/arch/arm64/util/header.c
> create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv
> create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json
>
> --
> 1.8.1.4
>
next prev parent reply other threads:[~2017-04-04 12:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 7:36 [PATCH 0/3] Add support for ThunderX2 pmu events using json files Ganapatrao Kulkarni
2017-04-04 7:36 ` Ganapatrao Kulkarni
2017-04-04 7:36 ` [PATCH 1/3] perf jevents: Add support to use core pmu name other than cpu Ganapatrao Kulkarni
2017-04-04 7:36 ` Ganapatrao Kulkarni
2017-04-04 7:36 ` [PATCH 2/3] perf tools arm64: implement function get_cpuid_str Ganapatrao Kulkarni
2017-04-04 7:36 ` Ganapatrao Kulkarni
2017-04-04 12:25 ` Mark Rutland
2017-04-04 12:25 ` Mark Rutland
2017-04-05 9:18 ` Ganapatrao Kulkarni
2017-04-05 9:18 ` Ganapatrao Kulkarni
2017-04-04 7:36 ` [PATCH 3/3] perf tool, arm64, thunderx2: Add implementation defined events for ThunderX2 Ganapatrao Kulkarni
2017-04-04 7:36 ` Ganapatrao Kulkarni
2017-04-04 12:28 ` Mark Rutland
2017-04-04 12:28 ` Mark Rutland
2017-04-05 9:12 ` Ganapatrao Kulkarni
2017-04-05 9:12 ` Ganapatrao Kulkarni
2017-04-05 10:05 ` Mark Rutland
2017-04-05 10:05 ` Mark Rutland
2017-04-06 4:20 ` Ganapatrao Kulkarni
2017-04-06 4:20 ` Ganapatrao Kulkarni
2017-04-06 9:55 ` Mark Rutland
2017-04-06 9:55 ` Mark Rutland
2017-04-19 18:07 ` Ganapatrao Kulkarni
2017-04-19 18:07 ` Ganapatrao Kulkarni
2017-04-20 8:53 ` Mark Rutland
2017-04-20 8:53 ` Mark Rutland
2017-04-04 12:29 ` Mark Rutland [this message]
2017-04-04 12:29 ` [PATCH 0/3] Add support for ThunderX2 pmu events using json files Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404122943.GC8551@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.