* [PATCH 1/1] asus-nb-wmi: Add wapf4 quirk for the X302UA @ 2017-04-04 16:35 Santeri Toivonen 2017-04-04 16:52 ` Darren Hart 0 siblings, 1 reply; 4+ messages in thread From: Santeri Toivonen @ 2017-04-04 16:35 UTC (permalink / raw) To: dvhart, Corentin Chary, jprvita, Andy Shevchenko, marcos.souza.org Cc: acpi4asus-user, platform-driver-x86 Asus laptop X302UA starts up with Wi-Fi disabled, without a way to enable it. Set wapf=4 to fix the problem. Signed-off-by: Santeri Toivonen <santeri.toivonen@vatsul.com> --- drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index dea98ffb6f60..1ae58d906536 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers/platform/x86/asus-nb-wmi.c @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] = { }, { .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. X302UA", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"), + }, + .driver_data = &quirk_asus_wapf4, + }, + { + .callback = dmi_matched, .ident = "ASUSTeK COMPUTER INC. X401U", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), -- 2.11.0.windows.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] asus-nb-wmi: Add wapf4 quirk for the X302UA 2017-04-04 16:35 [PATCH 1/1] asus-nb-wmi: Add wapf4 quirk for the X302UA Santeri Toivonen @ 2017-04-04 16:52 ` Darren Hart 2017-04-04 18:09 ` Santeri Toivonen 0 siblings, 1 reply; 4+ messages in thread From: Darren Hart @ 2017-04-04 16:52 UTC (permalink / raw) To: Santeri Toivonen Cc: dvhart, Corentin Chary, jprvita, Andy Shevchenko, marcos.souza.org, acpi4asus-user, platform-driver-x86 On Tue, Apr 04, 2017 at 07:35:00PM +0300, Santeri Toivonen wrote: > Asus laptop X302UA starts up with Wi-Fi disabled, > without a way to enable it. Set wapf=4 to fix the problem. > > Signed-off-by: Santeri Toivonen <santeri.toivonen@vatsul.com> > --- > drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/platform/x86/asus-nb-wmi.c > b/drivers/platform/x86/asus-nb-wmi.c > index dea98ffb6f60..1ae58d906536 100644 > --- a/drivers/platform/x86/asus-nb-wmi.c > +++ b/drivers/platform/x86/asus-nb-wmi.c > @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] = { > }, > { > .callback = dmi_matched, > + .ident = "ASUSTeK COMPUTER INC. X302UA", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > + DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"), > + }, > + .driver_data = &quirk_asus_wapf4, > + }, > + { > + .callback = dmi_matched, > .ident = "ASUSTeK COMPUTER INC. X401U", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), Hi Santeri, How are you preparing your patches? The context lines have an extra leading space and fail to apply with git-am and patch. Git will create properly formatted patches using the "git format-patch" command after you have committed the change to your local repository. Alternatively you can use "diff -Nurp" directly, although that's much more tedious. Documentation/process/submitting-patches.rst has detailed instructions in "1) ``diff -up``". -- Darren Hart VMware Open Source Technology Center ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] asus-nb-wmi: Add wapf4 quirk for the X302UA 2017-04-04 16:52 ` Darren Hart @ 2017-04-04 18:09 ` Santeri Toivonen 2017-04-04 19:24 ` Darren Hart 0 siblings, 1 reply; 4+ messages in thread From: Santeri Toivonen @ 2017-04-04 18:09 UTC (permalink / raw) To: Darren Hart, Santeri Toivonen Cc: dvhart, Corentin Chary, jprvita, Andy Shevchenko, marcos.souza.org, acpi4asus-user, platform-driver-x86 On 4.4.2017 19:52, Darren Hart wrote: > On Tue, Apr 04, 2017 at 07:35:00PM +0300, Santeri Toivonen wrote: >> Asus laptop X302UA starts up with Wi-Fi disabled, >> without a way to enable it. Set wapf=4 to fix the problem. >> >> Signed-off-by: Santeri Toivonen <santeri.toivonen@vatsul.com> >> --- >> drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/drivers/platform/x86/asus-nb-wmi.c >> b/drivers/platform/x86/asus-nb-wmi.c >> index dea98ffb6f60..1ae58d906536 100644 >> --- a/drivers/platform/x86/asus-nb-wmi.c >> +++ b/drivers/platform/x86/asus-nb-wmi.c >> @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] = { >> }, >> { >> .callback = dmi_matched, >> + .ident = "ASUSTeK COMPUTER INC. X302UA", >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), >> + DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"), >> + }, >> + .driver_data = &quirk_asus_wapf4, >> + }, >> + { >> + .callback = dmi_matched, >> .ident = "ASUSTeK COMPUTER INC. X401U", >> .matches = { >> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > > Hi Santeri, > > How are you preparing your patches? The context lines have an extra leading > space and fail to apply with git-am and patch. > > Git will create properly formatted patches using the "git format-patch" command > after you have committed the change to your local repository. Alternatively you can use "diff -Nurp" directly, although that's much more tedious. Documentation/process/submitting-patches.rst has detailed instructions in "1) ``diff -up``". > It seems that some thunderbird default configurations resulted in random spaces at line breaks. I created the patch with git format-patch command and applied it successfully while testing. From: Santeri Toivonen <santeri.toivonen@vatsul.com> Subject: [PATCH] asus-nb-wmi: Add wapf4 quirk for the X302UA Asus laptop X302UA starts up with Wi-Fi disabled, without a way to enable it. Set wapf=4 to fix the problem. Signed-off-by: Santeri Toivonen <santeri.toivonen@vatsul.com> --- drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index 38f905d86f1f..0b0fde21cf5b 100644 --- a/drivers/platform/x86/asus-nb-wmi.c +++ b/drivers/platform/x86/asus-nb-wmi.c @@ -180,6 +180,15 @@ static const struct dmi_system_id asus_quirks[] = { }, { .callback = dmi_matched, + .ident = "ASUSTeK COMPUTER INC. X302UA", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"), + }, + .driver_data = &quirk_asus_wapf4, + }, + { + .callback = dmi_matched, .ident = "ASUSTeK COMPUTER INC. X401U", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), -- 2.11.0.windows.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] asus-nb-wmi: Add wapf4 quirk for the X302UA 2017-04-04 18:09 ` Santeri Toivonen @ 2017-04-04 19:24 ` Darren Hart 0 siblings, 0 replies; 4+ messages in thread From: Darren Hart @ 2017-04-04 19:24 UTC (permalink / raw) To: Santeri Toivonen Cc: dvhart, Corentin Chary, jprvita, Andy Shevchenko, marcos.souza.org, acpi4asus-user, platform-driver-x86 On Tue, Apr 04, 2017 at 09:09:00PM +0300, Santeri Toivonen wrote: > On 4.4.2017 19:52, Darren Hart wrote: > > On Tue, Apr 04, 2017 at 07:35:00PM +0300, Santeri Toivonen wrote: > >> Asus laptop X302UA starts up with Wi-Fi disabled, > >> without a way to enable it. Set wapf=4 to fix the problem. > >> > >> Signed-off-by: Santeri Toivonen <santeri.toivonen@vatsul.com> > >> --- > >> drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/drivers/platform/x86/asus-nb-wmi.c > >> b/drivers/platform/x86/asus-nb-wmi.c > >> index dea98ffb6f60..1ae58d906536 100644 > >> --- a/drivers/platform/x86/asus-nb-wmi.c > >> +++ b/drivers/platform/x86/asus-nb-wmi.c > >> @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] = { > >> }, > >> { > >> .callback = dmi_matched, > >> + .ident = "ASUSTeK COMPUTER INC. X302UA", > >> + .matches = { > >> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > >> + DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"), > >> + }, > >> + .driver_data = &quirk_asus_wapf4, > >> + }, > >> + { > >> + .callback = dmi_matched, > >> .ident = "ASUSTeK COMPUTER INC. X401U", > >> .matches = { > >> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), > > > > Hi Santeri, > > > > How are you preparing your patches? The context lines have an extra > leading > > space and fail to apply with git-am and patch. > > > > Git will create properly formatted patches using the "git > format-patch" command > > after you have committed the change to your local repository. > Alternatively you can use "diff -Nurp" directly, although that's much > more tedious. Documentation/process/submitting-patches.rst has detailed > instructions in "1) ``diff -up``". > > > > It seems that some thunderbird default configurations resulted in random > spaces at line breaks. I created the patch with git format-patch command > and applied it successfully while testing. text=flowed I suspect. I've given up trying to get GUI clients to behave for patch management myself. I have email (pick whatever client you like), and then I have a patch manager (mutt). :-) Thanks for sticking with it, appreciate the effort. > From: Santeri Toivonen <santeri.toivonen@vatsul.com> > Subject: [PATCH] asus-nb-wmi: Add wapf4 quirk for the X302UA > > Asus laptop X302UA starts up with Wi-Fi disabled, > without a way to enable it. Set wapf=4 to fix the problem. > > Signed-off-by: Santeri Toivonen <santeri.toivonen@vatsul.com> Queued to the testing branch, should land in 4.12. -- Darren Hart VMware Open Source Technology Center ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-04 19:24 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-04-04 16:35 [PATCH 1/1] asus-nb-wmi: Add wapf4 quirk for the X302UA Santeri Toivonen 2017-04-04 16:52 ` Darren Hart 2017-04-04 18:09 ` Santeri Toivonen 2017-04-04 19:24 ` Darren Hart
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.