From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>,
Keith Busch <keith.busch@intel.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: ->retries fixups V2
Date: Wed, 5 Apr 2017 20:16:05 +0200 [thread overview]
Message-ID: <20170405181605.GA9702@lst.de> (raw)
In-Reply-To: <20170405180653.GA5548@kernel.dk>
On Wed, Apr 05, 2017 at 12:06:53PM -0600, Jens Axboe wrote:
> On Wed, Apr 05 2017, Christoph Hellwig wrote:
> > This series fixes a few lose bits in terms of how nvme uses ->retries,
> > including fixing it for non-PCIe transports. While at it I noticed that
> > nvme and scsi use the field in entirely different ways, and no other
> > driver uses it at all. So I decided to move it into the nvme_request and
> > scsi_request structures instead.
> >
> > Changes since V1:
> > - better changelog for one patch
> > - move the new retries field to the end of struct nvme_request
>
> Applied for 4.12. If we do the below on my box, we remove the (now) 2
> holes from struct request and shrink it 8 bytes.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: ->retries fixups V2
Date: Wed, 5 Apr 2017 20:16:05 +0200 [thread overview]
Message-ID: <20170405181605.GA9702@lst.de> (raw)
In-Reply-To: <20170405180653.GA5548@kernel.dk>
On Wed, Apr 05, 2017@12:06:53PM -0600, Jens Axboe wrote:
> On Wed, Apr 05 2017, Christoph Hellwig wrote:
> > This series fixes a few lose bits in terms of how nvme uses ->retries,
> > including fixing it for non-PCIe transports. While at it I noticed that
> > nvme and scsi use the field in entirely different ways, and no other
> > driver uses it at all. So I decided to move it into the nvme_request and
> > scsi_request structures instead.
> >
> > Changes since V1:
> > - better changelog for one patch
> > - move the new retries field to the end of struct nvme_request
>
> Applied for 4.12. If we do the below on my box, we remove the (now) 2
> holes from struct request and shrink it 8 bytes.
Looks good:
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2017-04-05 18:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 17:18 ->retries fixups V2 Christoph Hellwig
2017-04-05 17:18 ` Christoph Hellwig
2017-04-05 17:18 ` [PATCH 1/5] nvme: move ->retries setup to nvme_setup_cmd Christoph Hellwig
2017-04-05 17:18 ` Christoph Hellwig
2017-04-05 17:32 ` Sagi Grimberg
2017-04-05 17:32 ` Sagi Grimberg
2017-04-06 8:55 ` Johannes Thumshirn
2017-04-06 8:55 ` Johannes Thumshirn
2017-04-06 8:55 ` Johannes Thumshirn
2017-04-05 17:18 ` [PATCH 2/5] nvme: cleanup nvme_req_needs_retry Christoph Hellwig
2017-04-05 17:18 ` Christoph Hellwig
2017-04-05 17:32 ` Sagi Grimberg
2017-04-05 17:32 ` Sagi Grimberg
2017-04-05 17:18 ` [PATCH 3/5] nvme: mark nvme_max_retries static Christoph Hellwig
2017-04-05 17:18 ` Christoph Hellwig
2017-04-05 17:33 ` Sagi Grimberg
2017-04-05 17:33 ` Sagi Grimberg
2017-04-05 17:18 ` [PATCH 4/5] nvme: move the retries count to struct nvme_request Christoph Hellwig
2017-04-05 17:18 ` Christoph Hellwig
2017-04-05 17:33 ` Sagi Grimberg
2017-04-05 17:33 ` Sagi Grimberg
2017-04-05 17:18 ` [PATCH 5/5] block, scsi: move the retries field to struct scsi_request Christoph Hellwig
2017-04-05 17:18 ` Christoph Hellwig
2017-04-05 17:33 ` Sagi Grimberg
2017-04-05 17:33 ` Sagi Grimberg
2017-04-05 18:06 ` ->retries fixups V2 Jens Axboe
2017-04-05 18:06 ` Jens Axboe
2017-04-05 18:16 ` Christoph Hellwig [this message]
2017-04-05 18:16 ` Christoph Hellwig
2017-04-05 18:18 ` Jens Axboe
2017-04-05 18:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405181605.GA9702@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.