All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	qemu-devel@nongnu.org, izumi.taku@jp.fujitsu.com
Subject: Re: [PATCH v6] vfio error recovery: kernel support
Date: Thu, 6 Apr 2017 00:56:14 +0300	[thread overview]
Message-ID: <20170406005028-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <58E4B0C9.50109@cn.fujitsu.com>

On Wed, Apr 05, 2017 at 04:54:33PM +0800, Cao jin wrote:
> Apparently, I don't have experience to induce non-fatal error, device
> error is more of a chance related with the environment(temperature,
> humidity, etc) as I understand.

I'm not sure how to interpret this statement. I think what Alex is
saying is simply that patches should include some justification. They
make changes but what are they improving?
For example:

	I tested device ABC in conditions DEF. Without a patch VM
	stops. With the patches applied VM recovers and proceeds to
	use the device normally.

is one reasonable justification imho.

-- 
MST

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	qemu-devel@nongnu.org, izumi.taku@jp.fujitsu.com
Subject: Re: [Qemu-devel] [PATCH v6] vfio error recovery: kernel support
Date: Thu, 6 Apr 2017 00:56:14 +0300	[thread overview]
Message-ID: <20170406005028-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <58E4B0C9.50109@cn.fujitsu.com>

On Wed, Apr 05, 2017 at 04:54:33PM +0800, Cao jin wrote:
> Apparently, I don't have experience to induce non-fatal error, device
> error is more of a chance related with the environment(temperature,
> humidity, etc) as I understand.

I'm not sure how to interpret this statement. I think what Alex is
saying is simply that patches should include some justification. They
make changes but what are they improving?
For example:

	I tested device ABC in conditions DEF. Without a patch VM
	stops. With the patches applied VM recovers and proceeds to
	use the device normally.

is one reasonable justification imho.

-- 
MST

  parent reply	other threads:[~2017-04-05 21:56 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23  9:07 [PATCH v6] vfio error recovery: kernel support Cao jin
2017-03-23  9:07 ` [Qemu-devel] " Cao jin
2017-03-24 22:12 ` Alex Williamson
2017-03-24 22:12   ` [Qemu-devel] " Alex Williamson
2017-03-28 13:47   ` Cao jin
2017-03-28 13:47     ` [Qemu-devel] " Cao jin
2017-03-28 16:12     ` Alex Williamson
2017-03-28 16:12       ` [Qemu-devel] " Alex Williamson
2017-03-29  0:01       ` Michael S. Tsirkin
2017-03-29  0:01         ` [Qemu-devel] " Michael S. Tsirkin
2017-03-29  2:55         ` Alex Williamson
2017-03-29  2:55           ` [Qemu-devel] " Alex Williamson
2017-03-30 18:00           ` Michael S. Tsirkin
2017-03-30 18:00             ` [Qemu-devel] " Michael S. Tsirkin
2017-03-30 18:16             ` Alex Williamson
2017-03-30 18:16               ` [Qemu-devel] " Alex Williamson
2017-04-05  8:54               ` Cao jin
2017-04-05  8:54                 ` [Qemu-devel] " Cao jin
2017-04-05 19:38                 ` Alex Williamson
2017-04-05 19:38                   ` [Qemu-devel] " Alex Williamson
2017-04-05 21:50                   ` Michael S. Tsirkin
2017-04-05 21:50                     ` [Qemu-devel] " Michael S. Tsirkin
2017-04-05 22:19                     ` Alex Williamson
2017-04-05 22:19                       ` [Qemu-devel] " Alex Williamson
2017-04-05 22:36                       ` Michael S. Tsirkin
2017-04-05 22:36                         ` [Qemu-devel] " Michael S. Tsirkin
2017-04-05 22:56                         ` Alex Williamson
2017-04-05 22:56                           ` [Qemu-devel] " Alex Williamson
2017-04-06  8:53                         ` Cao jin
2017-04-06  8:53                           ` [Qemu-devel] " Cao jin
2017-04-06 15:35                           ` Alex Williamson
2017-04-06 15:35                             ` [Qemu-devel] " Alex Williamson
2017-04-06  8:49                   ` Cao jin
2017-04-06  8:49                     ` [Qemu-devel] " Cao jin
2017-04-05 21:56                 ` Michael S. Tsirkin [this message]
2017-04-05 21:56                   ` Michael S. Tsirkin
2017-04-06  8:49                   ` Cao jin
2017-04-06  8:49                     ` [Qemu-devel] " Cao jin
2017-04-06 15:31                     ` Alex Williamson
2017-04-06 15:31                       ` [Qemu-devel] " Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406005028-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.