All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: David Wu <david.wu@rock-chips.com>
Cc: boris.brezillon@free-electrons.com, briannorris@chromium.org,
	heiko@sntech.de, dianders@chromium.org, b.galvani@gmail.com,
	caesar.wang@rock-chips.com, huangtao@rock-chips.com,
	linux-rockchip@lists.infradead.org, linux-pwm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] pwm: rockchip: State of pwm clock should synchronize with pwm enabled state
Date: Thu, 6 Apr 2017 15:10:47 +0200	[thread overview]
Message-ID: <20170406131047.GA8438@ulmo.ba.sec> (raw)
In-Reply-To: <1488366655-31387-1-git-send-email-david.wu@rock-chips.com>

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

On Wed, Mar 01, 2017 at 07:10:55PM +0800, David Wu wrote:
> From: "david.wu" <david.wu@rock-chips.com>

You might want to set up git to use the correct author.

> If the pwm was not enabled at uboot loader, pwm could not work for clock
> always disabled at pwm driver. The pwm clock is enabled at beginning of
> pwm_apply(), but disabled at end of pwm_apply().
> 
> If the pwm was enabled at uboot loader, pwm clock is always enabled unless
> closed by ATF. The pwm-backlight might turn off the power at early suspend,
> should disable pwm clock for saving power consume.
> 
> It is important to provide opportunity to enable/disable clock at pwm driver,
> the pwm consumer should ensure correct order to call pwm enable/disable, and
> pwm driver ensure state of pwm clock synchronized with pwm enabled state.

Please always use all-caps for abbreviations suchs as "PWM". I've fixed
up the commit message and applied this to for-4.11/fixes.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] pwm: rockchip: State of pwm clock should synchronize with pwm enabled state
Date: Thu, 6 Apr 2017 15:10:47 +0200	[thread overview]
Message-ID: <20170406131047.GA8438@ulmo.ba.sec> (raw)
In-Reply-To: <1488366655-31387-1-git-send-email-david.wu@rock-chips.com>

On Wed, Mar 01, 2017 at 07:10:55PM +0800, David Wu wrote:
> From: "david.wu" <david.wu@rock-chips.com>

You might want to set up git to use the correct author.

> If the pwm was not enabled at uboot loader, pwm could not work for clock
> always disabled at pwm driver. The pwm clock is enabled at beginning of
> pwm_apply(), but disabled at end of pwm_apply().
> 
> If the pwm was enabled at uboot loader, pwm clock is always enabled unless
> closed by ATF. The pwm-backlight might turn off the power at early suspend,
> should disable pwm clock for saving power consume.
> 
> It is important to provide opportunity to enable/disable clock at pwm driver,
> the pwm consumer should ensure correct order to call pwm enable/disable, and
> pwm driver ensure state of pwm clock synchronized with pwm enabled state.

Please always use all-caps for abbreviations suchs as "PWM". I've fixed
up the commit message and applied this to for-4.11/fixes.

Thanks,
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170406/7673ddd4/attachment.sig>

  reply	other threads:[~2017-04-06 13:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01 11:10 [PATCH v3] pwm: rockchip: State of pwm clock should synchronize with pwm enabled state David Wu
2017-03-01 11:10 ` David Wu
2017-03-01 11:10 ` David Wu
2017-04-06 13:10 ` Thierry Reding [this message]
2017-04-06 13:10   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406131047.GA8438@ulmo.ba.sec \
    --to=thierry.reding@gmail.com \
    --cc=b.galvani@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=briannorris@chromium.org \
    --cc=caesar.wang@rock-chips.com \
    --cc=david.wu@rock-chips.com \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.