All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leonro@mellanox.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@kernel.dk>, <linux-nvme@lists.infradead.org>,
	<linux-block@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 2/6] mlx5: move affinity hints assignments to generic code
Date: Thu, 6 Apr 2017 17:27:01 +0300	[thread overview]
Message-ID: <20170406142701.GL2269@mtr-leonro.local> (raw)
In-Reply-To: <1491474998-16423-3-git-send-email-sagi@grimberg.me>

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

On Thu, Apr 06, 2017 at 01:36:34PM +0300, Sagi Grimberg wrote:
> generic api takes care of spreading affinity similar to
> what mlx5 open coded (and even handles better asymmetric
> configurations). Ask the generic API to spread affinity
> for us, and feed him pre_vectors that do not participate
> in affinity settings (which is an improvement to what we
> had before).
>
> The affinity assignments should match what mlx5 tried to
> do earlier but now we do not set affinity to async, cmd
> and pages dedicated vectors.
>
> Also, remove mlx5e_get_cpu routine as we have generic helpers
> to get cpumask and node given a irq vector, so use them
> directly.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---

Thanks,
Acked-by: Leon Romanovsky <leonro@mellanox.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: leonro@mellanox.com (Leon Romanovsky)
Subject: [PATCH v2 2/6] mlx5: move affinity hints assignments to generic code
Date: Thu, 6 Apr 2017 17:27:01 +0300	[thread overview]
Message-ID: <20170406142701.GL2269@mtr-leonro.local> (raw)
In-Reply-To: <1491474998-16423-3-git-send-email-sagi@grimberg.me>

On Thu, Apr 06, 2017@01:36:34PM +0300, Sagi Grimberg wrote:
> generic api takes care of spreading affinity similar to
> what mlx5 open coded (and even handles better asymmetric
> configurations). Ask the generic API to spread affinity
> for us, and feed him pre_vectors that do not participate
> in affinity settings (which is an improvement to what we
> had before).
>
> The affinity assignments should match what mlx5 tried to
> do earlier but now we do not set affinity to async, cmd
> and pages dedicated vectors.
>
> Also, remove mlx5e_get_cpu routine as we have generic helpers
> to get cpumask and node given a irq vector, so use them
> directly.
>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> Signed-off-by: Sagi Grimberg <sagi at grimberg.me>
> ---

Thanks,
Acked-by: Leon Romanovsky <leonro at mellanox.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20170406/08eac1b4/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Saeed Mahameed <saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH v2 2/6] mlx5: move affinity hints assignments to generic code
Date: Thu, 6 Apr 2017 17:27:01 +0300	[thread overview]
Message-ID: <20170406142701.GL2269@mtr-leonro.local> (raw)
In-Reply-To: <1491474998-16423-3-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

On Thu, Apr 06, 2017 at 01:36:34PM +0300, Sagi Grimberg wrote:
> generic api takes care of spreading affinity similar to
> what mlx5 open coded (and even handles better asymmetric
> configurations). Ask the generic API to spread affinity
> for us, and feed him pre_vectors that do not participate
> in affinity settings (which is an improvement to what we
> had before).
>
> The affinity assignments should match what mlx5 tried to
> do earlier but now we do not set affinity to async, cmd
> and pages dedicated vectors.
>
> Also, remove mlx5e_get_cpu routine as we have generic helpers
> to get cpumask and node given a irq vector, so use them
> directly.
>
> Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
> ---

Thanks,
Acked-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-04-06 14:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-06 10:36 [PATCH v2 0/6] Automatic affinity settings for nvme over rdma Sagi Grimberg
2017-04-06 10:36 ` Sagi Grimberg
2017-04-06 10:36 ` [PATCH v2 1/6] mlx5: convert to generic pci_alloc_irq_vectors Sagi Grimberg
2017-04-06 10:36   ` Sagi Grimberg
2017-04-06 14:24   ` Leon Romanovsky
2017-04-06 14:24     ` Leon Romanovsky
2017-04-06 14:24     ` Leon Romanovsky
2017-04-06 10:36 ` [PATCH v2 2/6] mlx5: move affinity hints assignments to generic code Sagi Grimberg
2017-04-06 10:36   ` Sagi Grimberg
2017-04-06 10:36   ` Sagi Grimberg
2017-04-06 14:27   ` Leon Romanovsky [this message]
2017-04-06 14:27     ` Leon Romanovsky
2017-04-06 14:27     ` Leon Romanovsky
2017-04-06 10:36 ` [PATCH v2 3/6] RDMA/core: expose affinity mappings per completion vector Sagi Grimberg
2017-04-06 10:36   ` Sagi Grimberg
2017-04-28 22:48   ` Doug Ledford
2017-04-28 22:48     ` Doug Ledford
2017-05-03  8:02     ` Sagi Grimberg
2017-05-03  8:02       ` Sagi Grimberg
2017-05-03 10:34   ` Håkon Bugge
2017-05-03 10:34     ` Håkon Bugge
2017-05-03 10:34     ` Håkon Bugge
2017-04-06 10:36 ` [PATCH v2 4/6] mlx5: support ->get_vector_affinity Sagi Grimberg
2017-04-06 10:36   ` Sagi Grimberg
2017-04-06 14:30   ` Leon Romanovsky
2017-04-06 14:30     ` Leon Romanovsky
2017-04-06 14:30     ` Leon Romanovsky
2017-04-06 10:36 ` [PATCH v2 5/6] block: Add rdma affinity based queue mapping helper Sagi Grimberg
2017-04-06 10:36   ` Sagi Grimberg
2017-04-06 10:36 ` [PATCH v2 6/6] nvme-rdma: use intelligent affinity based queue mappings Sagi Grimberg
2017-04-06 10:36   ` Sagi Grimberg
2017-04-23 12:01 ` [PATCH v2 0/6] Automatic affinity settings for nvme over rdma Sagi Grimberg
2017-04-23 12:01   ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406142701.GL2269@mtr-leonro.local \
    --to=leonro@mellanox.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=saeedm@mellanox.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.