From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx: ventana: fix DTC warnings
Date: Fri, 7 Apr 2017 20:33:13 +0800 [thread overview]
Message-ID: <20170407123312.GE16503@dragon> (raw)
In-Reply-To: <1491252168-7934-1-git-send-email-tharvey@gateworks.com>
On Mon, Apr 03, 2017 at 01:42:48PM -0700, Tim Harvey wrote:
> Remove the sky2 ethernet device node from the pcie controller which was
> invalid to begin with.
>
> The original intent was to allow the bootloader to populate the MAC via
> dt but this requires the PCI bus topology to be complete in dt as well
> and as these boards have an expansion connector that topology is dynamic
> and can't be represented here.
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> arch/arm/boot/dts/imx6q-gw5400-a.dts | 4 ----
> arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 4 ----
> arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 4 ----
> 3 files changed, 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6q-gw5400-a.dts b/arch/arm/boot/dts/imx6q-gw5400-a.dts
> index 8e84713..5b066c0 100644
> --- a/arch/arm/boot/dts/imx6q-gw5400-a.dts
> +++ b/arch/arm/boot/dts/imx6q-gw5400-a.dts
> @@ -347,10 +347,6 @@
> &pcie {
> reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
> status = "okay";
> -
> - eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
> - compatible = "marvell,sky2";
> - };
The label 'eth1' is referenced by aliases, and so DTC complains as
below.
ERROR (path_references): Reference to non-existent node or label "eth1".
Please test before submitting.
Shawn
> };
>
> &ssi1 {
> diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
> index a208e7e..420a2f6 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
> @@ -342,10 +342,6 @@
> pinctrl-0 = <&pinctrl_pcie>;
> reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
> status = "okay";
> -
> - eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
> - compatible = "marvell,sky2";
> - };
> };
>
> &pwm2 {
> diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> index 968fda9..e742153 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> @@ -379,10 +379,6 @@
> pinctrl-0 = <&pinctrl_pcie>;
> reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
> status = "okay";
> -
> - eth1: sky2 at 8 { /* MAC/PHY on bus 8 */
> - compatible = "marvell,sky2";
> - };
> };
>
> &pwm1 {
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
Cc: "devicetree @ vger . kernel . org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: imx: ventana: fix DTC warnings
Date: Fri, 7 Apr 2017 20:33:13 +0800 [thread overview]
Message-ID: <20170407123312.GE16503@dragon> (raw)
In-Reply-To: <1491252168-7934-1-git-send-email-tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
On Mon, Apr 03, 2017 at 01:42:48PM -0700, Tim Harvey wrote:
> Remove the sky2 ethernet device node from the pcie controller which was
> invalid to begin with.
>
> The original intent was to allow the bootloader to populate the MAC via
> dt but this requires the PCI bus topology to be complete in dt as well
> and as these boards have an expansion connector that topology is dynamic
> and can't be represented here.
>
> Signed-off-by: Tim Harvey <tharvey-UMMOYl/HMS+akBO8gow8eQ@public.gmane.org>
> ---
> arch/arm/boot/dts/imx6q-gw5400-a.dts | 4 ----
> arch/arm/boot/dts/imx6qdl-gw53xx.dtsi | 4 ----
> arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 4 ----
> 3 files changed, 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6q-gw5400-a.dts b/arch/arm/boot/dts/imx6q-gw5400-a.dts
> index 8e84713..5b066c0 100644
> --- a/arch/arm/boot/dts/imx6q-gw5400-a.dts
> +++ b/arch/arm/boot/dts/imx6q-gw5400-a.dts
> @@ -347,10 +347,6 @@
> &pcie {
> reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
> status = "okay";
> -
> - eth1: sky2@8 { /* MAC/PHY on bus 8 */
> - compatible = "marvell,sky2";
> - };
The label 'eth1' is referenced by aliases, and so DTC complains as
below.
ERROR (path_references): Reference to non-existent node or label "eth1".
Please test before submitting.
Shawn
> };
>
> &ssi1 {
> diff --git a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
> index a208e7e..420a2f6 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw53xx.dtsi
> @@ -342,10 +342,6 @@
> pinctrl-0 = <&pinctrl_pcie>;
> reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
> status = "okay";
> -
> - eth1: sky2@8 { /* MAC/PHY on bus 8 */
> - compatible = "marvell,sky2";
> - };
> };
>
> &pwm2 {
> diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> index 968fda9..e742153 100644
> --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi
> @@ -379,10 +379,6 @@
> pinctrl-0 = <&pinctrl_pcie>;
> reset-gpio = <&gpio1 29 GPIO_ACTIVE_LOW>;
> status = "okay";
> -
> - eth1: sky2@8 { /* MAC/PHY on bus 8 */
> - compatible = "marvell,sky2";
> - };
> };
>
> &pwm1 {
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-07 12:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 20:42 [PATCH] ARM: dts: imx: ventana: fix DTC warnings Tim Harvey
2017-04-03 20:42 ` Tim Harvey
2017-04-07 12:33 ` Shawn Guo [this message]
2017-04-07 12:33 ` Shawn Guo
2017-04-10 20:58 ` [PATCH v2] " Tim Harvey
2017-04-10 20:58 ` Tim Harvey
2017-04-14 2:42 ` Shawn Guo
2017-04-14 2:42 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170407123312.GE16503@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.