[PATCH] net: ipv6: netfilter: Format block comments.

[PATCH] net: ipv6: netfilter: Format block comments.

[Arushi Singhal]

Fix checkpatch warnings:
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 net/ipv6/netfilter/ip6_tables.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
index b8cb61c27aa1..ac69ce3bfa1e 100644
--- a/net/ipv6/netfilter/ip6_tables.c
+++ b/net/ipv6/netfilter/ip6_tables.c
@@ -51,14 +51,14 @@ void *ip6t_alloc_initial_table(const struct xt_table *info)
 }
 EXPORT_SYMBOL_GPL(ip6t_alloc_initial_table);
 
-/*
-   We keep a set of rules for each CPU, so we can avoid write-locking
-   them in the softirq when updating the counters and therefore
-   only need to read-lock in the softirq; doing a write_lock_bh() in user
-   context stops packets coming through and allows user context to read
-   the counters or update the rules.
-
-   Hence the start of any table is given by get_table() below.  */
+/* We keep a set of rules for each CPU, so we can avoid write-locking
+ * them in the softirq when updating the counters and therefore
+ * only need to read-lock in the softirq; doing a write_lock_bh() in user
+ * context stops packets coming through and allows user context to read
+ * the counters or update the rules.
+ *
+ * Hence the start of any table is given by get_table() below.
+ */
 
 /* Returns whether matches rule or not. */
 /* Performance critical - called for every packet */
-- 
2.11.0

Re: [Outreachy kernel] [PATCH] net: ipv6: netfilter: Format block comments.

[Pablo Neira Ayuso]

On Wed, Mar 29, 2017 at 02:09:43PM +0530, Arushi Singhal wrote:
> Fix checkpatch warnings:
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: Block comments use * on subsequent lines
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  net/ipv6/netfilter/ip6_tables.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
> index b8cb61c27aa1..ac69ce3bfa1e 100644
> --- a/net/ipv6/netfilter/ip6_tables.c
> +++ b/net/ipv6/netfilter/ip6_tables.c
> @@ -51,14 +51,14 @@ void *ip6t_alloc_initial_table(const struct xt_table *info)
>  }
>  EXPORT_SYMBOL_GPL(ip6t_alloc_initial_table);
>  
> -/*
> -   We keep a set of rules for each CPU, so we can avoid write-locking
> -   them in the softirq when updating the counters and therefore
> -   only need to read-lock in the softirq; doing a write_lock_bh() in user
> -   context stops packets coming through and allows user context to read
> -   the counters or update the rules.
> -
> -   Hence the start of any table is given by get_table() below.  */
> +/* We keep a set of rules for each CPU, so we can avoid write-locking
> + * them in the softirq when updating the counters and therefore
> + * only need to read-lock in the softirq; doing a write_lock_bh() in user
> + * context stops packets coming through and allows user context to read
> + * the counters or update the rules.
> + *
> + * Hence the start of any table is given by get_table() below.
> + */

This comment is obsolete and should go.

We have no set of rules per CPU anymore.

Re: [Outreachy kernel] [PATCH] net: ipv6: netfilter: Format block comments.

[Arushi Singhal]

[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]

On Fri, Apr 7, 2017 at 9:45 PM, Pablo Neira Ayuso <pablo@netfilter.org>
wrote:

> On Wed, Mar 29, 2017 at 02:09:43PM +0530, Arushi Singhal wrote:
> > Fix checkpatch warnings:
> > WARNING: Block comments use a trailing */ on a separate line
> > WARNING: Block comments use * on subsequent lines
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> > ---
> >  net/ipv6/netfilter/ip6_tables.c | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_
> tables.c
> > index b8cb61c27aa1..ac69ce3bfa1e 100644
> > --- a/net/ipv6/netfilter/ip6_tables.c
> > +++ b/net/ipv6/netfilter/ip6_tables.c
> > @@ -51,14 +51,14 @@ void *ip6t_alloc_initial_table(const struct
> xt_table *info)
> >  }
> >  EXPORT_SYMBOL_GPL(ip6t_alloc_initial_table);
> >
> > -/*
> > -   We keep a set of rules for each CPU, so we can avoid write-locking
> > -   them in the softirq when updating the counters and therefore
> > -   only need to read-lock in the softirq; doing a write_lock_bh() in
> user
> > -   context stops packets coming through and allows user context to read
> > -   the counters or update the rules.
> > -
> > -   Hence the start of any table is given by get_table() below.  */
> > +/* We keep a set of rules for each CPU, so we can avoid write-locking
> > + * them in the softirq when updating the counters and therefore
> > + * only need to read-lock in the softirq; doing a write_lock_bh() in
> user
> > + * context stops packets coming through and allows user context to read
> > + * the counters or update the rules.
> > + *
> > + * Hence the start of any table is given by get_table() below.
> > + */
>
> This comment is obsolete and should go.
>
> We have no set of rules per CPU anymore.
>
Hi Pablo
So should I fix this by removing these comments.

Thanks
Arushi

[-- Attachment #2: Type: text/html, Size: 2600 bytes --]