From: Mark Rutland <mark.rutland@arm.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Daniel Micay <danielmicay@gmail.com>,
Mathias Krause <minipli@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kees Cook <keescook@chromium.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Hoeun Ryu <hoeun.ryu@gmail.com>, PaX Team <pageexec@freemail.hu>,
Emese Revfy <re.emese@gmail.com>,
Russell King <linux@armlinux.org.uk>, X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [kernel-hardening] Re: [RFC v2][PATCH 04/11] x86: Implement __arch_rare_write_begin/unmap()
Date: Mon, 10 Apr 2017 11:22:59 +0100 [thread overview]
Message-ID: <20170410102244.GA13899@leverpostej> (raw)
In-Reply-To: <CALCETrXQaRcNz7EQW9DHF-LMr5SkooLq=1HKsdOfXH-kY4fcBw@mail.gmail.com>
On Sat, Apr 08, 2017 at 08:20:03AM -0700, Andy Lutomirski wrote:
> On Sat, Apr 8, 2017 at 12:33 AM, Daniel Micay <danielmicay@gmail.com> wrote:
> > The
> > submitted code is aimed at rare writes to globals, but this feature is
> > more than that and design decisions shouldn't be based on just the
> > short term.
>
> Then, if you disagree with a proposed design, *explain why* in a
> standalone manner. Say what future uses a different design would
> have.
>
> > I actually care a lot more about 64-bit ARM support than I do x86, but
> > using a portable API for pax_open_kernel (for the simple uses at
> > least) is separate from choosing the underlying implementation. There
> > might not be a great way to do it on the architectures I care about
> > but that doesn't need to hinder x86. It's really not that much code...
> > A weaker/slower implementation for x86 also encourages the same
> > elsewhere.
>
> No one has explained how CR0.WP is weaker or slower than my proposal.
> Here's what I'm proposing:
>
> At boot, choose a random address A. Create an mm_struct that has a
> single VMA starting at A that represents the kernel's rarely-written
> section. Compute O = (A - VA of rarely-written section). To do a
> rare write, use_mm() the mm, write to (VA + O), then unuse_mm().
>
> This should work on any arch that has an MMU that allows this type of
> aliasing and that doesn't have PA-based protections on the
> rarely-written section.
Modulo randomization, that sounds exactly like what I had envisaged [1],
so that makes sense to me.
Thanks,
Mark.
[1] http://www.openwall.com/lists/kernel-hardening/2016/11/18/3
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [kernel-hardening] Re: [RFC v2][PATCH 04/11] x86: Implement __arch_rare_write_begin/unmap()
Date: Mon, 10 Apr 2017 11:22:59 +0100 [thread overview]
Message-ID: <20170410102244.GA13899@leverpostej> (raw)
In-Reply-To: <CALCETrXQaRcNz7EQW9DHF-LMr5SkooLq=1HKsdOfXH-kY4fcBw@mail.gmail.com>
On Sat, Apr 08, 2017 at 08:20:03AM -0700, Andy Lutomirski wrote:
> On Sat, Apr 8, 2017 at 12:33 AM, Daniel Micay <danielmicay@gmail.com> wrote:
> > The
> > submitted code is aimed at rare writes to globals, but this feature is
> > more than that and design decisions shouldn't be based on just the
> > short term.
>
> Then, if you disagree with a proposed design, *explain why* in a
> standalone manner. Say what future uses a different design would
> have.
>
> > I actually care a lot more about 64-bit ARM support than I do x86, but
> > using a portable API for pax_open_kernel (for the simple uses at
> > least) is separate from choosing the underlying implementation. There
> > might not be a great way to do it on the architectures I care about
> > but that doesn't need to hinder x86. It's really not that much code...
> > A weaker/slower implementation for x86 also encourages the same
> > elsewhere.
>
> No one has explained how CR0.WP is weaker or slower than my proposal.
> Here's what I'm proposing:
>
> At boot, choose a random address A. Create an mm_struct that has a
> single VMA starting at A that represents the kernel's rarely-written
> section. Compute O = (A - VA of rarely-written section). To do a
> rare write, use_mm() the mm, write to (VA + O), then unuse_mm().
>
> This should work on any arch that has an MMU that allows this type of
> aliasing and that doesn't have PA-based protections on the
> rarely-written section.
Modulo randomization, that sounds exactly like what I had envisaged [1],
so that makes sense to me.
Thanks,
Mark.
[1] http://www.openwall.com/lists/kernel-hardening/2016/11/18/3
next prev parent reply other threads:[~2017-04-10 10:22 UTC|newest]
Thread overview: 157+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 18:15 [kernel-hardening] [RFC v2] Introduce rare_write() infrastructure Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` [kernel-hardening] [RFC v2][PATCH 01/11] " Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:23 ` [kernel-hardening] " Kees Cook
2017-03-29 18:23 ` Kees Cook
2017-03-29 18:23 ` Kees Cook
2017-03-30 7:44 ` [kernel-hardening] " Ho-Eun Ryu
2017-03-30 7:44 ` Ho-Eun Ryu
2017-03-30 7:44 ` Ho-Eun Ryu
2017-03-30 17:02 ` [kernel-hardening] " Kees Cook
2017-03-30 17:02 ` Kees Cook
2017-03-30 17:02 ` Kees Cook
2017-04-07 8:09 ` [kernel-hardening] " Ho-Eun Ryu
2017-04-07 8:09 ` Ho-Eun Ryu
2017-04-07 8:09 ` Ho-Eun Ryu
2017-04-07 20:38 ` [kernel-hardening] " Kees Cook
2017-04-07 20:38 ` Kees Cook
2017-04-07 20:38 ` Kees Cook
2017-03-29 18:15 ` [kernel-hardening] [RFC v2][PATCH 02/11] lkdtm: add test for " Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-30 9:34 ` [kernel-hardening] " Ian Campbell
2017-03-30 9:34 ` Ian Campbell
2017-03-30 16:16 ` Kees Cook
2017-03-30 16:16 ` Kees Cook
2017-03-29 18:15 ` [kernel-hardening] [RFC v2][PATCH 03/11] net: switch sock_diag handlers to rare_write() Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` [kernel-hardening] [RFC v2][PATCH 04/11] x86: Implement __arch_rare_write_begin/unmap() Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 22:38 ` [kernel-hardening] " Andy Lutomirski
2017-03-29 22:38 ` Andy Lutomirski
2017-03-29 22:38 ` Andy Lutomirski
2017-03-30 1:41 ` [kernel-hardening] " Kees Cook
2017-03-30 1:41 ` Kees Cook
2017-03-30 1:41 ` Kees Cook
2017-04-05 23:57 ` [kernel-hardening] " Andy Lutomirski
2017-04-05 23:57 ` Andy Lutomirski
2017-04-05 23:57 ` Andy Lutomirski
2017-04-06 0:14 ` [kernel-hardening] " Kees Cook
2017-04-06 0:14 ` Kees Cook
2017-04-06 0:14 ` Kees Cook
2017-04-06 15:59 ` [kernel-hardening] " Andy Lutomirski
2017-04-06 15:59 ` Andy Lutomirski
2017-04-06 15:59 ` Andy Lutomirski
2017-04-07 8:34 ` [kernel-hardening] " Mathias Krause
2017-04-07 8:34 ` Mathias Krause
2017-04-07 9:46 ` Thomas Gleixner
2017-04-07 9:46 ` Thomas Gleixner
2017-04-07 10:51 ` Mathias Krause
2017-04-07 10:51 ` Mathias Krause
2017-04-07 13:14 ` Thomas Gleixner
2017-04-07 13:14 ` Thomas Gleixner
2017-04-07 13:30 ` Mathias Krause
2017-04-07 13:30 ` Mathias Krause
2017-04-07 16:14 ` Andy Lutomirski
2017-04-07 16:14 ` Andy Lutomirski
2017-04-07 16:22 ` Mark Rutland
2017-04-07 16:22 ` Mark Rutland
2017-04-07 19:58 ` PaX Team
2017-04-07 19:58 ` PaX Team
2017-04-07 19:58 ` PaX Team
2017-04-08 4:58 ` Andy Lutomirski
2017-04-08 4:58 ` Andy Lutomirski
2017-04-09 12:47 ` PaX Team
2017-04-09 12:47 ` PaX Team
2017-04-09 12:47 ` PaX Team
2017-04-10 0:10 ` Andy Lutomirski
2017-04-10 0:10 ` Andy Lutomirski
2017-04-10 10:42 ` PaX Team
2017-04-10 10:42 ` PaX Team
2017-04-10 10:42 ` PaX Team
2017-04-10 16:01 ` Andy Lutomirski
2017-04-10 16:01 ` Andy Lutomirski
2017-04-07 20:44 ` Thomas Gleixner
2017-04-07 20:44 ` Thomas Gleixner
2017-04-07 21:20 ` Kees Cook
2017-04-07 21:20 ` Kees Cook
2017-04-08 4:12 ` Daniel Micay
2017-04-08 4:12 ` Daniel Micay
2017-04-08 4:13 ` Daniel Micay
2017-04-08 4:13 ` Daniel Micay
2017-04-08 4:21 ` Daniel Micay
2017-04-08 4:21 ` Daniel Micay
2017-04-08 5:07 ` Andy Lutomirski
2017-04-08 5:07 ` Andy Lutomirski
2017-04-08 7:33 ` Daniel Micay
2017-04-08 7:33 ` Daniel Micay
2017-04-08 15:20 ` Andy Lutomirski
2017-04-08 15:20 ` Andy Lutomirski
2017-04-09 10:53 ` Ingo Molnar
2017-04-09 10:53 ` Ingo Molnar
2017-04-10 10:22 ` Mark Rutland [this message]
2017-04-10 10:22 ` Mark Rutland
2017-04-09 20:24 ` PaX Team
2017-04-09 20:24 ` PaX Team
2017-04-09 20:24 ` PaX Team
2017-04-10 0:31 ` Andy Lutomirski
2017-04-10 0:31 ` Andy Lutomirski
2017-04-10 19:47 ` PaX Team
2017-04-10 19:47 ` PaX Team
2017-04-10 19:47 ` PaX Team
2017-04-10 20:27 ` Andy Lutomirski
2017-04-10 20:27 ` Andy Lutomirski
2017-04-10 20:13 ` Kees Cook
2017-04-10 20:13 ` Kees Cook
2017-04-10 20:17 ` Andy Lutomirski
2017-04-10 20:17 ` Andy Lutomirski
2017-04-07 19:25 ` Thomas Gleixner
2017-04-07 19:25 ` Thomas Gleixner
2017-04-07 14:45 ` Peter Zijlstra
2017-04-07 14:45 ` Peter Zijlstra
2017-04-10 10:29 ` Mark Rutland
2017-04-10 10:29 ` Mark Rutland
2017-04-07 19:52 ` PaX Team
2017-04-07 19:52 ` PaX Team
2017-04-10 8:26 ` Thomas Gleixner
2017-04-10 8:26 ` Thomas Gleixner
2017-04-10 19:55 ` PaX Team
2017-04-10 19:55 ` PaX Team
2017-04-07 9:37 ` Peter Zijlstra
2017-04-07 9:37 ` Peter Zijlstra
2017-04-07 9:37 ` Peter Zijlstra
2017-03-29 18:15 ` [kernel-hardening] [RFC v2][PATCH 05/11] ARM: mm: dump: Add domain to output Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` [kernel-hardening] [RFC v2][PATCH 06/11] ARM: domains: Extract common USER domain init Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` [kernel-hardening] [RFC v2][PATCH 07/11] ARM: mm: set DOMAIN_WR_RARE for rodata Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:15 ` Kees Cook
2017-03-29 18:16 ` [kernel-hardening] [RFC v2][PATCH 08/11] ARM: Implement __arch_rare_write_begin/end() Kees Cook
2017-03-29 18:16 ` Kees Cook
2017-03-29 18:16 ` Kees Cook
2017-04-07 9:36 ` [kernel-hardening] " Peter Zijlstra
2017-04-07 9:36 ` Peter Zijlstra
2017-04-07 9:36 ` Peter Zijlstra
2017-03-29 18:16 ` [kernel-hardening] [RFC v2][PATCH 09/11] list: add rare_write() list helpers Kees Cook
2017-03-29 18:16 ` Kees Cook
2017-03-29 18:16 ` Kees Cook
2017-03-29 18:16 ` [kernel-hardening] [RFC v2][PATCH 10/11] gcc-plugins: Add constify plugin Kees Cook
2017-03-29 18:16 ` Kees Cook
2017-03-29 18:16 ` Kees Cook
2017-03-29 18:16 ` [kernel-hardening] [RFC v2][PATCH 11/11] cgroups: force all struct cftype const Kees Cook
2017-03-29 18:16 ` Kees Cook
2017-03-29 18:16 ` Kees Cook
2017-03-29 19:00 ` [kernel-hardening] Re: [RFC v2] Introduce rare_write() infrastructure Russell King - ARM Linux
2017-03-29 19:00 ` Russell King - ARM Linux
2017-03-29 19:00 ` Russell King - ARM Linux
2017-03-29 19:14 ` [kernel-hardening] " Kees Cook
2017-03-29 19:14 ` Kees Cook
2017-03-29 19:14 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170410102244.GA13899@leverpostej \
--to=mark.rutland@arm.com \
--cc=danielmicay@gmail.com \
--cc=hoeun.ryu@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=minipli@googlemail.com \
--cc=pageexec@freemail.hu \
--cc=peterz@infradead.org \
--cc=re.emese@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.