From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] staging: vc04_services: bcm2835-audio: bcm2835-pcm.c Fixed checkpatch warning about unaligned function params
Date: Tue, 11 Apr 2017 16:15:23 +0200 [thread overview]
Message-ID: <20170411141523.GA15891@kroah.com> (raw)
In-Reply-To: <2b55563dd9824e6f9d45b174f1eccd301fccc2d5.1491693395.git.sfaragnaus@gmail.com>
On Sun, Apr 09, 2017 at 12:25:25AM +0100, Andrea della Porta wrote:
> Fixed unaligned function parameters issues, as per checkpatch warning
>
> Signed-off-by: Andrea della Porta <sfaragnaus@gmail.com>
> ---
> Changes in v3:
> - rebased on staging-testing
>
> .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 43 ++++++++++------------
> 1 file changed, 20 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
> index e8cf0b9..a2cc09a 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
> @@ -67,7 +67,7 @@ void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream)
>
>
> audio_info("alsa_stream=%p substream=%p\n", alsa_stream,
> - alsa_stream ? alsa_stream->substream : 0);
> + alsa_stream ? alsa_stream->substream : 0);
>
> if (alsa_stream->open)
> consumed = bcm2835_audio_retrieve_buffers(alsa_stream);
> @@ -82,10 +82,10 @@ void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream)
> new_period = 1;
> }
> audio_debug("updating pos cur: %d + %d max:%d period_bytes:%d, hw_ptr: %d new_period:%d\n",
> - alsa_stream->pos,
> + alsa_stream->pos,
> consumed,
> alsa_stream->buffer_size,
> - (int) (alsa_stream->period_size * alsa_stream->substream->runtime->periods),
> + (int)(alsa_stream->period_size * alsa_stream->substream->runtime->periods),
That's not an "alignment" change :(
> frames_to_bytes(alsa_stream->substream->runtime, alsa_stream->substream->runtime->status->hw_ptr),
> new_period);
> if (alsa_stream->buffer_size) {
> @@ -224,6 +224,7 @@ static int snd_bcm2835_playback_close(struct snd_pcm_substream *substream)
> */
> if (alsa_stream->running) {
> int err;
> +
Nor is this :(
Only do what your say your patch is doing, otherwise it makes reviewers
mad...
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrea della Porta <sfaragnaus@gmail.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] staging: vc04_services: bcm2835-audio: bcm2835-pcm.c Fixed checkpatch warning about unaligned function params
Date: Tue, 11 Apr 2017 16:15:23 +0200 [thread overview]
Message-ID: <20170411141523.GA15891@kroah.com> (raw)
In-Reply-To: <2b55563dd9824e6f9d45b174f1eccd301fccc2d5.1491693395.git.sfaragnaus@gmail.com>
On Sun, Apr 09, 2017 at 12:25:25AM +0100, Andrea della Porta wrote:
> Fixed unaligned function parameters issues, as per checkpatch warning
>
> Signed-off-by: Andrea della Porta <sfaragnaus@gmail.com>
> ---
> Changes in v3:
> - rebased on staging-testing
>
> .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 43 ++++++++++------------
> 1 file changed, 20 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
> index e8cf0b9..a2cc09a 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
> @@ -67,7 +67,7 @@ void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream)
>
>
> audio_info("alsa_stream=%p substream=%p\n", alsa_stream,
> - alsa_stream ? alsa_stream->substream : 0);
> + alsa_stream ? alsa_stream->substream : 0);
>
> if (alsa_stream->open)
> consumed = bcm2835_audio_retrieve_buffers(alsa_stream);
> @@ -82,10 +82,10 @@ void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream)
> new_period = 1;
> }
> audio_debug("updating pos cur: %d + %d max:%d period_bytes:%d, hw_ptr: %d new_period:%d\n",
> - alsa_stream->pos,
> + alsa_stream->pos,
> consumed,
> alsa_stream->buffer_size,
> - (int) (alsa_stream->period_size * alsa_stream->substream->runtime->periods),
> + (int)(alsa_stream->period_size * alsa_stream->substream->runtime->periods),
That's not an "alignment" change :(
> frames_to_bytes(alsa_stream->substream->runtime, alsa_stream->substream->runtime->status->hw_ptr),
> new_period);
> if (alsa_stream->buffer_size) {
> @@ -224,6 +224,7 @@ static int snd_bcm2835_playback_close(struct snd_pcm_substream *substream)
> */
> if (alsa_stream->running) {
> int err;
> +
Nor is this :(
Only do what your say your patch is doing, otherwise it makes reviewers
mad...
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-11 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 23:25 [PATCH v3 0/2] staging: vc04_services: bcm2835-audio: bcm2835-pcm.c - Fixed several checkpatch issues Andrea della Porta
2017-04-08 23:25 ` Andrea della Porta
2017-04-08 23:25 ` [PATCH v3 1/2] staging: vc04_services: bcm2835-audio: bcm2835-pcm.c Fixed checkpatch warning about unaligned function params Andrea della Porta
2017-04-08 23:25 ` Andrea della Porta
2017-04-11 14:15 ` Greg Kroah-Hartman [this message]
2017-04-11 14:15 ` Greg Kroah-Hartman
2017-04-08 23:25 ` [PATCH v3 2/2] staging: vc04_services: bcm2835-audio: bcm2835-pcm.c Fixed codepatch coding style issue, line over 80 Andrea della Porta
2017-04-08 23:25 ` Andrea della Porta
2017-04-11 14:15 ` Greg Kroah-Hartman
2017-04-11 14:15 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411141523.GA15891@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.