* linux-4.11-rc6/drivers/clk/versatile/clk-icst.c:290]: (style) Redundant condition:
@ 2017-04-10 8:27 David Binderman
2017-04-11 19:16 ` sboyd
0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2017-04-10 8:27 UTC (permalink / raw)
To: mturquette@baylibre.com, sboyd@codeaurora.org,
linux-clk@vger.kernel.org
Hello there,
linux-4.11-rc6/drivers/clk/versatile/clk-icst.c:290]: (style) Redundant con=
dition: If 'rate <=3D 25000000', the comparison 'rate < 29000000' is always=
true.
Source code is
if (rate <=3D 25000000 || rate < 29000000)
return 25000000;
Suggest new code
if ( rate < 29000000)
return 25000000;
Regards
David Binderman
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-4.11-rc6/drivers/clk/versatile/clk-icst.c:290]: (style) Redundant condition:
2017-04-10 8:27 linux-4.11-rc6/drivers/clk/versatile/clk-icst.c:290]: (style) Redundant condition: David Binderman
@ 2017-04-11 19:16 ` sboyd
0 siblings, 0 replies; 2+ messages in thread
From: sboyd @ 2017-04-11 19:16 UTC (permalink / raw)
To: David Binderman; +Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org
On 04/10, David Binderman wrote:
>
> Hello there,
>
> linux-4.11-rc6/drivers/clk/versatile/clk-icst.c:290]: (style) Redundant condition: If 'rate <= 25000000', the comparison 'rate < 29000000' is always true.
>
> Source code is
>
> if (rate <= 25000000 || rate < 29000000)
> return 25000000;
>
> Suggest new code
>
> if ( rate < 29000000)
> return 25000000;
>
Is this automated? Patches welcome.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-11 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-10 8:27 linux-4.11-rc6/drivers/clk/versatile/clk-icst.c:290]: (style) Redundant condition: David Binderman
2017-04-11 19:16 ` sboyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.