From: Matthias Kaehlcke <mka@chromium.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>, Michal Marek <mmarek@suse.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Kieran Bingham <kieran.bingham@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Grant Grundler <grundler@chromium.org>,
Michael Davidson <md@google.com>,
Greg Hackmann <ghackmann@google.com>
Subject: Re: [PATCH] kbuild: Consolidate header generation from ASM offset information
Date: Wed, 12 Apr 2017 01:38:34 +0000 [thread overview]
Message-ID: <20170412013834.GE28657@google.com> (raw)
In-Reply-To: <CAK7LNAQ0sUnXJAzEy8ukK994mUMPJQKHAvyqpvqOXUfaX-pSvA@mail.gmail.com>
Hi Masahiro,
El Wed, Apr 12, 2017 at 09:03:28AM +0900 Masahiro Yamada ha dit:
> 2017-04-04 4:37 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> > Largely redundant code is used in different places to generate C headers
> > from offset information extracted from assembly language output.
> > Consolidate the code in a Makefile include and use this instead.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>
>
> Please move sed-y and filechk_offsets to scripts/Makefile.lib .
> (You may need to rename sed-y
> because arch/xtensa/kernel/Makefile uses this name.)
>
>
> We see various helpers in scripts/Makefile.lib,
> so I do not think we need to create a new file just for this one.
>
> Then, please reuse it from arch/ia64/kernel/Makefile and scripts/mod/Makefile.
> Like this:
>
> include/generated/nr-irqs.h: arch/$(SRCARCH)/kernel/nr-irqs.s FORCE
> $(call filechk,offsets,__ASM_NR_IRQS_H__)
>
> $(obj)/$(devicetable-offsets-file): $(obj)/devicetable-offsets.s FORCE
> $(call filechk,offsets,__DEVICETABLE_OFFSETS_H__)
Thanks for your comments, I'll rework the patch accordingly.
Cheers
Matthias
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>, Michal Marek <mmarek@suse.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Kieran Bingham <kieran.bingham@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Grant Grundler <grundler@chromium.org>,
Michael Davidson <md@google.com>,
Greg Hackmann <ghackmann@google.com>
Subject: Re: [PATCH] kbuild: Consolidate header generation from ASM offset information
Date: Tue, 11 Apr 2017 18:38:34 -0700 [thread overview]
Message-ID: <20170412013834.GE28657@google.com> (raw)
In-Reply-To: <CAK7LNAQ0sUnXJAzEy8ukK994mUMPJQKHAvyqpvqOXUfaX-pSvA@mail.gmail.com>
Hi Masahiro,
El Wed, Apr 12, 2017 at 09:03:28AM +0900 Masahiro Yamada ha dit:
> 2017-04-04 4:37 GMT+09:00 Matthias Kaehlcke <mka@chromium.org>:
> > Largely redundant code is used in different places to generate C headers
> > from offset information extracted from assembly language output.
> > Consolidate the code in a Makefile include and use this instead.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>
>
> Please move sed-y and filechk_offsets to scripts/Makefile.lib .
> (You may need to rename sed-y
> because arch/xtensa/kernel/Makefile uses this name.)
>
>
> We see various helpers in scripts/Makefile.lib,
> so I do not think we need to create a new file just for this one.
>
> Then, please reuse it from arch/ia64/kernel/Makefile and scripts/mod/Makefile.
> Like this:
>
> include/generated/nr-irqs.h: arch/$(SRCARCH)/kernel/nr-irqs.s FORCE
> $(call filechk,offsets,__ASM_NR_IRQS_H__)
>
> $(obj)/$(devicetable-offsets-file): $(obj)/devicetable-offsets.s FORCE
> $(call filechk,offsets,__DEVICETABLE_OFFSETS_H__)
Thanks for your comments, I'll rework the patch accordingly.
Cheers
Matthias
next prev parent reply other threads:[~2017-04-12 1:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 19:37 [PATCH] kbuild: Consolidate header generation from ASM offset information Matthias Kaehlcke
2017-04-03 19:37 ` Matthias Kaehlcke
2017-04-12 0:03 ` Masahiro Yamada
2017-04-12 0:03 ` Masahiro Yamada
2017-04-12 1:38 ` Matthias Kaehlcke [this message]
2017-04-12 1:38 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412013834.GE28657@google.com \
--to=mka@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=ghackmann@google.com \
--cc=grundler@chromium.org \
--cc=jan.kiszka@siemens.com \
--cc=kieran.bingham@linaro.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
--cc=mmarek@suse.com \
--cc=tony.luck@intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.