Re: [PATCH v2 2/2] ASoC: add support for Conexant CX2072X CODEC

[Simon Ho <simon.ho.cnxt@gmail.com>]

On Tue, Apr 11, 2017 at 03:31:37PM +0200, Takashi Iwai wrote:
> On Wed, 05 Apr 2017 11:07:14 +0200,
> <simon.ho.cnxt@gmail.com> wrote:
> > 
> > --- /dev/null
> > +++ b/sound/soc/codecs/cx2072x.c
> > +/**
> > + * cx2072x_enable_detect - Enable CX2072X jack detection
> > + * @codec : pointer variable to codec having information related to codec
> > + *
> > + */
> > +int cx2072x_enable_detect(struct snd_soc_codec *codec)
> > +{
> .....
> > +}
> > +EXPORT_SYMBOL_GPL(cx2072x_enable_detect);
> > +
> > +/*
> > + * cx2072x_get_jack_state: Return current jack state.
> > + * @codec : pointer variable to codec having information related to codec
> > + *
> > + */
> > +int cx2072x_get_jack_state(struct snd_soc_codec *codec)
> > +{
> ....
> > +}
> > +EXPORT_SYMBOL_GPL(cx2072x_get_jack_state);
> > --- /dev/null
> > +++ b/sound/soc/codecs/cx2072x.h
> ....
> > +enum cx2072x_jack_types {
> > +	CX_JACK_NONE = 0x0000,
> > +	CX_JACK_HEADPHONE = 0x0001,
> > +	CX_JACK_APPLE_HEADSET = 0x0002,
> > +	CX_JACK_NOKIE_HEADSET = 0x0003,
> > +};
> > +
> > +int cx2072x_hs_jack_report(struct snd_soc_codec *codec);
> 
> This function is nowhere defined.  And the new jack functions
> cx2072x_enable_detect() and cx2072x_get_jack_state() are not declared
> here, either.
> 
> 
> Takashi

Sorry, I did not verify this feature after jack sense code changed. 

BTW, the cx2072x_jack_types is no longer used, we can remove it.

Simon