All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: simon.ho.cnxt@gmail.com
Cc: pierre-louis.bossart@linux.intel.com,
	alsa-devel@alsa-project.org, Simon Ho <simon.ho@conexant.com>,
	lgirdwood@gmail.com, broonie@kernel.org
Subject: Re: [PATCH v2 2/2] ASoC: add support for Conexant CX2072X CODEC
Date: Tue, 11 Apr 2017 15:31:37 +0200	[thread overview]
Message-ID: <s5hwpart6iu.wl-tiwai@suse.de> (raw)
In-Reply-To: <5b7e78fef2c8e299d39ebaa560d81d66e619e7eb.1491382907.git.simon.ho@conexant.com>

On Wed, 05 Apr 2017 11:07:14 +0200,
<simon.ho.cnxt@gmail.com> wrote:
> 
> --- /dev/null
> +++ b/sound/soc/codecs/cx2072x.c
> +/**
> + * cx2072x_enable_detect - Enable CX2072X jack detection
> + * @codec : pointer variable to codec having information related to codec
> + *
> + */
> +int cx2072x_enable_detect(struct snd_soc_codec *codec)
> +{
.....
> +}
> +EXPORT_SYMBOL_GPL(cx2072x_enable_detect);
> +
> +/*
> + * cx2072x_get_jack_state: Return current jack state.
> + * @codec : pointer variable to codec having information related to codec
> + *
> + */
> +int cx2072x_get_jack_state(struct snd_soc_codec *codec)
> +{
....
> +}
> +EXPORT_SYMBOL_GPL(cx2072x_get_jack_state);
> --- /dev/null
> +++ b/sound/soc/codecs/cx2072x.h
....
> +enum cx2072x_jack_types {
> +	CX_JACK_NONE = 0x0000,
> +	CX_JACK_HEADPHONE = 0x0001,
> +	CX_JACK_APPLE_HEADSET = 0x0002,
> +	CX_JACK_NOKIE_HEADSET = 0x0003,
> +};
> +
> +int cx2072x_hs_jack_report(struct snd_soc_codec *codec);

This function is nowhere defined.  And the new jack functions
cx2072x_enable_detect() and cx2072x_get_jack_state() are not declared
here, either.


Takashi

  reply	other threads:[~2017-04-11 13:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05  9:07 [PATCH v2 0/2] ASoC: add support for CX2072X CODEC simon.ho.cnxt
2017-04-05  9:07 ` [PATCH v2 1/2] ASoC: cx2072x: Add DT bingings documentation " simon.ho.cnxt
2017-04-05  9:07 ` [PATCH v2 2/2] ASoC: add support for Conexant " simon.ho.cnxt
2017-04-11 13:31   ` Takashi Iwai [this message]
2017-04-12  5:45     ` Takashi Iwai
2017-04-12  7:41       ` Takashi Iwai
2017-04-12  7:50         ` Takashi Iwai
2017-04-12 10:20           ` Simon Ho
2017-04-12 10:31         ` Simon Ho
2017-04-12 10:29     ` Simon Ho
2017-10-13 12:37 ` [PATCH v2 0/2] ASoC: add support for " Steven Pitts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hwpart6iu.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=simon.ho.cnxt@gmail.com \
    --cc=simon.ho@conexant.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.