From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: linux-next@vger.kernel.org,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Evgeny Baskakov" <ebaskakov@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Mark Hairgrove" <mhairgrove@nvidia.com>,
"Sherry Cheung" <SCheung@nvidia.com>,
"Subhash Gutti" <sgutti@nvidia.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: [PATCH 4/4] mm/hmm: exclude 64 bit arch that explicitly fail to work.
Date: Wed, 12 Apr 2017 20:30:14 -0400 [thread overview]
Message-ID: <20170413003014.4052-5-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20170413003014.4052-1-paul.gortmaker@windriver.com>
On sparc64, we see:
mm/hmm.c: In function 'hmm_vma_walk_pmd':
mm/hmm.c:371:53: error: macro "pte_index" requires 2 arguments, but only 1 given
mm/hmm.c:371:39: error: 'pte_index' undeclared (first use in this function)
...and on MIPS 64, we see:
mm/hmm.c:57:22: error: field 'mmu_notifier' has incomplete type
mm/hmm.c: In function 'hmm_register':
mm/hmm.c:98:2: error: implicit declaration of function '__mmu_notifier_register' [-Werror=implicit-function-declaration]
mm/hmm.c:111:3: error: implicit declaration of function 'mmu_notifier_unregister' [-Werror=implicit-function-declaration]
...and on Alpha, we see:
mm/hmm.c: In function 'hmm_vma_walk_pmd':
mm/hmm.c:371:4: error: implicit declaration of function 'pmd_pfn'
mm/hmm.c:371:4: error: implicit declaration of function 'pte_index'
...and on PaRISC 64 we see:
include/linux/hmm.h:405:7: warning: 'struct migrate_vma_ops' declared inside parameter list
include/linux/hmm.h:405:7: warning: its scope is only this definition or declaration, which is probably not what you want
mm/hmm.c: In function 'hmm_vma_walk_pmd':
mm/hmm.c:371:4: error: implicit declaration of function 'pmd_pfn'
[...]
Set the dependency to the three arch that currently seem to build
without issue -- ARM_64, X86_64 and S390.
Since ia64 and ppc64 don't set CONFIG_64BIT, they were already
excluded by the original dependency.
The failing arch can be re-added as demand dictates, if/when they
have been validated to build and function.
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Evgeny Baskakov <ebaskakov@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Mark Hairgrove <mhairgrove@nvidia.com>
Cc: Sherry Cheung <SCheung@nvidia.com>
Cc: Subhash Gutti <sgutti@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
mm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/Kconfig b/mm/Kconfig
index 3e9c31bf9aaa..6c27d2003a63 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -293,6 +293,7 @@ config ARCH_HAS_HMM
bool
default y
depends on MMU && 64BIT
+ depends on ARM64 || X86_64 || S390
config HMM
bool
--
2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: linux-next@vger.kernel.org,
"Paul Gortmaker" <paul.gortmaker@windriver.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Evgeny Baskakov" <ebaskakov@nvidia.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Mark Hairgrove" <mhairgrove@nvidia.com>,
"Sherry Cheung" <SCheung@nvidia.com>,
"Subhash Gutti" <sgutti@nvidia.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: [PATCH 4/4] mm/hmm: exclude 64 bit arch that explicitly fail to work.
Date: Wed, 12 Apr 2017 20:30:14 -0400 [thread overview]
Message-ID: <20170413003014.4052-5-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20170413003014.4052-1-paul.gortmaker@windriver.com>
On sparc64, we see:
mm/hmm.c: In function 'hmm_vma_walk_pmd':
mm/hmm.c:371:53: error: macro "pte_index" requires 2 arguments, but only 1 given
mm/hmm.c:371:39: error: 'pte_index' undeclared (first use in this function)
...and on MIPS 64, we see:
mm/hmm.c:57:22: error: field 'mmu_notifier' has incomplete type
mm/hmm.c: In function 'hmm_register':
mm/hmm.c:98:2: error: implicit declaration of function '__mmu_notifier_register' [-Werror=implicit-function-declaration]
mm/hmm.c:111:3: error: implicit declaration of function 'mmu_notifier_unregister' [-Werror=implicit-function-declaration]
...and on Alpha, we see:
mm/hmm.c: In function 'hmm_vma_walk_pmd':
mm/hmm.c:371:4: error: implicit declaration of function 'pmd_pfn'
mm/hmm.c:371:4: error: implicit declaration of function 'pte_index'
...and on PaRISC 64 we see:
include/linux/hmm.h:405:7: warning: 'struct migrate_vma_ops' declared inside parameter list
include/linux/hmm.h:405:7: warning: its scope is only this definition or declaration, which is probably not what you want
mm/hmm.c: In function 'hmm_vma_walk_pmd':
mm/hmm.c:371:4: error: implicit declaration of function 'pmd_pfn'
[...]
Set the dependency to the three arch that currently seem to build
without issue -- ARM_64, X86_64 and S390.
Since ia64 and ppc64 don't set CONFIG_64BIT, they were already
excluded by the original dependency.
The failing arch can be re-added as demand dictates, if/when they
have been validated to build and function.
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Evgeny Baskakov <ebaskakov@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Mark Hairgrove <mhairgrove@nvidia.com>
Cc: Sherry Cheung <SCheung@nvidia.com>
Cc: Subhash Gutti <sgutti@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
mm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/Kconfig b/mm/Kconfig
index 3e9c31bf9aaa..6c27d2003a63 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -293,6 +293,7 @@ config ARCH_HAS_HMM
bool
default y
depends on MMU && 64BIT
+ depends on ARM64 || X86_64 || S390
config HMM
bool
--
2.11.0
next prev parent reply other threads:[~2017-04-13 0:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 0:30 [PATCH akpm/next 0/4] Fix various issues in new hmm driver Paul Gortmaker
2017-04-13 0:30 ` Paul Gortmaker
2017-04-13 0:30 ` [PATCH 1/4] mm/hmm: make it explicitly non-modular Paul Gortmaker
2017-04-13 0:30 ` Paul Gortmaker
2017-04-13 0:30 ` [PATCH 2/4] mm/hmm: fix warnings and SECTION_SIZE definition overlap Paul Gortmaker
2017-04-13 0:30 ` Paul Gortmaker
2017-04-14 0:27 ` kbuild test robot
2017-04-14 0:27 ` kbuild test robot
2017-04-13 0:30 ` [PATCH 3/4] mm/hmm: fix Kconfig to have valid usage of "select" Paul Gortmaker
2017-04-13 0:30 ` Paul Gortmaker
2017-04-13 0:30 ` Paul Gortmaker [this message]
2017-04-13 0:30 ` [PATCH 4/4] mm/hmm: exclude 64 bit arch that explicitly fail to work Paul Gortmaker
2017-04-13 3:27 ` Stephen Rothwell
2017-04-13 3:56 ` Paul Gortmaker
2017-04-13 5:12 ` Michael Ellerman
2017-04-13 12:03 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413003014.4052-5-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=SCheung@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=ebaskakov@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mhairgrove@nvidia.com \
--cc=sgutti@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.