From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@fb.com>, Omar Sandoval <osandov@osandov.com>,
Ming Lei <ming.lei@redhat.com>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
Hannes Reinecke <hare@suse.de>,
Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: bios with an offset are always gappy
Date: Thu, 13 Apr 2017 12:01:35 +0200 [thread overview]
Message-ID: <20170413100135.GF6734@linux-x5ow.site> (raw)
In-Reply-To: <20170413094835.GA28413@lst.de>
On Thu, Apr 13, 2017 at 11:48:35AM +0200, Christoph Hellwig wrote:
> On Thu, Apr 13, 2017 at 10:06:29AM +0200, Johannes Thumshirn wrote:
> > Doing a mkfs.btrfs on a (qemu emulated) PCIe NVMe causes a kernel panic
> > in nvme_setup_prps() because the dma_len will drop below zero but the
> > length not.
>
> I think we should also turns this into a WARN_ON_ONCE + error return..
>
> But do you have an exact btrfsprogs version and command line? I do a lot
> of testing that involves mkfs.btrfs on nvme and haven't seen it..
Ah one detail I forgot: mkfs.xfs _does_ work. Haven't checked ext4 though.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-04-13 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 8:06 [PATCH] block: bios with an offset are always gappy Johannes Thumshirn
2017-04-13 9:48 ` Christoph Hellwig
2017-04-13 9:56 ` Johannes Thumshirn
2017-04-13 10:01 ` Johannes Thumshirn [this message]
2017-04-13 10:02 ` Ming Lei
2017-04-13 10:10 ` Johannes Thumshirn
2017-04-13 11:53 ` Johannes Thumshirn
2017-04-13 12:11 ` Ming Lei
[not found] ` <20170413122010.GJ6734@linux-x5ow.site>
2017-04-13 13:44 ` Ming Lei
2017-04-13 14:45 ` Ming Lei
2017-04-13 14:50 ` Johannes Thumshirn
2017-04-13 20:35 ` Andreas Mohr
2017-04-14 1:15 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413100135.GF6734@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=Bart.VanAssche@sandisk.com \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.