From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/4] genirq: return the irq name from free_irq
Date: Fri, 14 Apr 2017 19:36:49 +0200 [thread overview]
Message-ID: <20170414173649.GA26228@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1704141920560.2327@nanos>
On Fri, Apr 14, 2017@07:28:42PM +0200, Thomas Gleixner wrote:
> On Thu, 13 Apr 2017, Christoph Hellwig wrote:
>
> > This allows callers to get back at them instead of having to store
> > it in another variable.
>
> Alternatively you tell the irq code to free it for you. Patch below.
Yes, this should work to. But I think having the same layer free
something they allocated again is a tad cleaner in terms of layering.
If you prefer this version I can respin the series.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Christoph Hellwig <hch@lst.de>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] genirq: return the irq name from free_irq
Date: Fri, 14 Apr 2017 19:36:49 +0200 [thread overview]
Message-ID: <20170414173649.GA26228@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1704141920560.2327@nanos>
On Fri, Apr 14, 2017 at 07:28:42PM +0200, Thomas Gleixner wrote:
> On Thu, 13 Apr 2017, Christoph Hellwig wrote:
>
> > This allows callers to get back at them instead of having to store
> > it in another variable.
>
> Alternatively you tell the irq code to free it for you. Patch below.
Yes, this should work to. But I think having the same layer free
something they allocated again is a tad cleaner in terms of layering.
If you prefer this version I can respin the series.
next prev parent reply other threads:[~2017-04-14 17:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 7:06 provide pci_request_irq / pci_free_irq helpers Christoph Hellwig
2017-04-13 7:06 ` Christoph Hellwig
2017-04-13 7:06 ` [PATCH 1/4] genirq: fix indentation in remove_irq Christoph Hellwig
2017-04-13 7:06 ` Christoph Hellwig
2017-04-14 17:20 ` Thomas Gleixner
2017-04-14 17:20 ` Thomas Gleixner
2017-04-20 13:25 ` Sagi Grimberg
2017-04-20 13:25 ` Sagi Grimberg
2017-04-13 7:06 ` [PATCH 2/4] genirq: return the irq name from free_irq Christoph Hellwig
2017-04-13 7:06 ` Christoph Hellwig
2017-04-14 17:28 ` Thomas Gleixner
2017-04-14 17:28 ` Thomas Gleixner
2017-04-14 17:36 ` Christoph Hellwig [this message]
2017-04-14 17:36 ` Christoph Hellwig
2017-04-14 17:53 ` Thomas Gleixner
2017-04-14 17:53 ` Thomas Gleixner
2017-04-13 7:06 ` [PATCH 3/4] PCI/irq: add pci_request_irq and pci_free_irq helpers Christoph Hellwig
2017-04-13 7:06 ` Christoph Hellwig
2017-04-14 14:46 ` Bjorn Helgaas
2017-04-14 14:46 ` Bjorn Helgaas
2017-04-14 15:58 ` Christoph Hellwig
2017-04-14 15:58 ` Christoph Hellwig
2017-04-13 7:06 ` [PATCH 4/4] nvme/pci: switch to pci_request_irq Christoph Hellwig
2017-04-13 7:06 ` Christoph Hellwig
2017-04-13 20:02 ` Keith Busch
2017-04-13 20:02 ` Keith Busch
2017-04-20 16:19 ` Sagi Grimberg
2017-04-20 16:19 ` Sagi Grimberg
2017-04-18 18:45 ` provide pci_request_irq / pci_free_irq helpers Bjorn Helgaas
2017-04-18 18:45 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170414173649.GA26228@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.