All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg at kroah.com <greg@kroah.com>
To: Rishiraj Manwatkar <manwatkar@outlook.com>
Cc: "lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"andreas.dilger@intel.com" <andreas.dilger@intel.com>,
	"oleg.drokin@intel.com" <oleg.drokin@intel.com>
Subject: [lustre-devel] [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues
Date: Tue, 18 Apr 2017 17:50:19 +0200	[thread overview]
Message-ID: <20170418155019.GA7263@kroah.com> (raw)
In-Reply-To: <VI1PR0901MB16166F494E9CECB93E1CD478A4040@VI1PR0901MB1616.eurprd09.prod.outlook.com>

On Sat, Apr 15, 2017 at 01:50:42PM +0000, Rishiraj Manwatkar wrote:
> Parantheses are added for Macro argument, to avoid precedence issues.
> 
> Signed-off-by: Rishiraj Manwatkar <manwatkar@outlook.com>
> ---
>  v1 -> v2: Added mailing list in cc.
>  v2 -> v3: Changed From: to be same as Signed-off-by:.
>  drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> index ee7d677..0997254 100755
> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> @@ -52,9 +52,9 @@
>   */
>  
>  #define cl_io_for_each(slice, io) \
> -	list_for_each_entry((slice), &io->ci_layers, cis_linkage)
> +	list_for_each_entry((slice), &(io)->ci_layers, cis_linkage)

Really?  There is no precedence issues that I can see here, sorry.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: "greg@kroah.com" <greg@kroah.com>
To: Rishiraj Manwatkar <manwatkar@outlook.com>
Cc: "lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"andreas.dilger@intel.com" <andreas.dilger@intel.com>,
	"oleg.drokin@intel.com" <oleg.drokin@intel.com>
Subject: Re: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues
Date: Tue, 18 Apr 2017 17:50:19 +0200	[thread overview]
Message-ID: <20170418155019.GA7263@kroah.com> (raw)
In-Reply-To: <VI1PR0901MB16166F494E9CECB93E1CD478A4040@VI1PR0901MB1616.eurprd09.prod.outlook.com>

On Sat, Apr 15, 2017 at 01:50:42PM +0000, Rishiraj Manwatkar wrote:
> Parantheses are added for Macro argument, to avoid precedence issues.
> 
> Signed-off-by: Rishiraj Manwatkar <manwatkar@outlook.com>
> ---
>  v1 -> v2: Added mailing list in cc.
>  v2 -> v3: Changed From: to be same as Signed-off-by:.
>  drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> index ee7d677..0997254 100755
> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> @@ -52,9 +52,9 @@
>   */
>  
>  #define cl_io_for_each(slice, io) \
> -	list_for_each_entry((slice), &io->ci_layers, cis_linkage)
> +	list_for_each_entry((slice), &(io)->ci_layers, cis_linkage)

Really?  There is no precedence issues that I can see here, sorry.

thanks,

greg k-h

       reply	other threads:[~2017-04-18 15:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a2e734ab4562ded68cb7e7b8d55f51f757189fcd.1492255078>
     [not found] ` <VI1PR0901MB16166F494E9CECB93E1CD478A4040@VI1PR0901MB1616.eurprd09.prod.outlook.com>
2017-04-18 15:50   ` greg at kroah.com [this message]
2017-04-18 15:50     ` [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues greg
2017-04-19  1:21     ` [lustre-devel] " Dilger, Andreas
2017-04-19  1:21       ` Dilger, Andreas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418155019.GA7263@kroah.com \
    --to=greg@kroah.com \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=manwatkar@outlook.com \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.