From: Dan Carpenter <dan.carpenter@oracle.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "Sørensen, Stefan" <Stefan.Sorensen@spectralink.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] dp83640: don't recieve time stamps twice
Date: Wed, 19 Apr 2017 10:53:26 +0000 [thread overview]
Message-ID: <20170419105326.45khz5ayre75d5i2@mwanda> (raw)
In-Reply-To: <20170419103135.GA1670@localhost.localdomain>
On Wed, Apr 19, 2017 at 12:31:35PM +0200, Richard Cochran wrote:
> On Wed, Apr 19, 2017 at 09:16:56AM +0000, Sørensen, Stefan wrote:
> > You are correct that these lines was added accidentally.
>
> Can we please fix this in another way? There is no need to hold the
> spin lock during the callback into the networking stack. Instead, how
> about the following diff, which also fixes the other call site...
>
I'm fine with this. I hated my changelog, as well because it sounds
like guess work. Could you send it with a:
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "Sørensen, Stefan" <Stefan.Sorensen@spectralink.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] dp83640: don't recieve time stamps twice
Date: Wed, 19 Apr 2017 13:53:26 +0300 [thread overview]
Message-ID: <20170419105326.45khz5ayre75d5i2@mwanda> (raw)
In-Reply-To: <20170419103135.GA1670@localhost.localdomain>
On Wed, Apr 19, 2017 at 12:31:35PM +0200, Richard Cochran wrote:
> On Wed, Apr 19, 2017 at 09:16:56AM +0000, Sørensen, Stefan wrote:
> > You are correct that these lines was added accidentally.
>
> Can we please fix this in another way? There is no need to hold the
> spin lock during the callback into the networking stack. Instead, how
> about the following diff, which also fixes the other call site...
>
I'm fine with this. I hated my changelog, as well because it sounds
like guess work. Could you send it with a:
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2017-04-19 10:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 19:14 [PATCH] dp83640: don't recieve time stamps twice Dan Carpenter
2017-04-18 19:14 ` Dan Carpenter
2017-04-18 20:19 ` Richard Cochran
2017-04-18 20:19 ` Richard Cochran
2017-04-19 9:16 ` Sørensen, Stefan
2017-04-19 9:16 ` Sørensen, Stefan
2017-04-19 10:31 ` Richard Cochran
2017-04-19 10:31 ` Richard Cochran
2017-04-19 10:53 ` Dan Carpenter [this message]
2017-04-19 10:53 ` Dan Carpenter
2017-04-19 11:28 ` Sørensen, Stefan
2017-04-19 11:28 ` Sørensen, Stefan
2017-04-19 11:54 ` Richard Cochran
2017-04-19 11:54 ` Richard Cochran
2017-04-20 20:02 ` David Miller
2017-04-20 20:02 ` David Miller
2017-04-20 21:30 ` Richard Cochran
2017-04-20 21:30 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419105326.45khz5ayre75d5i2@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Stefan.Sorensen@spectralink.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.