From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: "zhichang.yuan" <yuanzhichang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
Cc: yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
zhichang.yuan02-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] iommu: make iommu_bus_notifier return NOTIFY_DONE rather than error code
Date: Thu, 20 Apr 2017 16:43:44 +0200 [thread overview]
Message-ID: <20170420144343.GB21305@8bytes.org> (raw)
In-Reply-To: <1492519908-65994-1-git-send-email-yuanzhichang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
On Tue, Apr 18, 2017 at 08:51:48PM +0800, zhichang.yuan wrote:
> In iommu_bus_notifier(), when action is BUS_NOTIFY_ADD_DEVICE, it will return
> 'ops->add_device(dev)' directly. But ops->add_device will return ERR_VAL, such
> as -ENODEV. These value will make notifier_call_chain() not to traverse the
> remain nodes in struct notifier_block list.
>
> This patch revises iommu_bus_notifier() to return NOTIFY_DONE when some errors
> heppened in ops->add_device().
>
> Signed-off-by: zhichang.yuan <yuanzhichang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu: make iommu_bus_notifier return NOTIFY_DONE rather than error code
Date: Thu, 20 Apr 2017 16:43:44 +0200 [thread overview]
Message-ID: <20170420144343.GB21305@8bytes.org> (raw)
In-Reply-To: <1492519908-65994-1-git-send-email-yuanzhichang@hisilicon.com>
On Tue, Apr 18, 2017 at 08:51:48PM +0800, zhichang.yuan wrote:
> In iommu_bus_notifier(), when action is BUS_NOTIFY_ADD_DEVICE, it will return
> 'ops->add_device(dev)' directly. But ops->add_device will return ERR_VAL, such
> as -ENODEV. These value will make notifier_call_chain() not to traverse the
> remain nodes in struct notifier_block list.
>
> This patch revises iommu_bus_notifier() to return NOTIFY_DONE when some errors
> heppened in ops->add_device().
>
> Signed-off-by: zhichang.yuan <yuanzhichang@hisilicon.com>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: "zhichang.yuan" <yuanzhichang@hisilicon.com>
Cc: iommu@lists.linux-foundation.org, linuxarm@huawei.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com,
zhichang.yuan02@gmail.com, yankejian@huawei.com,
huangdaode@hisilicon.com
Subject: Re: [PATCH] iommu: make iommu_bus_notifier return NOTIFY_DONE rather than error code
Date: Thu, 20 Apr 2017 16:43:44 +0200 [thread overview]
Message-ID: <20170420144343.GB21305@8bytes.org> (raw)
In-Reply-To: <1492519908-65994-1-git-send-email-yuanzhichang@hisilicon.com>
On Tue, Apr 18, 2017 at 08:51:48PM +0800, zhichang.yuan wrote:
> In iommu_bus_notifier(), when action is BUS_NOTIFY_ADD_DEVICE, it will return
> 'ops->add_device(dev)' directly. But ops->add_device will return ERR_VAL, such
> as -ENODEV. These value will make notifier_call_chain() not to traverse the
> remain nodes in struct notifier_block list.
>
> This patch revises iommu_bus_notifier() to return NOTIFY_DONE when some errors
> heppened in ops->add_device().
>
> Signed-off-by: zhichang.yuan <yuanzhichang@hisilicon.com>
Applied, thanks.
next prev parent reply other threads:[~2017-04-20 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 12:51 [PATCH] iommu: make iommu_bus_notifier return NOTIFY_DONE rather than error code zhichang.yuan
2017-04-18 12:51 ` zhichang.yuan
2017-04-18 12:51 ` zhichang.yuan
[not found] ` <1492519908-65994-1-git-send-email-yuanzhichang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
2017-04-20 14:43 ` Joerg Roedel [this message]
2017-04-20 14:43 ` Joerg Roedel
2017-04-20 14:43 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420144343.GB21305@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=huangdaode-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=yankejian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=yuanzhichang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
--cc=zhichang.yuan02-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.