All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Jan Glauber <jan.glauber@caviumnetworks.com>
Cc: Wolfram Sang <wsa-dev@sang-engineering.com>,
	linux-i2c@vger.kernel.org,
	Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
Subject: Re: [PATCH 4/4] i2c: octeon: thunderx: Add I2C_CLASS_HWMON
Date: Fri, 21 Apr 2017 08:29:40 +0200	[thread overview]
Message-ID: <20170421062940.GA1434@katana> (raw)
In-Reply-To: <20170420172728.GA4311@hc>

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]

Hi Jan,

> What is missing in the pci-driver for ACPI support? We already use ACPI
> to detect the sclk setting.

I noticed this in the driver:

134 static int thunder_i2c_smbus_setup(struct octeon_i2c *i2c,
135                                    struct device_node *node)
136 {
137         /* TODO: ACPI support */
138         if (!acpi_disabled)
139                 return -EOPNOTSUPP;
140 
141         return thunder_i2c_smbus_setup_of(i2c, node);
142 }

And from a glimpse, I assumed this is the place to detect and
instantiate client devices.

> So, if you're ok with this I'll re-phrase the commit message and
> re-submit the patch.

I'm OK. It is basically your call. I just wanted to make sure you know
what it means adding the class to a master driver.

Regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2017-04-21  6:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09  9:31 [PATCH 0/4] i2c octeon & thunderx bug fixes Jan Glauber
2016-12-09  9:31 ` [PATCH 1/4] i2c: octeon: thunderx: TWSI software reset in recovery Jan Glauber
2016-12-11 22:01   ` Wolfram Sang
2016-12-09  9:31 ` [PATCH 2/4] i2c: octeon: thunderx: Remove double-check after interrupt Jan Glauber
2016-12-11 22:01   ` Wolfram Sang
2016-12-09  9:31 ` [PATCH 3/4] i2c: octeon: thunderx: Limit register access retries Jan Glauber
2016-12-11 22:01   ` Wolfram Sang
2016-12-12 16:07     ` Jan Glauber
2016-12-12 16:07       ` Jan Glauber
2016-12-13 20:32       ` Wolfram Sang
2016-12-17 18:29   ` Wolfram Sang
2016-12-09  9:31 ` [PATCH 4/4] i2c: octeon: thunderx: Add I2C_CLASS_HWMON Jan Glauber
2016-12-11 22:04   ` Wolfram Sang
2017-01-25 20:49     ` Wolfram Sang
2017-01-26  6:10       ` Jan Glauber
2017-01-26  6:10         ` Jan Glauber
2017-04-20  9:16       ` Jan Glauber
2017-04-20 15:55         ` Wolfram Sang
2017-04-20 17:27           ` Jan Glauber
2017-04-21  6:29             ` Wolfram Sang [this message]
2017-04-21 14:31               ` Jan Glauber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170421062940.GA1434@katana \
    --to=wsa@the-dreams.de \
    --cc=Vadim.Lomovtsev@caviumnetworks.com \
    --cc=jan.glauber@caviumnetworks.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa-dev@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.