From: Jan Glauber <jan.glauber@caviumnetworks.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa-dev@sang-engineering.com>,
Paul Burton <paul.burton@imgtec.com>,
"Steven J . Hill" <Steven.Hill@cavium.com>,
linux-i2c@vger.kernel.org, linux-mips@linux-mips.org,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 4/4] i2c: octeon: thunderx: Add I2C_CLASS_HWMON
Date: Thu, 26 Jan 2017 07:10:30 +0100 [thread overview]
Message-ID: <20170126061030.GA2827@hardcore> (raw)
In-Reply-To: <20170125204923.2mxtlszvco6wxjok@ninjato>
On Wed, Jan 25, 2017 at 09:49:23PM +0100, Wolfram Sang wrote:
> On Sun, Dec 11, 2016 at 11:04:35PM +0100, Wolfram Sang wrote:
> > On Fri, Dec 09, 2016 at 10:31:58AM +0100, Jan Glauber wrote:
> > > It was reported that ipmi_ssif fails to create the
> > > ipmi device on some systems if the adapter class is not containing
> > > I2C_CLASS_HWMON. Fix it by setting the class.
> > >
> > > Reported-by: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
> > > Signed-off-by: Jan Glauber <jglauber@cavium.com>
> >
> > The intention of adapter classes is to *limit* probing to a certain
> > class of devices. If a class is needed to *enable* probing, then
> > something there looks wrong. From the details given, this must be solved
> > elsewhere I'd say.
>
> Makes sense?
>
Yes, perfectly, the patch can be dropped.
thanks,
Jan
WARNING: multiple messages have this Message-ID (diff)
From: Jan Glauber <jan.glauber@caviumnetworks.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa-dev@sang-engineering.com>,
Paul Burton <paul.burton@imgtec.com>,
"Steven J . Hill" <Steven.Hill@cavium.com>,
<linux-i2c@vger.kernel.org>, <linux-mips@linux-mips.org>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 4/4] i2c: octeon: thunderx: Add I2C_CLASS_HWMON
Date: Thu, 26 Jan 2017 07:10:30 +0100 [thread overview]
Message-ID: <20170126061030.GA2827@hardcore> (raw)
In-Reply-To: <20170125204923.2mxtlszvco6wxjok@ninjato>
On Wed, Jan 25, 2017 at 09:49:23PM +0100, Wolfram Sang wrote:
> On Sun, Dec 11, 2016 at 11:04:35PM +0100, Wolfram Sang wrote:
> > On Fri, Dec 09, 2016 at 10:31:58AM +0100, Jan Glauber wrote:
> > > It was reported that ipmi_ssif fails to create the
> > > ipmi device on some systems if the adapter class is not containing
> > > I2C_CLASS_HWMON. Fix it by setting the class.
> > >
> > > Reported-by: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
> > > Signed-off-by: Jan Glauber <jglauber@cavium.com>
> >
> > The intention of adapter classes is to *limit* probing to a certain
> > class of devices. If a class is needed to *enable* probing, then
> > something there looks wrong. From the details given, this must be solved
> > elsewhere I'd say.
>
> Makes sense?
>
Yes, perfectly, the patch can be dropped.
thanks,
Jan
next prev parent reply other threads:[~2017-01-26 6:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 9:31 [PATCH 0/4] i2c octeon & thunderx bug fixes Jan Glauber
2016-12-09 9:31 ` [PATCH 1/4] i2c: octeon: thunderx: TWSI software reset in recovery Jan Glauber
2016-12-11 22:01 ` Wolfram Sang
2016-12-09 9:31 ` [PATCH 2/4] i2c: octeon: thunderx: Remove double-check after interrupt Jan Glauber
2016-12-11 22:01 ` Wolfram Sang
2016-12-09 9:31 ` [PATCH 3/4] i2c: octeon: thunderx: Limit register access retries Jan Glauber
2016-12-11 22:01 ` Wolfram Sang
2016-12-12 16:07 ` Jan Glauber
2016-12-12 16:07 ` Jan Glauber
2016-12-13 20:32 ` Wolfram Sang
2016-12-17 18:29 ` Wolfram Sang
2016-12-09 9:31 ` [PATCH 4/4] i2c: octeon: thunderx: Add I2C_CLASS_HWMON Jan Glauber
2016-12-11 22:04 ` Wolfram Sang
2017-01-25 20:49 ` Wolfram Sang
2017-01-26 6:10 ` Jan Glauber [this message]
2017-01-26 6:10 ` Jan Glauber
2017-04-20 9:16 ` Jan Glauber
2017-04-20 15:55 ` Wolfram Sang
2017-04-20 17:27 ` Jan Glauber
2017-04-21 6:29 ` Wolfram Sang
2017-04-21 14:31 ` Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126061030.GA2827@hardcore \
--to=jan.glauber@caviumnetworks.com \
--cc=Steven.Hill@cavium.com \
--cc=david.daney@cavium.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=wsa-dev@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.