From: Mike Snitzer <snitzer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
dm-devel@redhat.com, linux-block@vger.kernel.org,
Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: [PATCH for-4.12] block, dm: use __blk_integrity_register to properly setup integrity profile
Date: Sat, 22 Apr 2017 11:10:43 -0400 [thread overview]
Message-ID: <20170422151043.GA22651@redhat.com> (raw)
In-Reply-To: <yq1o9vpjs9f.fsf@oracle.com>
On Fri, Apr 21 2017 at 6:43pm -0400,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
>
> Mike/Mikulas,
>
> > Introduce __blk_integrity_register() to allow users more precise control
> > over the logical block size used to register the integrity profile.
> > blk_integrity_register() now calls __blk_integrity_register().
>
> This seems a bit kludgy. It would be cleaner having the integrity
> interval be explicitly specified in the integrity template for all
> callers. Maybe with a fallback to qlbs if it's set to 0.
Fair enough, I'll revise and send v2 shortly. Thanks.
next prev parent reply other threads:[~2017-04-22 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 22:28 [PATCH for-4.12] block, dm: use __blk_integrity_register to properly setup integrity profile Mike Snitzer
2017-04-21 22:43 ` Martin K. Petersen
2017-04-22 15:10 ` Mike Snitzer [this message]
2017-04-22 21:22 ` [PATCH v2 for-4.12] block: fix blk_integrity_register to use template's interval_exp if not 0 Mike Snitzer
2017-04-23 18:42 ` Martin K. Petersen
2017-04-23 19:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170422151043.GA22651@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.