From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
dm-devel@redhat.com, linux-block@vger.kernel.org,
Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: [PATCH v2 for-4.12] block: fix blk_integrity_register to use template's interval_exp if not 0
Date: Sun, 23 Apr 2017 14:42:37 -0400 [thread overview]
Message-ID: <yq1inlvj78i.fsf@oracle.com> (raw)
In-Reply-To: <20170422212209.GA49088@redhat.com> (Mike Snitzer's message of "Sat, 22 Apr 2017 17:22:09 -0400")
Mike,
> When registering an integrity profile: if the template's interval_exp is
> not 0 use it, otherwise use the ilog2() of logical block size of the
> provided gendisk.
>
> This fixes a long-standing DM linear target bug where it cannot pass
> integrity data to the underlying device if its logical block size
> conflicts with the underlying device's logical block size.
Looks good!
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-04-23 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 22:28 [PATCH for-4.12] block, dm: use __blk_integrity_register to properly setup integrity profile Mike Snitzer
2017-04-21 22:43 ` Martin K. Petersen
2017-04-22 15:10 ` Mike Snitzer
2017-04-22 21:22 ` [PATCH v2 for-4.12] block: fix blk_integrity_register to use template's interval_exp if not 0 Mike Snitzer
2017-04-23 18:42 ` Martin K. Petersen [this message]
2017-04-23 19:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1inlvj78i.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.