From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v2 3/4] nvme: enable SG gaps support
Date: Mon, 24 Apr 2017 09:02:10 +0200 [thread overview]
Message-ID: <20170424070210.GA8719@lst.de> (raw)
In-Reply-To: <9fe3f5fa-4496-3819-0288-08a073dd1a1a@grimberg.me>
On Sun, Apr 23, 2017@12:45:39PM +0300, Sagi Grimberg wrote:
>> still would fit NVMe dword-alignment SGLs, though :)
>
> I would say its useful to have, but its only relevant to ioctls as
> normal io we explicitly on sub logical block size alignment.
>
> Anyways, I still think having ctrl->virt_boundary instead of
> ctrl->sg_gap_support is cleaner...
Ok, fine with me.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
keith.busch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v2 3/4] nvme: enable SG gaps support
Date: Mon, 24 Apr 2017 09:02:10 +0200 [thread overview]
Message-ID: <20170424070210.GA8719@lst.de> (raw)
In-Reply-To: <9fe3f5fa-4496-3819-0288-08a073dd1a1a-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
On Sun, Apr 23, 2017 at 12:45:39PM +0300, Sagi Grimberg wrote:
>> still would fit NVMe dword-alignment SGLs, though :)
>
> I would say its useful to have, but its only relevant to ioctls as
> normal io we explicitly on sub logical block size alignment.
>
> Anyways, I still think having ctrl->virt_boundary instead of
> ctrl->sg_gap_support is cleaner...
Ok, fine with me.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-24 7:02 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 15:56 [PATCH v2 0/4] arbitrary sg lists support Max Gurtovoy
2017-04-13 15:56 ` Max Gurtovoy
2017-04-13 15:56 ` [PATCH v2 1/4] IB/core: Add inline function to get sg mr type Max Gurtovoy
2017-04-13 15:56 ` Max Gurtovoy
2017-04-20 11:24 ` Sagi Grimberg
2017-04-20 11:24 ` Sagi Grimberg
2017-04-13 15:56 ` [PATCH v2 2/4] IB/iser: Use ib_get_sg_mr_type() helper Max Gurtovoy
2017-04-13 15:56 ` Max Gurtovoy
2017-04-13 15:56 ` [PATCH v2 3/4] nvme: enable SG gaps support Max Gurtovoy
2017-04-13 15:56 ` Max Gurtovoy
2017-04-20 11:27 ` Sagi Grimberg
2017-04-20 11:27 ` Sagi Grimberg
2017-04-21 6:44 ` Christoph Hellwig
2017-04-21 6:44 ` Christoph Hellwig
2017-04-23 7:20 ` Sagi Grimberg
2017-04-23 7:20 ` Sagi Grimberg
2017-04-23 8:45 ` Christoph Hellwig
2017-04-23 8:45 ` Christoph Hellwig
2017-04-23 9:45 ` Sagi Grimberg
2017-04-23 9:45 ` Sagi Grimberg
2017-04-23 13:23 ` Max Gurtovoy
2017-04-23 13:23 ` Max Gurtovoy
2017-04-24 7:02 ` Christoph Hellwig [this message]
2017-04-24 7:02 ` Christoph Hellwig
2017-04-13 15:56 ` [PATCH v2 4/4] nvme-rdma: add support for arbitrary sg lists mapping Max Gurtovoy
2017-04-13 15:56 ` Max Gurtovoy
2017-04-13 16:31 ` [PATCH v2 0/4] arbitrary sg lists support Bart Van Assche
2017-04-13 16:31 ` Bart Van Assche
2017-04-13 16:46 ` Max Gurtovoy
2017-04-13 16:46 ` Max Gurtovoy
2017-04-13 16:59 ` Laurence Oberman
2017-04-13 16:59 ` Laurence Oberman
2017-04-20 11:30 ` Sagi Grimberg
2017-04-20 11:30 ` Sagi Grimberg
2017-04-23 10:34 ` Leon Romanovsky
2017-04-23 10:34 ` Leon Romanovsky
2017-04-23 11:49 ` Sagi Grimberg
2017-04-23 11:49 ` Sagi Grimberg
2017-04-23 12:12 ` Leon Romanovsky
2017-04-23 12:12 ` Leon Romanovsky
2017-04-23 12:28 ` Sagi Grimberg
2017-04-23 12:28 ` Sagi Grimberg
2017-04-23 13:35 ` Max Gurtovoy
2017-04-23 13:35 ` Max Gurtovoy
2017-04-23 14:35 ` Sagi Grimberg
2017-04-23 14:35 ` Sagi Grimberg
2017-05-01 18:50 ` Doug Ledford
2017-05-01 18:50 ` Doug Ledford
2017-05-02 16:14 ` Max Gurtovoy
2017-05-02 16:14 ` Max Gurtovoy
2017-05-02 16:39 ` Laurence Oberman
2017-05-02 16:39 ` Laurence Oberman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424070210.GA8719@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.