All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Dan Williams <dan.j.williams@intel.com>,
	Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: linux-next: build failure after merge of the nvdimm tree
Date: Mon, 24 Apr 2017 16:11:30 +1000	[thread overview]
Message-ID: <20170424161130.762d71a8@canb.auug.org.au> (raw)

Hi Dan,

After merging the nvdimm tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/nvdimm/x86.c: In function 'pmem_from_user':
drivers/nvdimm/x86.c:115:11: error: implicit declaration of function '__copy_from_user_nocache' [-Werror=implicit-function-declaration]
  int rc = __copy_from_user_nocache(dst, src, size);
           ^

Caused by commit

  6e704ff67315 ("uio, libnvdimm, pmem: implement cache bypass for all copy_from_iter() operations")

interacting with commit

  3f763453e6f2 ("kill __copy_from_user_nocache()")

from the vfs tree.

I have no idea why Al removed that function, so I just applied the
following fix patch for now:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 24 Apr 2017 16:03:09 +1000
Subject: [PATCH] uio, libnvdimm, pmem: implement cache bypass for all
 copy_from_iter() operations fix

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/nvdimm/x86.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvdimm/x86.c b/drivers/nvdimm/x86.c
index bc145d760d43..4c15cc103713 100644
--- a/drivers/nvdimm/x86.c
+++ b/drivers/nvdimm/x86.c
@@ -112,7 +112,7 @@ EXPORT_SYMBOL_GPL(arch_memcpy_to_pmem);
 static int pmem_from_user(void *dst, const void __user *src, unsigned size)
 {
 	unsigned long flushed, dest = (unsigned long) dest;
-	int rc = __copy_from_user_nocache(dst, src, size);
+	int rc = __copy_from_user(dst, src, size);
 
 	/*
 	 * On x86_64 __copy_from_user_nocache() uses non-temporal stores
-- 
2.11.0

-- 
Cheers,
Stephen Rothwell

             reply	other threads:[~2017-04-24  6:11 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  6:11 Stephen Rothwell [this message]
2017-04-24  8:39 ` linux-next: build failure after merge of the nvdimm tree Al Viro
2017-04-24 23:29   ` Dan Williams
2017-04-25 22:22   ` Dan Williams
  -- strict thread matches above, loose matches on Subject: below --
2022-05-16  9:10 Stephen Rothwell
2022-05-16 18:05 ` Dan Williams
2021-08-30  7:09 Stephen Rothwell
2021-08-30  7:10 ` Christoph Hellwig
2021-08-30  7:15   ` Gao Xiang
2019-07-05  7:20 Stephen Rothwell
2019-07-05  8:45 ` Pankaj Gupta
2019-07-05 11:09   ` Stephen Rothwell
2019-07-05 11:14     ` Pankaj Gupta
2019-07-05 22:32 ` Dan Williams
2019-07-05 23:48   ` Stephen Rothwell
2019-06-20  9:29 Stephen Rothwell
2019-06-20 10:30 ` Pankaj Gupta
2018-04-09  3:16 Stephen Rothwell
2018-04-09  3:38 ` Oliver
2018-04-09  7:34   ` Oliver
2018-04-09 17:11     ` Dan Williams
2018-04-09 18:14       ` Dan Williams
2017-11-03  7:19 Stephen Rothwell
2017-11-03 16:04 ` Dan Williams
2017-09-04  7:34 Stephen Rothwell
2017-09-04 18:34 ` Dan Williams
2016-07-22  6:13 Stephen Rothwell
2016-07-23  1:04 ` Dan Williams
2016-07-23  3:54   ` Dan Williams
2016-07-21  6:13 Stephen Rothwell
2016-07-21 21:33 ` Dan Williams
2016-03-27  9:50 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170424161130.762d71a8@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.