[PATCH] nvme/lightnvm: add missing endianess conversion in nvme_nvm_end_io

[PATCH] nvme/lightnvm: add missing endianess conversion in nvme_nvm_end_io

[Christoph Hellwig]

Found by sparse.

Signed-off-by: Christoph Hellwig <hch at lst.de>
---
 drivers/nvme/host/lightnvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
index de61a4a03d78..e4e4e60b1224 100644
--- a/drivers/nvme/host/lightnvm.c
+++ b/drivers/nvme/host/lightnvm.c
@@ -483,7 +483,7 @@ static void nvme_nvm_end_io(struct request *rq, int error)
 {
 	struct nvm_rq *rqd = rq->end_io_data;
 
-	rqd->ppa_status = nvme_req(rq)->result.u64;
+	rqd->ppa_status = le64_to_cpu(nvme_req(rq)->result.u64);
 	rqd->error = nvme_req(rq)->status;
 	nvm_end_io(rqd);
 
-- 
2.11.0

[PATCH] nvme/lightnvm: add missing endianess conversion in nvme_nvm_end_io

[Christoph Hellwig]

Javier, Matias:  can I get a quick ACK?  This is the last patch needed
to make drivers/nvme warning-free.

On Fri, Apr 21, 2017@08:30:17AM +0200, Christoph Hellwig wrote:
> Found by sparse.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
>  drivers/nvme/host/lightnvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index de61a4a03d78..e4e4e60b1224 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -483,7 +483,7 @@ static void nvme_nvm_end_io(struct request *rq, int error)
>  {
>  	struct nvm_rq *rqd = rq->end_io_data;
>  
> -	rqd->ppa_status = nvme_req(rq)->result.u64;
> +	rqd->ppa_status = le64_to_cpu(nvme_req(rq)->result.u64);
>  	rqd->error = nvme_req(rq)->status;
>  	nvm_end_io(rqd);
>  
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
---end quoted text---

[PATCH] nvme/lightnvm: add missing endianess conversion in nvme_nvm_end_io

[Javier Gonzalez]

> On 25 Apr 2017,@18.41, Christoph Hellwig <hch@lst.de> wrote:
> 
> Javier, Matias:  can I get a quick ACK?  This is the last patch needed
> to make drivers/nvme warning-free.

Looks good to me. Sorry for the delay.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20170425/5c2f3f50/attachment-0001.sig>

Re: [PATCH] nvme/lightnvm: add missing endianess conversion in nvme_nvm_end_io

[Matias Bjørling]

________________________________________
From: Christoph Hellwig <hch@lst.de>
Sent: 25 April 2017 09:41
To: Javier Gonzalez; Matias Bj=F8rling
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme/lightnvm: add missing endianess conversion in nvm=
e_nvm_end_io

Javier, Matias:  can I get a quick ACK?  This is the last patch needed
to make drivers/nvme warning-free.

On Fri, Apr 21, 2017 at 08:30:17AM +0200, Christoph Hellwig wrote:
> Found by sparse.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/nvme/host/lightnvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index de61a4a03d78..e4e4e60b1224 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -483,7 +483,7 @@ static void nvme_nvm_end_io(struct request *rq, int e=
rror)
>  {
>       struct nvm_rq *rqd =3D rq->end_io_data;
>
> -     rqd->ppa_status =3D nvme_req(rq)->result.u64;
> +     rqd->ppa_status =3D le64_to_cpu(nvme_req(rq)->result.u64);
>       rqd->error =3D nvme_req(rq)->status;
>       nvm_end_io(rqd);
>
> --
> 2.11.0
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

Thanks Christoph.

Reviewed-by: Matias Bj=F8rling <matias@cnexlabs.com>=

[PATCH] nvme/lightnvm: add missing endianess conversion in nvme_nvm_end_io

[Matias Bjørling]

________________________________________
From: Christoph Hellwig <hch@lst.de>
Sent: 25 April 2017 09:41
To: Javier Gonzalez; Matias Bj?rling
Cc: linux-nvme at lists.infradead.org
Subject: Re: [PATCH] nvme/lightnvm: add missing endianess conversion in nvme_nvm_end_io

Javier, Matias:  can I get a quick ACK?  This is the last patch needed
to make drivers/nvme warning-free.

On Fri, Apr 21, 2017@08:30:17AM +0200, Christoph Hellwig wrote:
> Found by sparse.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
>  drivers/nvme/host/lightnvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index de61a4a03d78..e4e4e60b1224 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -483,7 +483,7 @@ static void nvme_nvm_end_io(struct request *rq, int error)
>  {
>       struct nvm_rq *rqd = rq->end_io_data;
>
> -     rqd->ppa_status = nvme_req(rq)->result.u64;
> +     rqd->ppa_status = le64_to_cpu(nvme_req(rq)->result.u64);
>       rqd->error = nvme_req(rq)->status;
>       nvm_end_io(rqd);
>
> --
> 2.11.0
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

Thanks Christoph.

Reviewed-by: Matias Bj?rling <matias at cnexlabs.com>