From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Robert Richter <rrichter-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] iommu: Print a message with the default domain type created
Date: Wed, 26 Apr 2017 17:50:44 +0200 [thread overview]
Message-ID: <20170426155044.GA1332@8bytes.org> (raw)
In-Reply-To: <20170426143813.21225-1-rrichter-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Hi Robert,
On Wed, Apr 26, 2017 at 04:38:13PM +0200, Robert Richter wrote:
> - pr_info("Adding device %s to group %d\n", dev_name(dev), group->id);
> + pr_info("Adding device %s to group %d, default domain type %d\n",
> + dev_name(dev), group->id,
> + group->default_domain ? group->default_domain->type : -1);
Printing just a number is not very user-friendly. We have only two
default domain-types right now, so it is sufficient to just print
additional information if a device is identity-mapped. Something like
"Adding device %s to group %d - using identity mapping"
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu: Print a message with the default domain type created
Date: Wed, 26 Apr 2017 17:50:44 +0200 [thread overview]
Message-ID: <20170426155044.GA1332@8bytes.org> (raw)
In-Reply-To: <20170426143813.21225-1-rrichter@cavium.com>
Hi Robert,
On Wed, Apr 26, 2017 at 04:38:13PM +0200, Robert Richter wrote:
> - pr_info("Adding device %s to group %d\n", dev_name(dev), group->id);
> + pr_info("Adding device %s to group %d, default domain type %d\n",
> + dev_name(dev), group->id,
> + group->default_domain ? group->default_domain->type : -1);
Printing just a number is not very user-friendly. We have only two
default domain-types right now, so it is sufficient to just print
additional information if a device is identity-mapped. Something like
"Adding device %s to group %d - using identity mapping"
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robert Richter <rrichter@cavium.com>
Cc: Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: Print a message with the default domain type created
Date: Wed, 26 Apr 2017 17:50:44 +0200 [thread overview]
Message-ID: <20170426155044.GA1332@8bytes.org> (raw)
In-Reply-To: <20170426143813.21225-1-rrichter@cavium.com>
Hi Robert,
On Wed, Apr 26, 2017 at 04:38:13PM +0200, Robert Richter wrote:
> - pr_info("Adding device %s to group %d\n", dev_name(dev), group->id);
> + pr_info("Adding device %s to group %d, default domain type %d\n",
> + dev_name(dev), group->id,
> + group->default_domain ? group->default_domain->type : -1);
Printing just a number is not very user-friendly. We have only two
default domain-types right now, so it is sufficient to just print
additional information if a device is identity-mapped. Something like
"Adding device %s to group %d - using identity mapping"
Regards,
Joerg
next prev parent reply other threads:[~2017-04-26 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 14:38 [PATCH] iommu: Print a message with the default domain type created Robert Richter
2017-04-26 14:38 ` Robert Richter
2017-04-26 14:38 ` Robert Richter
[not found] ` <20170426143813.21225-1-rrichter-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2017-04-26 15:50 ` Joerg Roedel [this message]
2017-04-26 15:50 ` Joerg Roedel
2017-04-26 15:50 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426155044.GA1332@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rrichter-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.