All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Wang, Wei W" <wei.w.wang@intel.com>
Cc: "virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"david@redhat.com" <david@redhat.com>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
	"aarcange@redhat.com" <aarcange@redhat.com>,
	"amit.shah@redhat.com" <amit.shah@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>
Subject: Re: [virtio-dev] Re: [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS
Date: Thu, 27 Apr 2017 02:20:28 +0300	[thread overview]
Message-ID: <20170426192753-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <286AC319A985734F985F78AFA26841F7391F6DCD@shsmsx102.ccr.corp.intel.com>

On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote:
> Hi Michael, could you please give some feedback?

I'm sorry, I'm not sure feedback on what you are requesting.

The interface looks reasonable now, even though there's
a way to make it even simpler if we can limit chunk size
to 2G (in fact 4G - 1). Do you think we can live with this
limitation?

But the code still needs some cleanup.

-- 
MST

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Wang, Wei W" <wei.w.wang@intel.com>
Cc: "virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"david@redhat.com" <david@redhat.com>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
	"aarcange@redhat.com" <aarcange@redhat.com>,
	"amit.shah@redhat.com" <amit.shah@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>
Subject: Re: [virtio-dev] Re: [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS
Date: Thu, 27 Apr 2017 02:20:28 +0300	[thread overview]
Message-ID: <20170426192753-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <286AC319A985734F985F78AFA26841F7391F6DCD@shsmsx102.ccr.corp.intel.com>

On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote:
> Hi Michael, could you please give some feedback?

I'm sorry, I'm not sure feedback on what you are requesting.

The interface looks reasonable now, even though there's
a way to make it even simpler if we can limit chunk size
to 2G (in fact 4G - 1). Do you think we can live with this
limitation?

But the code still needs some cleanup.

-- 
MST

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Wang, Wei W" <wei.w.wang@intel.com>
Cc: "virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"david@redhat.com" <david@redhat.com>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
	"aarcange@redhat.com" <aarcange@redhat.com>,
	"amit.shah@redhat.com" <amit.shah@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>
Subject: Re: [Qemu-devel] [virtio-dev] Re: [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS
Date: Thu, 27 Apr 2017 02:20:28 +0300	[thread overview]
Message-ID: <20170426192753-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <286AC319A985734F985F78AFA26841F7391F6DCD@shsmsx102.ccr.corp.intel.com>

On Wed, Apr 26, 2017 at 11:03:34AM +0000, Wang, Wei W wrote:
> Hi Michael, could you please give some feedback?

I'm sorry, I'm not sure feedback on what you are requesting.

The interface looks reasonable now, even though there's
a way to make it even simpler if we can limit chunk size
to 2G (in fact 4G - 1). Do you think we can live with this
limitation?

But the code still needs some cleanup.

-- 
MST

  parent reply	other threads:[~2017-04-26 23:20 UTC|newest]

Thread overview: 134+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13  9:35 [PATCH v9 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration Wei Wang
2017-04-13  9:35 ` [Qemu-devel] " Wei Wang
2017-04-13  9:35 ` Wei Wang
2017-04-13  9:35 ` [PATCH v9 1/5] virtio-balloon: deflate via a page list Wei Wang
2017-04-13  9:35   ` [Qemu-devel] " Wei Wang
2017-04-13  9:35   ` Wei Wang
2017-04-13  9:35 ` Wei Wang
2017-04-13  9:35 ` [PATCH v9 2/5] virtio-balloon: VIRTIO_BALLOON_F_BALLOON_CHUNKS Wei Wang
2017-04-13  9:35 ` Wei Wang
2017-04-13  9:35   ` [Qemu-devel] " Wei Wang
2017-04-13  9:35   ` Wei Wang
2017-04-13 16:34   ` Michael S. Tsirkin
2017-04-13 16:34     ` [Qemu-devel] " Michael S. Tsirkin
2017-04-13 16:34     ` Michael S. Tsirkin
2017-04-13 17:03     ` Matthew Wilcox
2017-04-13 17:03       ` [Qemu-devel] " Matthew Wilcox
2017-04-13 17:03       ` Matthew Wilcox
2017-04-13 17:03     ` Matthew Wilcox
2017-04-14  8:37     ` [virtio-dev] " Wei Wang
2017-04-14  8:37     ` Wei Wang
2017-04-14  8:37       ` [Qemu-devel] [virtio-dev] " Wei Wang
2017-04-14  8:37       ` Wei Wang
2017-04-14  8:37       ` Wei Wang
2017-04-14 21:38       ` Michael S. Tsirkin
2017-04-14 21:38       ` Michael S. Tsirkin
2017-04-14 21:38         ` [Qemu-devel] [virtio-dev] " Michael S. Tsirkin
2017-04-14 21:38         ` Michael S. Tsirkin
2017-04-14 21:38         ` Michael S. Tsirkin
2017-04-17  3:35         ` Wei Wang
2017-04-17  3:35         ` Wei Wang
2017-04-17  3:35           ` [Qemu-devel] [virtio-dev] " Wei Wang
2017-04-17  3:35           ` Wei Wang
2017-04-17  3:35           ` Wei Wang
2017-04-26 11:03           ` Wang, Wei W
2017-04-26 11:03             ` [Qemu-devel] [virtio-dev] " Wang, Wei W
2017-04-26 11:03             ` Wang, Wei W
2017-04-26 11:03             ` Wang, Wei W
2017-04-26 23:20             ` Michael S. Tsirkin
2017-04-26 23:20             ` Michael S. Tsirkin [this message]
2017-04-26 23:20               ` [Qemu-devel] " Michael S. Tsirkin
2017-04-26 23:20               ` Michael S. Tsirkin
2017-04-27  6:31               ` Wei Wang
2017-04-27  6:31                 ` [Qemu-devel] " Wei Wang
2017-04-27  6:31                 ` Wei Wang
2017-05-05 22:25                 ` Michael S. Tsirkin
2017-05-05 22:25                   ` [Qemu-devel] [virtio-dev] " Michael S. Tsirkin
2017-05-05 22:25                   ` Michael S. Tsirkin
2017-05-05 22:25                   ` Michael S. Tsirkin
2017-05-07  4:19                   ` Wang, Wei W
2017-05-07  4:19                   ` Wang, Wei W
2017-05-07  4:19                     ` [Qemu-devel] [virtio-dev] " Wang, Wei W
2017-05-07  4:19                     ` Wang, Wei W
2017-05-07  4:19                     ` Wang, Wei W
2017-05-08 17:40                     ` Michael S. Tsirkin
2017-05-08 17:40                     ` Michael S. Tsirkin
2017-05-08 17:40                       ` [Qemu-devel] [virtio-dev] " Michael S. Tsirkin
2017-05-08 17:40                       ` Michael S. Tsirkin
2017-05-08 17:40                       ` Michael S. Tsirkin
2017-05-09  2:45                       ` Wei Wang
2017-05-09  2:45                       ` Wei Wang
2017-05-09  2:45                         ` [Qemu-devel] " Wei Wang
2017-05-09  2:45                         ` Wei Wang
2017-05-05 22:25                 ` Michael S. Tsirkin
2017-04-27  6:31               ` Wei Wang
2017-04-26 11:03           ` Wang, Wei W
2017-04-13 16:34   ` Michael S. Tsirkin
2017-04-13  9:35 ` [PATCH v9 3/5] mm: function to offer a page block on the free list Wei Wang
2017-04-13  9:35 ` Wei Wang
2017-04-13  9:35   ` [Qemu-devel] " Wei Wang
2017-04-13  9:35   ` Wei Wang
2017-04-13 20:02   ` Andrew Morton
2017-04-13 20:02     ` [Qemu-devel] " Andrew Morton
2017-04-13 20:02     ` Andrew Morton
2017-04-13 20:02     ` Andrew Morton
2017-04-14  2:30     ` Wei Wang
2017-04-14  2:30     ` Wei Wang
2017-04-14  2:30       ` [Qemu-devel] " Wei Wang
2017-04-14  2:30       ` Wei Wang
2017-04-14  2:58       ` Matthew Wilcox
2017-04-14  2:58       ` Matthew Wilcox
2017-04-14  2:58         ` [Qemu-devel] " Matthew Wilcox
2017-04-14  2:58         ` Matthew Wilcox
2017-04-14  8:58         ` Wei Wang
2017-04-14  8:58         ` Wei Wang
2017-04-14  8:58           ` [Qemu-devel] " Wei Wang
2017-04-14  8:58           ` Wei Wang
2017-04-13  9:35 ` [PATCH v9 4/5] mm: export symbol of next_zone and first_online_pgdat Wei Wang
2017-04-13  9:35 ` Wei Wang
2017-04-13  9:35   ` [Qemu-devel] " Wei Wang
2017-04-13  9:35   ` Wei Wang
2017-04-13  9:35 ` [PATCH v9 5/5] virtio-balloon: VIRTIO_BALLOON_F_MISC_VQ Wei Wang
2017-04-13  9:35 ` Wei Wang
2017-04-13  9:35   ` [Qemu-devel] " Wei Wang
2017-04-13  9:35   ` Wei Wang
2017-04-13 17:08   ` Michael S. Tsirkin
2017-04-13 17:08   ` Michael S. Tsirkin
2017-04-13 17:08     ` [Qemu-devel] " Michael S. Tsirkin
2017-04-13 17:08     ` Michael S. Tsirkin
2017-04-27  6:33     ` Wei Wang
2017-04-27  6:33     ` Wei Wang
2017-04-27  6:33       ` [Qemu-devel] " Wei Wang
2017-04-27  6:33       ` Wei Wang
2017-05-05 22:21       ` Michael S. Tsirkin
2017-05-05 22:21         ` [Qemu-devel] " Michael S. Tsirkin
2017-05-05 22:21         ` Michael S. Tsirkin
2017-05-07  4:20         ` Wang, Wei W
2017-05-07  4:20         ` Wang, Wei W
2017-05-07  4:20           ` [Qemu-devel] " Wang, Wei W
2017-05-07  4:20           ` Wang, Wei W
2017-05-05 22:21       ` Michael S. Tsirkin
2017-04-13 20:44 ` [PATCH v9 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration Matthew Wilcox
2017-04-13 20:44   ` [Qemu-devel] " Matthew Wilcox
2017-04-13 20:44   ` Matthew Wilcox
2017-04-13 20:44   ` Matthew Wilcox
2017-04-14  1:50   ` Michael S. Tsirkin
2017-04-14  1:50     ` [Qemu-devel] " Michael S. Tsirkin
2017-04-14  1:50     ` Michael S. Tsirkin
2017-04-14  2:28     ` Wei Wang
2017-04-14  2:28       ` [Qemu-devel] " Wei Wang
2017-04-14  2:28       ` Wei Wang
2017-04-14  2:57       ` Michael S. Tsirkin
2017-04-14  2:57       ` Michael S. Tsirkin
2017-04-14  2:57         ` [Qemu-devel] " Michael S. Tsirkin
2017-04-14  2:57         ` Michael S. Tsirkin
2017-04-14  2:28     ` Wei Wang
2017-04-14  9:47     ` Matthew Wilcox
2017-04-14  9:47       ` [Qemu-devel] " Matthew Wilcox
2017-04-14  9:47       ` Matthew Wilcox
2017-04-14 14:22       ` Michael S. Tsirkin
2017-04-14 14:22       ` Michael S. Tsirkin
2017-04-14 14:22         ` [Qemu-devel] " Michael S. Tsirkin
2017-04-14 14:22         ` Michael S. Tsirkin
2017-04-14  9:47     ` Matthew Wilcox
2017-04-14  1:50   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426192753-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit.shah@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dave.hansen@intel.com \
    --cc=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=liliang.opensource@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wei.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.