From: Christoph Hellwig <hch@lst.de>
To: Amir Goldstein <amir73il@gmail.com>
Cc: "Darrick J . Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Miklos Szeredi <miklos@szeredi.hu>,
Vivek Goyal <vgoyal@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] xfs: publish UUID in struct super_block
Date: Thu, 27 Apr 2017 09:59:46 +0200 [thread overview]
Message-ID: <20170427075946.GA22284@lst.de> (raw)
In-Reply-To: <1493279911-2936-1-git-send-email-amir73il@gmail.com>
On Thu, Apr 27, 2017 at 10:58:31AM +0300, Amir Goldstein wrote:
> Unless mounted with nouuid, copy the uuid of the filesystem to
> struct super block s_uuid field, as several other filesystems do.
This looks okay ... ish.
Until we have a flag in the superblock that a given fs fills out s_uuid
no one can rely on it. So please add the infrastructure that consumers
can actually make use of it while you're at it.
next prev parent reply other threads:[~2017-04-27 7:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 7:58 [PATCH] xfs: publish UUID in struct super_block Amir Goldstein
2017-04-27 7:59 ` Christoph Hellwig [this message]
2017-04-27 8:01 ` Amir Goldstein
2017-04-27 8:36 ` Amir Goldstein
2017-04-27 12:57 ` David Howells
2017-04-27 13:08 ` Amir Goldstein
2017-04-27 13:22 ` David Howells
2017-04-27 13:50 ` Eric Sandeen
2017-04-27 13:55 ` Amir Goldstein
2017-04-27 14:00 ` David Howells
2017-04-27 14:08 ` Amir Goldstein
2017-04-27 19:31 ` Darrick J. Wong
2017-04-27 20:30 ` Eric Sandeen
2017-04-28 5:49 ` Andy Whitcroft
2017-04-28 5:56 ` Darrick J. Wong
2017-04-28 6:18 ` Amir Goldstein
2017-04-28 6:24 ` Miklos Szeredi
2017-04-28 6:11 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427075946.GA22284@lst.de \
--to=hch@lst.de \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.