From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
Amir Goldstein <amir73il@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Miklos Szeredi <miklos@szeredi.hu>,
Vivek Goyal <vgoyal@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-xfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] xfs: publish UUID in struct super_block
Date: Thu, 27 Apr 2017 22:56:58 -0700 [thread overview]
Message-ID: <20170428055658.GD22884@birch.djwong.org> (raw)
In-Reply-To: <20170428054945.rg54cm5yftfuqfsf@brain>
On Fri, Apr 28, 2017 at 06:49:45AM +0100, Andy Whitcroft wrote:
> On Thu, Apr 27, 2017 at 03:30:35PM -0500, Eric Sandeen wrote:
>
> > It'd be trivial to make that a vfs function and set a flag on the vfs super
> > if the UUID is not unique. Would that be worthwhile? I can send a patch
> > if so.
>
> This only tells you that the UUID it has is unique now. As you are
> contemplating storing them in the FS they have to be unique in space
> _and_ time. No check you can do now can tell you if the UUID is unique
> for all time. Right ?
Well, since we're talking about all time: "probably" :P
That said, Eric was talking about a refactoring of one of XFS's mount
time checks that errors out if there's already a mounted fs with the
same uuid. We use it to avoid catastrophic mounting of the same fs from
multiple (misconfigured) multipaths/snapshots/volumes/whatever on the
same machine. Not sure if that's useful for Amir's case.
--D
>
> -apw
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-28 5:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 7:58 [PATCH] xfs: publish UUID in struct super_block Amir Goldstein
2017-04-27 7:59 ` Christoph Hellwig
2017-04-27 8:01 ` Amir Goldstein
2017-04-27 8:36 ` Amir Goldstein
2017-04-27 12:57 ` David Howells
2017-04-27 13:08 ` Amir Goldstein
2017-04-27 13:22 ` David Howells
2017-04-27 13:50 ` Eric Sandeen
2017-04-27 13:55 ` Amir Goldstein
2017-04-27 14:00 ` David Howells
2017-04-27 14:08 ` Amir Goldstein
2017-04-27 19:31 ` Darrick J. Wong
2017-04-27 20:30 ` Eric Sandeen
2017-04-28 5:49 ` Andy Whitcroft
2017-04-28 5:56 ` Darrick J. Wong [this message]
2017-04-28 6:18 ` Amir Goldstein
2017-04-28 6:24 ` Miklos Szeredi
2017-04-28 6:11 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428055658.GD22884@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=amir73il@gmail.com \
--cc=apw@canonical.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sandeen@sandeen.net \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.