From: jnair@caviumnetworks.com (Jayachandran C)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] perf utils: passing pmu as a parameter to function get_cpuid_str
Date: Fri, 28 Apr 2017 09:08:08 +0000 [thread overview]
Message-ID: <20170428090808.GA84977@localhost> (raw)
In-Reply-To: <1493355227-31492-2-git-send-email-ganapatrao.kulkarni@cavium.com>
On Fri, Apr 28, 2017 at 10:23:44AM +0530, Ganapatrao Kulkarni wrote:
> cpuid string will not be same on all CPUs on heterogeneous
> platforms like ARM's big.LITTLE, adding provision(using pmu->cpus)
> to find cpuid string from associated CPUs of PMU CORE device.
>
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> ---
> tools/perf/arch/powerpc/util/header.c | 3 ++-
> tools/perf/arch/x86/util/header.c | 4 +++-
> tools/perf/util/header.h | 3 ++-
> tools/perf/util/pmu.c | 10 ++++++----
> 4 files changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c
> index 9aaa6f5..9a70cc1 100644
> --- a/tools/perf/arch/powerpc/util/header.c
> +++ b/tools/perf/arch/powerpc/util/header.c
> @@ -34,10 +34,11 @@
> }
>
> char *
> -get_cpuid_str(void)
> +get_cpuid_str(struct perf_pmu *pmu)
> {
> char *bufp;
>
> + do { if (pmu) {} } while (0);
If this is to avoid warnings, can you use __maybe_unused here?
JC.
WARNING: multiple messages have this Message-ID (diff)
From: Jayachandran C <jnair@caviumnetworks.com>
To: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com,
catalin.marinas@arm.com, mark.rutland@arm.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, peterz@infradead.org,
mingo@redhat.com, gpkulkarni@gmail.com
Subject: Re: [PATCH v2 1/4] perf utils: passing pmu as a parameter to function get_cpuid_str
Date: Fri, 28 Apr 2017 09:08:08 +0000 [thread overview]
Message-ID: <20170428090808.GA84977@localhost> (raw)
In-Reply-To: <1493355227-31492-2-git-send-email-ganapatrao.kulkarni@cavium.com>
On Fri, Apr 28, 2017 at 10:23:44AM +0530, Ganapatrao Kulkarni wrote:
> cpuid string will not be same on all CPUs on heterogeneous
> platforms like ARM's big.LITTLE, adding provision(using pmu->cpus)
> to find cpuid string from associated CPUs of PMU CORE device.
>
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> ---
> tools/perf/arch/powerpc/util/header.c | 3 ++-
> tools/perf/arch/x86/util/header.c | 4 +++-
> tools/perf/util/header.h | 3 ++-
> tools/perf/util/pmu.c | 10 ++++++----
> 4 files changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c
> index 9aaa6f5..9a70cc1 100644
> --- a/tools/perf/arch/powerpc/util/header.c
> +++ b/tools/perf/arch/powerpc/util/header.c
> @@ -34,10 +34,11 @@
> }
>
> char *
> -get_cpuid_str(void)
> +get_cpuid_str(struct perf_pmu *pmu)
> {
> char *bufp;
>
> + do { if (pmu) {} } while (0);
If this is to avoid warnings, can you use __maybe_unused here?
JC.
next prev parent reply other threads:[~2017-04-28 9:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 4:53 [PATCH v2 0/4] Add support for ThunderX2 pmu events using json files Ganapatrao Kulkarni
2017-04-28 4:53 ` Ganapatrao Kulkarni
2017-04-28 4:53 ` [PATCH v2 1/4] perf utils: passing pmu as a parameter to function get_cpuid_str Ganapatrao Kulkarni
2017-04-28 4:53 ` Ganapatrao Kulkarni
2017-04-28 9:08 ` Jayachandran C [this message]
2017-04-28 9:08 ` Jayachandran C
2017-04-28 9:19 ` Ganapatrao Kulkarni
2017-04-28 9:19 ` Ganapatrao Kulkarni
2017-04-28 4:53 ` [PATCH v2 2/4] perf tools arm64: Add support for get_cpuid_str function Ganapatrao Kulkarni
2017-04-28 4:53 ` Ganapatrao Kulkarni
2017-04-28 4:53 ` [PATCH v2 3/4] perf utils: Add helper function is_pmu_core to detect PMU CORE devices Ganapatrao Kulkarni
2017-04-28 4:53 ` Ganapatrao Kulkarni
2017-04-28 4:53 ` [PATCH v2 4/4] perf vendor events arm64: Add implementation defined pmu core events of ThunderX2 Ganapatrao Kulkarni
2017-04-28 4:53 ` Ganapatrao Kulkarni
2017-04-28 17:20 ` Will Deacon
2017-04-28 17:20 ` Will Deacon
2017-05-02 8:27 ` Ganapatrao Kulkarni
2017-05-02 8:27 ` Ganapatrao Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428090808.GA84977@localhost \
--to=jnair@caviumnetworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.