From: Florian Westphal <fw@strlen.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] netfilter: x_tables: unlock on error in xt_find_table_lock()
Date: Fri, 28 Apr 2017 13:03:14 +0000 [thread overview]
Message-ID: <20170428130314.GA26935@breakpoint.cc> (raw)
In-Reply-To: <20170428125756.s4ycoffclspnr4zo@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> According to my static checker we should unlock here before the return.
> That seems reasonable to me as well.
Indeed, thanks for the fix!
Acked-by: Florian Westphal <fw@strlen.de>
WARNING: multiple messages have this Message-ID (diff)
From: Florian Westphal <fw@strlen.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] netfilter: x_tables: unlock on error in xt_find_table_lock()
Date: Fri, 28 Apr 2017 15:03:14 +0200 [thread overview]
Message-ID: <20170428130314.GA26935@breakpoint.cc> (raw)
In-Reply-To: <20170428125756.s4ycoffclspnr4zo@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> According to my static checker we should unlock here before the return.
> That seems reasonable to me as well.
Indeed, thanks for the fix!
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2017-04-28 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 12:57 [PATCH] netfilter: x_tables: unlock on error in xt_find_table_lock() Dan Carpenter
2017-04-28 12:57 ` Dan Carpenter
2017-04-28 13:03 ` Florian Westphal [this message]
2017-04-28 13:03 ` Florian Westphal
2017-04-28 13:51 ` Pablo Neira Ayuso
2017-04-28 13:51 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428130314.GA26935@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-janitors@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.