* [U-Boot] [PATCH v2] tools: moveconfig: cleanup whitelist entries
@ 2017-04-28 16:14 Chris Packham
2017-04-28 16:17 ` Simon Glass
0 siblings, 1 reply; 2+ messages in thread
From: Chris Packham @ 2017-04-28 16:14 UTC (permalink / raw)
To: u-boot
After moving to KConfig and removing from all headers options should be
removed from config_whitelist.txt so the build starts complaining if
someone adds them back.
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
Simon asked for it so here you go. I also thought about cleaning up the
README file references too but that will take a little bit of work to
parse reliably.
Changes in v2:
- Correct typo
- Collect act from Masahiro
tools/moveconfig.py | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/tools/moveconfig.py b/tools/moveconfig.py
index dcca0ec..d39ad02 100755
--- a/tools/moveconfig.py
+++ b/tools/moveconfig.py
@@ -601,6 +601,33 @@ def cleanup_extra_options(configs, options):
cleanup_one_extra_option(os.path.join('configs', defconfig), configs,
options)
+def cleanup_whitelist(configs, options):
+ """Delete config whitelist entries
+
+ Arguments:
+ configs: A list of CONFIGs to remove.
+ options: option flags.
+ """
+ if not options.yes:
+ while True:
+ choice = (raw_input('Clean up whitelist entries? [y/n]: ').
+ lower())
+ print choice
+ if choice == 'y' or choice == 'n':
+ break
+
+ if choice == 'n':
+ return
+
+ with open(os.path.join('scripts', 'config_whitelist.txt')) as f:
+ lines = f.readlines()
+
+ lines = [x for x in lines if x.strip() not in configs]
+
+ with open(os.path.join('scripts', 'config_whitelist.txt'), 'w') as f:
+ f.write(''.join(lines))
+
+
### classes ###
class Progress:
@@ -1297,6 +1324,7 @@ def main():
if configs:
cleanup_headers(configs, options)
cleanup_extra_options(configs, options)
+ cleanup_whitelist(configs, options)
if options.commit:
subprocess.call(['git', 'add', '-u'])
--
2.10.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot] [PATCH v2] tools: moveconfig: cleanup whitelist entries
2017-04-28 16:14 [U-Boot] [PATCH v2] tools: moveconfig: cleanup whitelist entries Chris Packham
@ 2017-04-28 16:17 ` Simon Glass
0 siblings, 0 replies; 2+ messages in thread
From: Simon Glass @ 2017-04-28 16:17 UTC (permalink / raw)
To: u-boot
On 28 April 2017 at 10:14, Chris Packham <judge.packham@gmail.com> wrote:
> After moving to KConfig and removing from all headers options should be
> removed from config_whitelist.txt so the build starts complaining if
> someone adds them back.
>
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> Simon asked for it so here you go. I also thought about cleaning up the
> README file references too but that will take a little bit of work to
> parse reliably.
>
> Changes in v2:
> - Correct typo
> - Collect act from Masahiro
>
> tools/moveconfig.py | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
Great thank you Chris.
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-28 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-28 16:14 [U-Boot] [PATCH v2] tools: moveconfig: cleanup whitelist entries Chris Packham
2017-04-28 16:17 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.