All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Chen-Yu Tsai <wens@csie.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Icenowy Zheng <icenowy@aosc.xyz>,
	Tobias Regnery <tobias.regnery@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: sunxi-ng: always select CCU_GATE
Date: Fri, 28 Apr 2017 10:48:56 -0700	[thread overview]
Message-ID: <20170428174856.GA7065@codeaurora.org> (raw)
In-Reply-To: <20170428073542.jamyyjgafirqtth4@lukather>

On 04/28, Maxime Ripard wrote:
> 1;4601;0c
> On Thu, Apr 27, 2017 at 01:02:31PM +0200, Arnd Bergmann wrote:
> > When the base driver is enabled but all SoC specific drivers are turned
> > off, we now get a build error after code was added to always refer to the
> > clk gates:
> > 
> > drivers/clk/built-in.o: In function `ccu_pll_notifier_cb':
> > :(.text+0x154f8): undefined reference to `ccu_gate_helper_disable'
> > :(.text+0x15504): undefined reference to `ccu_gate_helper_enable'
> > 
> > This changes the Kconfig to always require the gate code to be built-in
> > when CONFIG_SUNXI_CCU is set.
> > 
> > Fixes: 02ae2bc6febd ("clk: sunxi-ng: Add clk notifier to gate then ungate PLL clocks")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> 
> Stephen, Mike, can you apply this patch directly? This affects the
> current (4.11) release, so we probably don't want to have the overhead
> of a PR here :/
> 

Yep. Applied to fixes to be sent off today.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: sunxi-ng: always select CCU_GATE
Date: Fri, 28 Apr 2017 10:48:56 -0700	[thread overview]
Message-ID: <20170428174856.GA7065@codeaurora.org> (raw)
In-Reply-To: <20170428073542.jamyyjgafirqtth4@lukather>

On 04/28, Maxime Ripard wrote:
> 1;4601;0c
> On Thu, Apr 27, 2017 at 01:02:31PM +0200, Arnd Bergmann wrote:
> > When the base driver is enabled but all SoC specific drivers are turned
> > off, we now get a build error after code was added to always refer to the
> > clk gates:
> > 
> > drivers/clk/built-in.o: In function `ccu_pll_notifier_cb':
> > :(.text+0x154f8): undefined reference to `ccu_gate_helper_disable'
> > :(.text+0x15504): undefined reference to `ccu_gate_helper_enable'
> > 
> > This changes the Kconfig to always require the gate code to be built-in
> > when CONFIG_SUNXI_CCU is set.
> > 
> > Fixes: 02ae2bc6febd ("clk: sunxi-ng: Add clk notifier to gate then ungate PLL clocks")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> 
> Stephen, Mike, can you apply this patch directly? This affects the
> current (4.11) release, so we probably don't want to have the overhead
> of a PR here :/
> 

Yep. Applied to fixes to be sent off today.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2017-04-28 17:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 11:02 [PATCH] clk: sunxi-ng: always select CCU_GATE Arnd Bergmann
2017-04-27 11:02 ` Arnd Bergmann
2017-04-28  7:35 ` Maxime Ripard
2017-04-28  7:35   ` Maxime Ripard
2017-04-28 17:48   ` Stephen Boyd [this message]
2017-04-28 17:48     ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170428174856.GA7065@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=icenowy@aosc.xyz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mturquette@baylibre.com \
    --cc=tobias.regnery@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.