From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] ext2.mk: ensure file system block count is not zero (0)
Date: Sat, 29 Apr 2017 21:03:58 +0200 [thread overview]
Message-ID: <20170429210358.716c51d4@free-electrons.com> (raw)
In-Reply-To: <1493481682-128366-1-git-send-email-g4@novadsp.com>
Hello,
On Sat, 29 Apr 2017 17:01:21 +0100, J Evans wrote:
> -ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)),0)
> +ifeq ($(strip $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)),0)
> +$(error BR2_TARGET_ROOTFS_EXT2_BLOCKS cannot be zero (0))
> +else
> EXT2_OPTS += -b $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)
> endif
What is the motivation for checking that the size is not zero? Zero is
like any other size too small to contain the target directory contents,
so I don't see why we would add a specific check for it.
Your commit log unfortunately only explains *what* the commit is doing
(which is obvious by reading the code) but not *why* this change is
necessary.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-29 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 16:01 [Buildroot] [PATCH 1/2] ext2.mk: ensure file system block count is not zero (0) J Evans
2017-04-29 16:01 ` [Buildroot] [PATCH 2/2] mke2img: add parameter sanity checks to prevent odd error messages from genext2.fs J Evans
2017-04-29 19:06 ` Thomas Petazzoni
2017-04-30 9:25 ` Yann E. MORIN
2017-04-30 9:32 ` Thomas Petazzoni
2017-04-29 19:03 ` Thomas Petazzoni [this message]
2017-04-30 9:18 ` [Buildroot] [PATCH 1/2] ext2.mk: ensure file system block count is not zero (0) Yann E. MORIN
2017-04-30 12:18 ` jerry at chordia.co.uk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170429210358.716c51d4@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.