From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] mke2img: add parameter sanity checks to prevent odd error messages from genext2.fs
Date: Sun, 30 Apr 2017 11:32:59 +0200 [thread overview]
Message-ID: <20170430113259.0dd3eb78@free-electrons.com> (raw)
In-Reply-To: <20170430092533.GB12749@scaer>
Hello,
On Sun, 30 Apr 2017 11:25:33 +0200, Yann E. MORIN wrote:
> > $ ./package/mke2img/mke2img -b
> > mke2img: option 'b' expects a mandatory argument
> >
> > So it is already checked that ${nb_blocks} cannot be empty.
>
> But if you don't pass the -b option, then nb_blocks *is* unset.
>
> Adding the check is correct in my opinion.
Ah, yes agreed.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-04-30 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 16:01 [Buildroot] [PATCH 1/2] ext2.mk: ensure file system block count is not zero (0) J Evans
2017-04-29 16:01 ` [Buildroot] [PATCH 2/2] mke2img: add parameter sanity checks to prevent odd error messages from genext2.fs J Evans
2017-04-29 19:06 ` Thomas Petazzoni
2017-04-30 9:25 ` Yann E. MORIN
2017-04-30 9:32 ` Thomas Petazzoni [this message]
2017-04-29 19:03 ` [Buildroot] [PATCH 1/2] ext2.mk: ensure file system block count is not zero (0) Thomas Petazzoni
2017-04-30 9:18 ` Yann E. MORIN
2017-04-30 12:18 ` jerry at chordia.co.uk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170430113259.0dd3eb78@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.