From: David Lin <dtwlin@google.com>
To: corbet@lwn.net, rpurdie@rpsys.net, jacek.anaszewski@gmail.com,
pavel@ucw.cz, hdegoede@redhat.com, mark.rutland@arm.com,
tony.makkiel@daqri.com, linz@li-pro.net
Cc: robh@kernel.org, romlem@google.com, joelaf@google.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, David Lin <dtwlin@google.com>
Subject: [PATCH 1/3] leds: Replace flags bit shift with BIT() macros
Date: Sun, 30 Apr 2017 14:36:59 -0700 [thread overview]
Message-ID: <20170430213701.12297-2-dtwlin@google.com> (raw)
In-Reply-To: <20170430213701.12297-1-dtwlin@google.com>
This is for readability as well as to avoid checkpatch warnings when
adding new bit flag information in the future.
Signed-off-by: David Lin <dtwlin@google.com>
---
include/linux/leds.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/linux/leds.h b/include/linux/leds.h
index 64c56d454f7d..f9d10a9efcbe 100644
--- a/include/linux/leds.h
+++ b/include/linux/leds.h
@@ -43,12 +43,12 @@ struct led_classdev {
#define LED_SUSPENDED (1 << 0)
#define LED_UNREGISTERING (1 << 1)
/* Upper 16 bits reflect control information */
-#define LED_CORE_SUSPENDRESUME (1 << 16)
-#define LED_SYSFS_DISABLE (1 << 17)
-#define LED_DEV_CAP_FLASH (1 << 18)
-#define LED_HW_PLUGGABLE (1 << 19)
-#define LED_PANIC_INDICATOR (1 << 20)
-#define LED_BRIGHT_HW_CHANGED (1 << 21)
+#define LED_CORE_SUSPENDRESUME BIT(16)
+#define LED_SYSFS_DISABLE BIT(17)
+#define LED_DEV_CAP_FLASH BIT(18)
+#define LED_HW_PLUGGABLE BIT(19)
+#define LED_PANIC_INDICATOR BIT(20)
+#define LED_BRIGHT_HW_CHANGED BIT(21)
/* set_brightness_work / blink_timer flags, atomic, private. */
unsigned long work_flags;
--
2.13.0.rc0.306.g87b477812d-goog
next prev parent reply other threads:[~2017-04-30 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 21:36 [PATCH 0/3] led: ledtrig-transient: add support for hrtimer David Lin
2017-04-30 21:36 ` David Lin [this message]
2017-05-08 20:24 ` [PATCH 1/3] leds: Replace flags bit shift with BIT() macros Jacek Anaszewski
2017-04-30 21:37 ` [PATCH 2/3] leds: Add the LED_BRIGHTNESS_FAST flag David Lin
2017-04-30 21:37 ` [PATCH 3/3] led: ledtrig-transient: add support for hrtimer David Lin
2017-05-08 20:25 ` Jacek Anaszewski
2017-05-04 0:28 ` [PATCH 0/3] " David Lin
2017-05-08 21:06 ` Pavel Machek
2017-05-09 20:43 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170430213701.12297-2-dtwlin@google.com \
--to=dtwlin@google.com \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=jacek.anaszewski@gmail.com \
--cc=joelaf@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linz@li-pro.net \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=romlem@google.com \
--cc=rpurdie@rpsys.net \
--cc=tony.makkiel@daqri.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.