From: Pavel Machek <pavel@ucw.cz>
To: David Lin <dtwlin@google.com>
Cc: corbet@lwn.net, rpurdie@rpsys.net, jacek.anaszewski@gmail.com,
hdegoede@redhat.com, mark.rutland@arm.com,
tony.makkiel@daqri.com, linz@li-pro.net, robh@kernel.org,
romlem@google.com, joelaf@google.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 0/3] led: ledtrig-transient: add support for hrtimer
Date: Mon, 8 May 2017 23:06:02 +0200 [thread overview]
Message-ID: <20170508210602.GA7260@amd> (raw)
In-Reply-To: <20170430213701.12297-1-dtwlin@google.com>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
On Sun 2017-04-30 14:36:58, David Lin wrote:
> Hi,
>
> These patch series add the LED_BRIGHTNESS_FAST flag support for
> ledtrig-transient to use hrtimer so that platforms with high-resolution timer
> support can have better accuracy in the trigger duration timing. The need for
> this support is driven by the fact that Android has removed the timed_ouput [1]
> and is now using led-trigger for handling vibrator control which requires the
> timer to be accurate up to a millisecond. However, this flag support would also
> allow hrtimer to co-exist with the ktimer without causing warning to the
> existing drivers [2].
Yes, and objection still stands: You are misusing LED subsystem for
vibration motors. We already have support for haptic feedback in input
subsystem.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-05-08 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 21:36 [PATCH 0/3] led: ledtrig-transient: add support for hrtimer David Lin
2017-04-30 21:36 ` [PATCH 1/3] leds: Replace flags bit shift with BIT() macros David Lin
2017-05-08 20:24 ` Jacek Anaszewski
2017-04-30 21:37 ` [PATCH 2/3] leds: Add the LED_BRIGHTNESS_FAST flag David Lin
2017-04-30 21:37 ` [PATCH 3/3] led: ledtrig-transient: add support for hrtimer David Lin
2017-05-08 20:25 ` Jacek Anaszewski
2017-05-04 0:28 ` [PATCH 0/3] " David Lin
2017-05-08 21:06 ` Pavel Machek [this message]
2017-05-09 20:43 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508210602.GA7260@amd \
--to=pavel@ucw.cz \
--cc=corbet@lwn.net \
--cc=dtwlin@google.com \
--cc=hdegoede@redhat.com \
--cc=jacek.anaszewski@gmail.com \
--cc=joelaf@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linz@li-pro.net \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=romlem@google.com \
--cc=rpurdie@rpsys.net \
--cc=tony.makkiel@daqri.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.