From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] dmaengine: Add STM32 DMAMUX driver
Date: Mon, 1 May 2017 11:33:53 +0530 [thread overview]
Message-ID: <20170501060353.GO6263@localhost> (raw)
In-Reply-To: <d18cb12d-1fd1-39d2-501a-18c000b9982e@st.com>
On Wed, Apr 26, 2017 at 09:17:37AM +0000, Pierre Yves MORDRET wrote:
> >> +
> >> + ret = of_property_read_u32(node, "dma-channels",
> >> + &dmamux->dmamux_channels);
> >
> > can we have property_xxx calls alone, that way driver is not strictly
> > dependent on of
>
> Can you please explain what you are asking for ? Not sure to understand
> correctly.
Use device_property_read_u32() which is a generic property API.
> >> +static int __init stm32_dmamux_init(void)
> >> +{
> >> + return platform_driver_register(&stm32_dmamux_driver);
> >> +}
> >> +arch_initcall(stm32_dmamux_init);
> >
> > why not module init, wouldnt defer probe solve the dependencies
> >
>
> The reason behind many devices (device_initcall level) rely on DMAs. If
> init is deferred DMAMUX driver will be probed twice if dependents rely
> on it. This sounds not a good call. This explains arch_initcall level.
Why not deferred probe was introduced to help with dependencies...
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
Cc: M'boumba Cedric Madianga <cedric.madianga@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Alexandre TORGUE <alexandre.torgue@st.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/5] dmaengine: Add STM32 DMAMUX driver
Date: Mon, 1 May 2017 11:33:53 +0530 [thread overview]
Message-ID: <20170501060353.GO6263@localhost> (raw)
In-Reply-To: <d18cb12d-1fd1-39d2-501a-18c000b9982e@st.com>
On Wed, Apr 26, 2017 at 09:17:37AM +0000, Pierre Yves MORDRET wrote:
> >> +
> >> + ret = of_property_read_u32(node, "dma-channels",
> >> + &dmamux->dmamux_channels);
> >
> > can we have property_xxx calls alone, that way driver is not strictly
> > dependent on of
>
> Can you please explain what you are asking for ? Not sure to understand
> correctly.
Use device_property_read_u32() which is a generic property API.
> >> +static int __init stm32_dmamux_init(void)
> >> +{
> >> + return platform_driver_register(&stm32_dmamux_driver);
> >> +}
> >> +arch_initcall(stm32_dmamux_init);
> >
> > why not module init, wouldnt defer probe solve the dependencies
> >
>
> The reason behind many devices (device_initcall level) rely on DMAs. If
> init is deferred DMAMUX driver will be probed twice if dependents rely
> on it. This sounds not a good call. This explains arch_initcall level.
Why not deferred probe was introduced to help with dependencies...
--
~Vinod
next prev parent reply other threads:[~2017-05-01 6:03 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 14:15 [PATCH 0/5] Add STM32 DMAMUX support M'boumba Cedric Madianga
2017-03-13 14:15 ` M'boumba Cedric Madianga
2017-03-13 14:15 ` M'boumba Cedric Madianga
2017-03-13 14:15 ` [PATCH 1/5] dt-bindings: Document the STM32 DMAMUX bindings M'boumba Cedric Madianga
2017-03-13 14:15 ` M'boumba Cedric Madianga
2017-03-13 14:15 ` M'boumba Cedric Madianga
2017-03-20 21:34 ` Rob Herring
2017-03-20 21:34 ` Rob Herring
2017-03-20 21:34 ` Rob Herring
2017-04-26 8:58 ` Pierre Yves MORDRET
2017-04-26 8:58 ` Pierre Yves MORDRET
2017-03-13 14:15 ` [PATCH 2/5] dmaengine: Add STM32 DMAMUX driver M'boumba Cedric Madianga
2017-03-13 14:15 ` M'boumba Cedric Madianga
2017-04-06 6:40 ` Vinod Koul
2017-04-06 6:40 ` Vinod Koul
2017-04-06 6:40 ` Vinod Koul
2017-04-26 9:17 ` Pierre Yves MORDRET
2017-04-26 9:17 ` Pierre Yves MORDRET
2017-04-26 9:17 ` Pierre Yves MORDRET
2017-05-01 6:03 ` Vinod Koul [this message]
2017-05-01 6:03 ` Vinod Koul
2017-05-04 15:28 ` Pierre Yves MORDRET
2017-05-04 15:28 ` Pierre Yves MORDRET
2017-03-13 14:15 ` [PATCH 3/5] dt-bindings: stm32-dma: Add property to handle STM32 DMAMUX M'boumba Cedric Madianga
2017-03-13 14:15 ` M'boumba Cedric Madianga
2017-03-13 14:15 ` M'boumba Cedric Madianga
2017-03-20 21:37 ` Rob Herring
2017-03-20 21:37 ` Rob Herring
2017-03-20 21:37 ` Rob Herring
2017-04-26 9:23 ` Pierre Yves MORDRET
2017-04-26 9:23 ` Pierre Yves MORDRET
2017-04-26 9:23 ` Pierre Yves MORDRET
2017-03-13 14:16 ` [PATCH 4/5] dmaengine: stm32-dma: Add support for " M'boumba Cedric Madianga
2017-03-13 14:16 ` M'boumba Cedric Madianga
2017-03-13 14:16 ` M'boumba Cedric Madianga
2017-03-13 14:16 ` [PATCH 5/5] ARM: configs: stm32: Add DMAMUX support in STM32 defconfig M'boumba Cedric Madianga
2017-03-13 14:16 ` M'boumba Cedric Madianga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501060353.GO6263@localhost \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.