From: Stephen Hemminger <stephen@networkplumber.org>
To: Amir Vadai <amir@vadai.me>
Cc: netdev@vger.kernel.org, Or Gerlitz <ogerlitz@mellanox.com>,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH iproute2 net 2/8] tc/pedit: Extend pedit to specify offset relative to mac/transport headers
Date: Mon, 1 May 2017 09:21:13 -0700 [thread overview]
Message-ID: <20170501092113.57fd2892@xeon-e3> (raw)
In-Reply-To: <20170423125356.1298-3-amir@vadai.me>
On Sun, 23 Apr 2017 15:53:50 +0300
Amir Vadai <amir@vadai.me> wrote:
> -extern int parse_cmd(int *argc_p, char ***argv_p, __u32 len, int type,__u32 retain,struct tc_pedit_sel *sel,struct tc_pedit_key *tkey);
> -extern int pack_key(struct tc_pedit_sel *sel,struct tc_pedit_key *tkey);
> -extern int pack_key32(__u32 retain,struct tc_pedit_sel *sel,struct tc_pedit_key *tkey);
> -extern int pack_key16(__u32 retain,struct tc_pedit_sel *sel,struct tc_pedit_key *tkey);
> -extern int pack_key8(__u32 retain,struct tc_pedit_sel *sel,struct tc_pedit_key *tkey);
> +extern int pack_key(struct m_pedit_sel *sel, struct m_pedit_key *tkey);
> +extern int pack_key32(__u32 retain, struct m_pedit_sel *sel, struct m_pedit_key *tkey);
> +extern int pack_key16(__u32 retain, struct m_pedit_sel *sel, struct m_pedit_key *tkey);
> +extern int pack_key8(__u32 retain, struct m_pedit_sel *sel, struct m_pedit_key *tkey);
> extern int parse_val(int *argc_p, char ***argv_p, __u32 * val, int type);
> -extern int parse_cmd(int *argc_p, char ***argv_p, __u32 len, int type,__u32 retain,struct tc_pedit_sel *sel,struct tc_pedit_key *tkey);
> -extern int parse_offset(int *argc_p, char ***argv_p,struct tc_pedit_sel *sel,struct tc_pedit_key *tkey);
> +extern int parse_cmd(int *argc_p, char ***argv_p, __u32 len, int type, __u32 retain,
> + struct m_pedit_sel *sel, struct m_pedit_key *tkey);
> +extern int parse_offset(int *argc_p, char ***argv_p,
> + struct m_pedit_sel *sel, struct m_pedit_key *tkey);
> int parse_pedit(struct action_util *a, int *argc_p, char ***argv_p, int tc
Please add newline to break the overly long lines here.
Try and keep with in the 80 column convention.
next prev parent reply other threads:[~2017-05-01 16:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 12:53 [PATCH iproute2 net 0/8] tc/act_pedit: Support offset relative to conventional header Amir Vadai
2017-04-23 12:53 ` [PATCH iproute2 net 1/8] tc/pedit: Fix a typo in pedit usage message Amir Vadai
2017-04-23 12:53 ` [PATCH iproute2 net 2/8] tc/pedit: Extend pedit to specify offset relative to mac/transport headers Amir Vadai
2017-05-01 16:21 ` Stephen Hemminger [this message]
2017-04-23 12:53 ` [PATCH iproute2 net 3/8] tc/pedit: Introduce 'add' operation Amir Vadai
2017-04-23 17:44 ` Jamal Hadi Salim
2017-04-24 7:52 ` Amir Vadai
2017-04-24 11:04 ` Or Gerlitz
2017-04-23 12:53 ` [PATCH iproute2 net 4/8] tc/pedit: p_ip: introduce editing ttl header Amir Vadai
2017-04-23 12:53 ` [PATCH iproute2 net 5/8] tc/pedit: Support fields bigger than 32 bits Amir Vadai
2017-04-23 12:53 ` [PATCH iproute2 net 6/8] tc/pedit: p_eth: ETH header editor Amir Vadai
2017-04-23 12:53 ` [PATCH iproute2 net 7/8] tc/pedit: p_tcp: introduce pedit tcp support Amir Vadai
2017-04-23 12:53 ` [PATCH iproute2 net 8/8] tc/pedit: p_udp: introduce pedit udp support Amir Vadai
2017-05-01 16:26 ` [PATCH iproute2 net 0/8] tc/act_pedit: Support offset relative to conventional header Stephen Hemminger
2017-05-03 6:27 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501092113.57fd2892@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=amir@vadai.me \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.