From: Brian Norris <computersforpeace@gmail.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Subject: Re: [PATCH] mtd: nand: don't leak buffers when ->scan_bbt() fails
Date: Mon, 1 May 2017 18:33:13 -0700 [thread overview]
Message-ID: <20170502013313.GA136952@google.com> (raw)
In-Reply-To: <CAAEAJfAvSGz5-B2rLTzr-W-Hmv_m9NSZz_fx9Q-bY_kRc8yaLQ@mail.gmail.com>
On Mon, May 01, 2017 at 09:22:03PM -0300, Ezequiel Garcia wrote:
> On 1 May 2017 at 21:04, Brian Norris <computersforpeace@gmail.com> wrote:
> > This bug seems to have been here forever, although we came close to
> > fixing all of them in [1]!
> >
> > [1] 11eaf6df1cce ("mtd: nand: Remove BUG() abuse in nand_scan_tail")
> >
>
> Well, we came even closer. See [1] for a patch that fixes this by cleaning
> BBT init and release.
That's a different bug(fix), no?
> Back then Boris suggested on IRC to wait for Peter Pan's BBT, which would
> address this too.
Haha, well bad strategy I guess :)
> It's interesting to note that: (1) the patch never got any formal feedback,
> despite it was a fix; and (2) Peter Pan's work is still under development.
Yes, well you kinda nacked yourself, so (1) isn't that surprising. And
(2) is well...no comment.
> Guess I should have pressed the upstream buttons harder :-)
I suppose.
I'd be happy to see you resubmit, since I definitely would prioritize
bugfixes over years-long refactoring. But I guess I'd defer to Boris, et
al, who are paying much more attention to NAND stuff these days than I
am. I just noticed this when bugfixing some things I noticed in Boris's
pull request.
Brian
> [1] http://lists.infradead.org/pipermail/linux-mtd/2016-April/066834.html,
> [2] http://lists.infradead.org/pipermail/linux-mtd/2016-April/066835.html
> --
> Ezequiel García, VanguardiaSur
> www.vanguardiasur.com.ar
next prev parent reply other threads:[~2017-05-02 1:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 0:04 [PATCH] mtd: nand: don't leak buffers when ->scan_bbt() fails Brian Norris
2017-05-02 0:04 ` [PATCH] mtd: nand: don't make vendor-specific code un-set their data pointer Brian Norris
2017-05-02 7:15 ` Boris Brezillon
2017-05-02 0:04 ` [PATCH] mtd: nand: drop unneeded module.h include Brian Norris
2017-05-02 7:16 ` Boris Brezillon
2017-05-15 20:50 ` Boris Brezillon
2017-05-02 0:04 ` [PATCH] mtd: nand: free vendor-specific resources in init failure paths Brian Norris
2017-05-02 7:52 ` Boris Brezillon
2017-05-02 16:15 ` Boris Brezillon
2017-05-15 20:49 ` Boris Brezillon
2017-05-02 0:04 ` [PATCH] mtd: nand: orion: don't complain for probe deferral Brian Norris
2017-05-02 7:56 ` Boris Brezillon
2017-05-02 8:07 ` Simon Baatz
2017-05-08 17:46 ` Brian Norris
2017-05-02 0:04 ` [PATCH] mtd: nand: samsung: warn about un-parseable ECC info Brian Norris
2017-05-02 7:57 ` Boris Brezillon
2017-05-15 20:48 ` Boris Brezillon
2017-05-02 0:22 ` [PATCH] mtd: nand: don't leak buffers when ->scan_bbt() fails Ezequiel Garcia
2017-05-02 1:33 ` Brian Norris [this message]
2017-05-02 2:21 ` Ezequiel Garcia
2017-05-02 7:17 ` Boris Brezillon
2017-05-15 20:50 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502013313.GA136952@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.