From: Brian Norris <computersforpeace@gmail.com>
To: Simon Baatz <gmbnomis@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Subject: Re: [PATCH] mtd: nand: orion: don't complain for probe deferral
Date: Mon, 8 May 2017 10:46:22 -0700 [thread overview]
Message-ID: <20170508174622.GA20745@google.com> (raw)
In-Reply-To: <20170502080730.GA7617@gandalf>
On Tue, May 02, 2017 at 10:07:31AM +0200, Simon Baatz wrote:
> Hi Brian,
>
> On Mon, May 01, 2017 at 05:04:54PM -0700, Brian Norris wrote:
> > Recent patches to this driver changed the error handling for missing
> > clocks. Now we'll print an error if the clock causes us to defer
> > probing. Let's not do that.
> >
>
> This is by intention. Probe deferral is not supported by drivers
> using module_platform_driver_probe(). EPROBE_DEFER results in not
> being able to get the clock and, thus, is handled like any other
> error.
Ah, good point. I overlooked that part.
Seems kind of inconsistent driver writing (what happens if someone wants
to use this driver on a more complex system, where some of the dependent
resources are not available at init time?), but I see in the git logs
that apparently this is intentional (to save memory?).
So, I'll NAK this patch.
Brian
next prev parent reply other threads:[~2017-05-08 17:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 0:04 [PATCH] mtd: nand: don't leak buffers when ->scan_bbt() fails Brian Norris
2017-05-02 0:04 ` [PATCH] mtd: nand: don't make vendor-specific code un-set their data pointer Brian Norris
2017-05-02 7:15 ` Boris Brezillon
2017-05-02 0:04 ` [PATCH] mtd: nand: drop unneeded module.h include Brian Norris
2017-05-02 7:16 ` Boris Brezillon
2017-05-15 20:50 ` Boris Brezillon
2017-05-02 0:04 ` [PATCH] mtd: nand: free vendor-specific resources in init failure paths Brian Norris
2017-05-02 7:52 ` Boris Brezillon
2017-05-02 16:15 ` Boris Brezillon
2017-05-15 20:49 ` Boris Brezillon
2017-05-02 0:04 ` [PATCH] mtd: nand: orion: don't complain for probe deferral Brian Norris
2017-05-02 7:56 ` Boris Brezillon
2017-05-02 8:07 ` Simon Baatz
2017-05-08 17:46 ` Brian Norris [this message]
2017-05-02 0:04 ` [PATCH] mtd: nand: samsung: warn about un-parseable ECC info Brian Norris
2017-05-02 7:57 ` Boris Brezillon
2017-05-15 20:48 ` Boris Brezillon
2017-05-02 0:22 ` [PATCH] mtd: nand: don't leak buffers when ->scan_bbt() fails Ezequiel Garcia
2017-05-02 1:33 ` Brian Norris
2017-05-02 2:21 ` Ezequiel Garcia
2017-05-02 7:17 ` Boris Brezillon
2017-05-15 20:50 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508174622.GA20745@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=gmbnomis@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.