From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, linux-oxnas@lists.tuxfamily.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mtd: oxnas_nand: Allocating more than necessary in probe()
Date: Tue, 02 May 2017 16:19:31 +0000 [thread overview]
Message-ID: <20170502181931.66ea6628@bbrezillon> (raw)
In-Reply-To: <20170425091949.uindhaxmbtsksqc7@mwanda>
On Tue, 25 Apr 2017 12:19:49 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We only need to allocate sizeof(struct oxnas_nand_ctrl) which is 192
> bytes and not sizeof(struct nand_chip) which is a much larger 3056
> bytes.
>
> Fixes: 668592492409 ("mtd: nand: Add OX820 NAND Support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> diff --git a/drivers/mtd/nand/oxnas_nand.c b/drivers/mtd/nand/oxnas_nand.c
> index 3e3bf3b364d2..1b207aac840c 100644
> --- a/drivers/mtd/nand/oxnas_nand.c
> +++ b/drivers/mtd/nand/oxnas_nand.c
> @@ -91,7 +91,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
> int err = 0;
>
> /* Allocate memory for the device structure (and zero it) */
> - oxnas = devm_kzalloc(&pdev->dev, sizeof(struct nand_chip),
> + oxnas = devm_kzalloc(&pdev->dev, sizeof(*oxnas),
> GFP_KERNEL);
> if (!oxnas)
> return -ENOMEM;
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, linux-oxnas@lists.tuxfamily.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mtd: oxnas_nand: Allocating more than necessary in probe()
Date: Tue, 2 May 2017 18:19:31 +0200 [thread overview]
Message-ID: <20170502181931.66ea6628@bbrezillon> (raw)
In-Reply-To: <20170425091949.uindhaxmbtsksqc7@mwanda>
On Tue, 25 Apr 2017 12:19:49 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We only need to allocate sizeof(struct oxnas_nand_ctrl) which is 192
> bytes and not sizeof(struct nand_chip) which is a much larger 3056
> bytes.
>
> Fixes: 668592492409 ("mtd: nand: Add OX820 NAND Support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> diff --git a/drivers/mtd/nand/oxnas_nand.c b/drivers/mtd/nand/oxnas_nand.c
> index 3e3bf3b364d2..1b207aac840c 100644
> --- a/drivers/mtd/nand/oxnas_nand.c
> +++ b/drivers/mtd/nand/oxnas_nand.c
> @@ -91,7 +91,7 @@ static int oxnas_nand_probe(struct platform_device *pdev)
> int err = 0;
>
> /* Allocate memory for the device structure (and zero it) */
> - oxnas = devm_kzalloc(&pdev->dev, sizeof(struct nand_chip),
> + oxnas = devm_kzalloc(&pdev->dev, sizeof(*oxnas),
> GFP_KERNEL);
> if (!oxnas)
> return -ENOMEM;
next prev parent reply other threads:[~2017-05-02 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 9:19 [PATCH] mtd: oxnas_nand: Allocating more than necessary in probe() Dan Carpenter
2017-04-25 9:19 ` Dan Carpenter
2017-04-25 9:42 ` Neil Armstrong
2017-04-25 9:42 ` Neil Armstrong
2017-05-02 16:19 ` Boris Brezillon [this message]
2017-05-02 16:19 ` Boris Brezillon
2017-05-03 1:58 ` Brian Norris
2017-05-03 1:58 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502181931.66ea6628@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dan.carpenter@oracle.com \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-oxnas@lists.tuxfamily.org \
--cc=marek.vasut@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.